[linker] OutputStep should not create readonly filesmono-2018-08

File.Copy will preserve permissions and create readonly files.
We should create writeable files instead.

See https://github.com/mono/mono/issues/10743

1 files changed, 12 insertions, 3 deletions

diff --git a/linker/Linker.Steps/OutputStep.cs b/linker/Linker.Steps/OutputStep.cs
index 61852b7c1..4969ef81e 100644
--- a/linker/Linker.Steps/OutputStep.cs
+++ b/linker/Linker.Steps/OutputStep.cs
@@ -213,18 +213,27 @@ namespace Mono.Linker.Steps {
 			if (source == target)
 				return;
 
-			File.Copy (source, target, true);
+			CopyFileAndRemoveReadOnly (source, target);
 
 			if (!Context.LinkSymbols)
 				return;
 
 			var mdb = source + ".mdb";
 			if (File.Exists (mdb))
-				File.Copy (mdb, target + ".mdb", true);
+				CopyFileAndRemoveReadOnly (mdb, target + ".mdb");
 
 			var pdb = Path.ChangeExtension (source, "pdb");
 			if (File.Exists (pdb))
-				File.Copy (pdb, Path.ChangeExtension (target, "pdb"), true);
+				CopyFileAndRemoveReadOnly (pdb, Path.ChangeExtension (target, "pdb"));
+		}
+
+		static void CopyFileAndRemoveReadOnly (string src, string dest) {
+			File.Copy (src, dest, true);
+
+			FileAttributes attrs = File.GetAttributes (dest);
+
+			if ((attrs & FileAttributes.ReadOnly) == FileAttributes.ReadOnly)
+				File.SetAttributes (dest, attrs & ~FileAttributes.ReadOnly);
 		}
 
 		protected virtual string GetAssemblyFileName (AssemblyDefinition assembly, string directory)