diff options
| author | Jackson Schuster <36744439+jtschuster@users.noreply.github.com> | 2022-08-12 03:34:10 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-12 03:34:10 +0300 |
| commit | 81ffbb5af38a45ff60648999df8f35a79061ae43 (patch) | |
| tree | f7ecec01552a390a9477b72006420eed4aa2c4ad | |
| parent | e45a9356e779e457edf335ea9c34e6c9c49330f6 (diff) | |
Revert analyzer to lower CodeAnalysis version (#2968)
Analyzers look for a newer version of Microsoft.CodeAnalysis than exists in the latest version of Visual Studio, and so they don't run in FullFramework tests in dotnet/sdk#26993. This reverts the version used in the analyzers.
PR #2969 will undo this change once Visual Studio ships with the correct version of Microsoft.CodeAnalysis.
| -rw-r--r-- | src/ILLink.RoslynAnalyzer/ILLink.RoslynAnalyzer.csproj | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/ILLink.RoslynAnalyzer/ILLink.RoslynAnalyzer.csproj b/src/ILLink.RoslynAnalyzer/ILLink.RoslynAnalyzer.csproj index 83eec6896..cafde32b6 100644 --- a/src/ILLink.RoslynAnalyzer/ILLink.RoslynAnalyzer.csproj +++ b/src/ILLink.RoslynAnalyzer/ILLink.RoslynAnalyzer.csproj @@ -15,7 +15,9 @@ <ItemGroup> <None Include="Microsoft.NET.ILLink.Analyzers.props" CopyToOutputDirectory="PreserveNewest" /> - <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="$(MicrosoftCodeAnalysisVersion)" PrivateAssets="all" /> + <!-- The repo CodeAnalyis version is ahead of what is shipped with Visual Studio, so that version breaks the analyzers when used in .Net Framework builds --> + <!-- Once Visual Studio ships with a version >= $MicrosoftCodeAnalysisVersion, this should be changed to use the property --> + <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.3.0-2.final" PrivateAssets="all" /> <PackageReference Condition="'$(DotNetBuildFromSource)' != 'true'" Include="StaticCs" Version="$(StaticCsVersion)"> <PrivateAssets>all</PrivateAssets> <ExcludeAssets>contentfiles</ExcludeAssets> <!-- We include our own copy of the ClosedAttribute to work in source build --> |