diff options
6 files changed, 7 insertions, 12 deletions
diff --git a/Directory.Build.props b/Directory.Build.props index d5d229fdb..c6b56b26a 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -30,5 +30,6 @@ <PropertyGroup> <LangVersion>latest</LangVersion> + <AnalysisLevel>latest</AnalysisLevel> </PropertyGroup> </Project> diff --git a/src/ILLink.CodeFix/RequiresAssemblyFilesCodeFixProvider.cs b/src/ILLink.CodeFix/RequiresAssemblyFilesCodeFixProvider.cs index 5651975b8..bda478122 100644 --- a/src/ILLink.CodeFix/RequiresAssemblyFilesCodeFixProvider.cs +++ b/src/ILLink.CodeFix/RequiresAssemblyFilesCodeFixProvider.cs @@ -18,7 +18,7 @@ namespace ILLink.CodeFix [ExportCodeFixProvider (LanguageNames.CSharp, Name = nameof (RequiresAssemblyFilesCodeFixProvider)), Shared] public class RequiresAssemblyFilesCodeFixProvider : BaseAttributeCodeFixProvider { - public ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create ( + public static ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create ( DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.AvoidAssemblyLocationInSingleFile), DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.AvoidAssemblyGetFilesInSingleFile), DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.RequiresAssemblyFiles)); diff --git a/src/ILLink.CodeFix/RequiresDynamicCodeCodeFixProvider.cs b/src/ILLink.CodeFix/RequiresDynamicCodeCodeFixProvider.cs index 33cbf8838..d7fd860c7 100644 --- a/src/ILLink.CodeFix/RequiresDynamicCodeCodeFixProvider.cs +++ b/src/ILLink.CodeFix/RequiresDynamicCodeCodeFixProvider.cs @@ -18,7 +18,7 @@ namespace ILLink.CodeFix [ExportCodeFixProvider (LanguageNames.CSharp, Name = nameof (RequiresUnreferencedCodeCodeFixProvider)), Shared] public class RequiresDynamicCodeCodeFixProvider : BaseAttributeCodeFixProvider { - public ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create (DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.RequiresDynamicCode)); + public static ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create (DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.RequiresDynamicCode)); public sealed override ImmutableArray<string> FixableDiagnosticIds => SupportedDiagnostics.Select (dd => dd.Id).ToImmutableArray (); diff --git a/src/ILLink.CodeFix/RequiresUnreferencedCodeCodeFixProvider.cs b/src/ILLink.CodeFix/RequiresUnreferencedCodeCodeFixProvider.cs index 17bcf0b86..c0a3a011c 100644 --- a/src/ILLink.CodeFix/RequiresUnreferencedCodeCodeFixProvider.cs +++ b/src/ILLink.CodeFix/RequiresUnreferencedCodeCodeFixProvider.cs @@ -18,7 +18,7 @@ namespace ILLink.CodeFix [ExportCodeFixProvider (LanguageNames.CSharp, Name = nameof (RequiresUnreferencedCodeCodeFixProvider)), Shared] public class RequiresUnreferencedCodeCodeFixProvider : BaseAttributeCodeFixProvider { - public ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create (DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.RequiresUnreferencedCode)); + public static ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics => ImmutableArray.Create (DiagnosticDescriptors.GetDiagnosticDescriptor (DiagnosticId.RequiresUnreferencedCode)); public sealed override ImmutableArray<string> FixableDiagnosticIds => SupportedDiagnostics.Select (dd => dd.Id).ToImmutableArray (); diff --git a/test/ILLink.RoslynAnalyzer.Tests.Generator/TestCaseGenerator.cs b/test/ILLink.RoslynAnalyzer.Tests.Generator/TestCaseGenerator.cs index 8e6ca566b..6f87e4516 100644 --- a/test/ILLink.RoslynAnalyzer.Tests.Generator/TestCaseGenerator.cs +++ b/test/ILLink.RoslynAnalyzer.Tests.Generator/TestCaseGenerator.cs @@ -7,7 +7,7 @@ using Microsoft.CodeAnalysis.CSharp.Syntax; namespace ILLink.RoslynAnalyzer.Tests { - public readonly struct TestCases + class TestCases { // Maps from suite name to a set of testcase names. // Suite name is: @@ -178,7 +178,7 @@ namespace {TestNamespace}{suiteNamespacePart} class ExistingTestCaseDiscoverer : ISyntaxContextReceiver { - public readonly TestCases ExistingTestCases = new (); + public readonly TestCases ExistingTestCases = new TestCases (); public void OnVisitSyntaxNode (GeneratorSyntaxContext context) { diff --git a/test/ILLink.RoslynAnalyzer.Tests/generated/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.TestCaseGenerator/DataFlowTests.g.cs b/test/ILLink.RoslynAnalyzer.Tests/generated/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.TestCaseGenerator/DataFlowTests.g.cs index 2b4129600..f2024c4ab 100644 --- a/test/ILLink.RoslynAnalyzer.Tests/generated/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.TestCaseGenerator/DataFlowTests.g.cs +++ b/test/ILLink.RoslynAnalyzer.Tests/generated/ILLink.RoslynAnalyzer.Tests.Generator/ILLink.RoslynAnalyzer.Tests.TestCaseGenerator/DataFlowTests.g.cs @@ -8,13 +8,7 @@ namespace ILLink.RoslynAnalyzer.Tests { [Fact] - public Task MethodByRefParameterDataFlow () - { - return RunTest (allowMissingWarnings: true); - } - - [Fact] - public Task MethodByRefReturnDataFlow () + public Task MethodOutParameterDataFlow () { return RunTest (allowMissingWarnings: true); } |