diff options
author | Zoltan Varga <vargaz@gmail.com> | 2017-03-02 02:05:51 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2017-03-02 02:05:51 +0300 |
commit | 4d7109cceb3d5d5f7abdea9448a7f71abd60c825 (patch) | |
tree | 599138c48eb65d9f188f439a45e50cb33bab3d54 | |
parent | f6b11e22138c9172e2b1a3fd381832a2aa556d29 (diff) |
[runtime] Use mono_debug_method_lookup_location () instead of mono_debug_symfile_lookup_location (), the latter doesn't support portable pdb files. Use mono_debug_free_source_location () for freeing. Fixes #52899. (#4457)
-rw-r--r-- | mono/metadata/profiler.c | 2 | ||||
-rw-r--r-- | mono/mini/aot-compiler.c | 6 | ||||
-rw-r--r-- | mono/mini/debug-mini.c | 2 | ||||
-rw-r--r-- | mono/mini/dwarfwriter.c | 11 | ||||
-rw-r--r-- | mono/mini/mini-llvm.c | 4 |
5 files changed, 12 insertions, 13 deletions
diff --git a/mono/metadata/profiler.c b/mono/metadata/profiler.c index a880ec93300..5902d17378a 100644 --- a/mono/metadata/profiler.c +++ b/mono/metadata/profiler.c @@ -1147,7 +1147,7 @@ mono_profiler_coverage_get (MonoProfiler *prof, MonoMethod *method, MonoProfileC if (debug_minfo) { MonoDebugSourceLocation *location; - location = mono_debug_symfile_lookup_location (debug_minfo, offset); + location = mono_debug_method_lookup_location (debug_minfo, offset); if (location) { entry.line = location->row; entry.col = location->column; diff --git a/mono/mini/aot-compiler.c b/mono/mini/aot-compiler.c index 6d4f50a4238..947e4e33d6f 100644 --- a/mono/mini/aot-compiler.c +++ b/mono/mini/aot-compiler.c @@ -5246,11 +5246,11 @@ compute_line_numbers (MonoMethod *method, int code_size, MonoDebugMethodJitInfo if (il_offset == -1 || il_offset == prev_il_offset) continue; prev_il_offset = il_offset; - loc = mono_debug_symfile_lookup_location (minfo, il_offset); + loc = mono_debug_method_lookup_location (minfo, il_offset); if (!(loc && loc->source_file)) continue; if (loc->row == prev_line) { - mono_debug_symfile_free_location (loc); + mono_debug_free_source_location (loc); continue; } prev_line = loc->row; @@ -5349,7 +5349,7 @@ emit_and_reloc_code (MonoAotCompile *acfg, MonoMethod *method, guint8 *code, gui options = ""; prologue_end = TRUE; fprintf (acfg->fp, ".loc %d %d 0%s\n", findex, loc->row, options); - mono_debug_symfile_free_location (loc); + mono_debug_free_source_location (loc); } skip = FALSE; diff --git a/mono/mini/debug-mini.c b/mono/mini/debug-mini.c index 41e241a33a8..68780e5056a 100644 --- a/mono/mini/debug-mini.c +++ b/mono/mini/debug-mini.c @@ -152,7 +152,7 @@ mono_debug_add_vg_method (MonoMethod *method, MonoDebugMethodJitInfo *jit) for (i = 0; i < header->code_size; ++i) { MonoDebugSourceLocation *location; - location = mono_debug_symfile_lookup_location (minfo, i); + location = mono_debug_method_lookup_location (minfo, i); if (!location) continue; diff --git a/mono/mini/dwarfwriter.c b/mono/mini/dwarfwriter.c index 40960cc4b84..5aacab1c440 100644 --- a/mono/mini/dwarfwriter.c +++ b/mono/mini/dwarfwriter.c @@ -21,7 +21,6 @@ #endif #include <mono/metadata/mono-endian.h> -#include <mono/metadata/debug-mono-symfile.h> #include <mono/metadata/mono-debug-debugger.h> #ifndef HOST_WIN32 @@ -1581,11 +1580,11 @@ emit_line_number_info (MonoDwarfWriter *w, MonoMethod *method, prev_il_offset = il_offset; - loc = mono_debug_symfile_lookup_location (minfo, il_offset); + loc = mono_debug_method_lookup_location (minfo, il_offset); if (!loc) continue; if (!loc->source_file) { - mono_debug_symfile_free_location (loc); + mono_debug_free_source_location (loc); continue; } @@ -1633,7 +1632,7 @@ emit_line_number_info (MonoDwarfWriter *w, MonoMethod *method, prev_native_offset = i; } - mono_debug_symfile_free_location (loc); + mono_debug_free_source_location (loc); first = FALSE; } @@ -1797,7 +1796,7 @@ mono_dwarf_writer_emit_method (MonoDwarfWriter *w, MonoCompile *cfg, MonoMethod minfo = mono_debug_lookup_method (method); if (minfo) - loc = mono_debug_symfile_lookup_location (minfo, 0); + loc = mono_debug_method_lookup_location (minfo, 0); /* Subprogram */ names = g_new0 (char *, sig->param_count); @@ -1818,7 +1817,7 @@ mono_dwarf_writer_emit_method (MonoDwarfWriter *w, MonoCompile *cfg, MonoMethod emit_uleb128 (w, file_index + 1); emit_uleb128 (w, loc->row); - mono_debug_symfile_free_location (loc); + mono_debug_free_source_location (loc); loc = NULL; } else { emit_uleb128 (w, 0); diff --git a/mono/mini/mini-llvm.c b/mono/mini/mini-llvm.c index 745c29f13e4..46ddd5085bb 100644 --- a/mono/mini/mini-llvm.c +++ b/mono/mini/mini-llvm.c @@ -9116,7 +9116,7 @@ emit_dbg_loc (EmitContext *ctx, LLVMBuilderRef builder, const unsigned char *cil MonoDebugSourceLocation *loc; LLVMValueRef loc_md; - loc = mono_debug_symfile_lookup_location (ctx->minfo, cil_code - cfg->header->code); + loc = mono_debug_method_lookup_location (ctx->minfo, cil_code - cfg->header->code); if (loc) { #if LLVM_API_VERSION > 100 @@ -9134,7 +9134,7 @@ emit_dbg_loc (EmitContext *ctx, LLVMBuilderRef builder, const unsigned char *cil loc_md = LLVMMDNode (md_args, nmd_args); LLVMSetCurrentDebugLocation (builder, loc_md); #endif - mono_debug_symfile_free_location (loc); + mono_debug_free_source_location (loc); } } } |