[wasm][xunit tests] Avoid skipping test methods with ITraitAttribute custom attributes (#18223)

* [wasm][xunit tests] Avoid skipping test methods with ITraitAttribute custom attributes

* [wasm][xunit tests] Re-enable System.Tests.MathFTests.Round_Digits and System.Tests.MathFTests.Truncate

* [wasm][xunit tests] Exclude XLinqTests.TreeManipulationTests.IEnumerableOfXNodeRemoveWithEvents test method

3 files changed, 82 insertions, 18 deletions

diff --git a/external/corefx b/external/corefx
-Subproject 9724859cec205954206171961739ee7df8740dd
+Subproject e610bc82cd25f141b1981b1f2e1bd1e7ce87308
diff --git a/sdks/wasm/xunit-exclusions.rsp b/sdks/wasm/xunit-exclusions.rsp
index 55d9e1a902a..566c00e6a7a 100644
--- a/sdks/wasm/xunit-exclusions.rsp
+++ b/sdks/wasm/xunit-exclusions.rsp
@@ -22,10 +22,6 @@
 -nomethod System.Linq.Expressions.Tests.CompilerTests.CompileDeepTree_NoStackOverflow
 -nomethod System.Linq.Expressions.Tests.CompilerTests.CompileDeepTree_NoStackOverflowFast
 
-# OOM
--nomethod System.Collections.Tests.BitArray_CtorTests.Ctor_LargeByteArrayOverflowingBitArray_ThrowsArgumentException
--nomethod System.Collections.Tests.BitArray_CtorTests.Clone_LongLength_Works
-
 # Not supported
 -nonamespace System.IO.Pipes.Tests
 
@@ -33,22 +29,71 @@
 -nomethod System.Buffers.Text.Tests.ParserTests.TestParserDecimal
 -nomethod System.Buffers.Text.Tests.ParserTests.TestParserDouble
 -nomethod System.Buffers.Text.Tests.ParserTests.TestParserSingle
--nomethod System.Collections.Tests.ComparerTests.Default_Compare
--nomethod System.Text.Encodings.Tests.EncodingMiscTests.GetEncodingsTest
--nomethod System.Tests.ValueTupleTests.TestCompareTo
+-nomethod System.Collections.Tests.BitArray_CtorTests.Clone_LongLength_Works
+-nomethod System.Collections.Tests.BitArray_CtorTests.Ctor_LargeByteArrayOverflowingBitArray_ThrowsArgumentException
 -nomethod System.Collections.Tests.CaseInsensitiveComparerTests.Ctor_CultureInfo_Compare_TurkishI
--nomethod System.Collections.Tests.CaseInsensitiveHashCodeProviderTests.Ctor_Empty_GetHashCodeCompare
 -nomethod System.Collections.Tests.CaseInsensitiveHashCodeProviderTests.Ctor_CultureInfo_ChangeCurrentCulture_GetHashCodeCompare
 -nomethod System.Collections.Tests.CaseInsensitiveHashCodeProviderTests.Ctor_CultureInfo_GetHashCodeCompare_TurkishI
+-nomethod System.Collections.Tests.CaseInsensitiveHashCodeProviderTests.Ctor_Empty_GetHashCodeCompare
 -nomethod System.Collections.Tests.CaseInsensitiveHashCodeProviderTests.Default_GetHashCodeCompare
--nomethod System.Collections.Tests.HashtableTests.HashCodeProvider_Set_ImpactsSearch
+-nomethod System.Collections.Tests.ComparerTests.Default_Compare
 -nomethod System.Collections.Tests.HashtableTests.Comparer_Set_ImpactsSearch
+-nomethod System.Collections.Tests.HashtableTests.HashCodeProvider_Set_ImpactsSearch
+-nomethod System.Reflection.Tests.GetCustomAttributes_ParameterInfo.GetCustom_Attribute_On_Return_Parameter_On_Parent_Method
+-nomethod System.Reflection.Tests.MethodBaseTests.TestMethodBody
+-nomethod System.Reflection.Tests.ModuleTests.ResolveField
+-nomethod System.Reflection.Tests.ModuleTests.ResolveMethod
+-nomethod System.Runtime.CompilerServices.Tests.RuntimeHelpersTests.PrepareGenericMethod
+-nomethod System.Runtime.CompilerServices.Tests.RuntimeHelpersTests.PrepareMethod
 -nomethod System.SpanTests.ReadOnlySpanTests.Compare
 -nomethod System.SpanTests.ReadOnlySpanTests.IndexOf_AllSubstrings
 -nomethod System.SpanTests.ReadOnlySpanTests.IndexOf_EquivalentDiacritics_EnglishUSCulture
 -nomethod System.SpanTests.ReadOnlySpanTests.IndexOf_EquivalentDiacritics_InvariantCulture
-
-# System.Data
+-nomethod System.SpanTests.ReadOnlySpanTests.ToStringSpanOverFullStringReturnsOriginal
+-nomethod System.Tests.DateTimeOffsetTests.TryParse_TimeDesignators_Netfx
+-nomethod System.Tests.DateTimeTests.TryParse_TimeDesignators_Netfx
+-nomethod System.Tests.EnvironmentNewLine.Windows_NewLineTest
+-nomethod System.Tests.EnvironmentProcessorCount.Windows_ProcessorCountTest
+-nomethod System.Tests.EnvironmentUserName.UserNameIsHardCodedOnUap
+-nomethod System.Tests.EnvironmentUserName.UserName_MatchesEnvironment_Windows
+-nomethod System.Tests.GuidTests.Parse_Invalid_NetcoreApp
+-nomethod System.Tests.GuidTests.Parse_Invalid_Netfx
+-nomethod System.Tests.MathFTests.Atan2_IEEE_Legacy
+-nomethod System.Tests.MathFTests.Pow_IEEE_Legacy
+-nomethod System.Tests.MathTests.Atan2_IEEE_Legacy
+-nomethod System.Tests.MathTests.Pow_IEEE_Legacy
+-nomethod System.Tests.MathTests.Tan_PiOver2_Legacy
+-nomethod System.Tests.TypeTestsExtended.IsContextful
+-nomethod System.Tests.ValueTupleTests.TestCompareTo
+-nomethod System.Text.Encodings.Tests.EncodingMiscTests.DefaultEncodingBOMTest
+-nomethod System.Text.Encodings.Tests.EncodingMiscTests.GetEncodingsTest
+-nomethod System.Text.Tests.EncoderExceptionFallbackTests.CreateFallbackBuffer_Fallback_InvalidSurrogateChars_ThrowsArgumentOutOfRangeException_Desktop
+-nomethod System.Text.Tests.EncoderReplacementFallbackTests.CreateFallbackBuffer_Fallback_InvalidSurrogateChars_ThrowsArgumentOutOfRangeException_Desktop
+-nomethod System.Text.Tests.StringBuilderTests.Append_CharArray_InvalidDesktop
+-nomethod System.Text.Tests.StringBuilderTests.Insert_CharArray_InvalidCharCount_Desktop
+-nomethod System.Text.Tests.StringBuilderTests.Insert_CharArray_InvalidCount_Desktop
+-nomethod System.Text.Tests.StringBuilderTests.Remove_Invalid_Desktop
+
+# System failures
+-nomethod System.Net.Security.Tests.LoggingTest.EventSource_ExistsWithCorrectId
+-nomethod System.Net.Security.Tests.NegotiateStreamStreamToStreamTest_Async.NegotiateStream_StreamToStream_FlushAsync_Propagated
+-nomethod System.Net.Security.Tests.NegotiateStreamStreamToStreamTest_BeginEnd.NegotiateStream_StreamToStream_FlushAsync_Propagated
+-nomethod System.Net.Security.Tests.NegotiateStreamStreamToStreamTest_Sync.NegotiateStream_StreamToStream_FlushAsync_Propagated
+-nomethod System.Net.Security.Tests.SslStreamStreamToStreamTest_Async.SslStream_StreamToStream_FlushAsync_Propagated
+-nomethod System.Net.Security.Tests.SslStreamStreamToStreamTest_BeginEnd.SslStream_StreamToStream_FlushAsync_Propagated
+-nomethod System.Net.Security.Tests.SslStreamStreamToStreamTest_Sync.SslStream_StreamToStream_FlushAsync_Propagated
+-nomethod System.Net.Tests.FtpWebRequestTest.GetResponse_ConnectFailure_ThrowsWebException
+-nomethod System.Security.Cryptography.Encoding.Tests.OidTests.LookupOidByFriendlyName_Method_WrongGroup
+-nomethod System.Security.Cryptography.Encoding.Tests.OidTests.LookupOidByValue_Method_WrongGroup
+
+# System.Core failures
+-nomethod System.Data.SqlClient.Tests.TcpDefaultForAzureTest.AzureNpConnectionTest
+-nomethod System.Data.SqlClient.Tests.TcpDefaultForAzureTest.NonAzureNpConnectionTest
+-nomethod System.Data.Tests.DataTableReadXmlSchemaTest.XsdSchemaDeserializationOnFullFrameworkStillHasBug
+-nomethod System.Linq.Expressions.Tests.Assign.Left_ValueTypeContainsChildTryExpression
+-nomethod System.Linq.Expressions.Tests.Assign.ValueTypeIndexAssign
+
+# System.Data failures
 # Hangs
 -nomethod System.Data.SqlClient.ManualTesting.Tests.BaseProviderAsyncTest.TestDbConnection
 -nomethod System.Data.SqlClient.ManualTesting.Tests.BaseProviderAsyncTest.TestDbCommand
@@ -89,6 +134,25 @@
 -nomethod System.Data.Tests.DataColumnCollectionTest.CaseSensitiveIndexOfTest
 -nomethod System.Data.Tests.DataColumnCollectionTest2.Indexer2
 
+# System.Numerics failures
+-nomethod System.Numerics.Tests.ComparisonTest.IComparable_Invalid_net46
+
+# System.Security failures
+-nomethod System.Security.Cryptography.Pkcs.EnvelopedCmsTests.Tests.StateTests.PostDecode_ContentInfo_net46
+-nomethod System.Security.Cryptography.Pkcs.EnvelopedCmsTests.Tests.StateTests.PostDecode_Encode_net46
+-nomethod System.Security.Cryptography.ProtectedDataTests.ProtectedDataTests.NullEntropyEquivalence
+-nomethod System.Security.Cryptography.ProtectedDataTests.ProtectedDataTests.NullEntropyEquivalence2
+-nomethod System.Security.Cryptography.ProtectedDataTests.ProtectedDataTests.ProtectEmptyData
+-nomethod System.Security.Cryptography.ProtectedDataTests.ProtectedDataTests.ProtectEmptyData
+-nomethod System.Security.Cryptography.ProtectedDataTests.ProtectedDataTests.ProtectEmptyData
+-nomethod System.Security.Cryptography.ProtectedDataTests.ProtectedDataTests.ProtectEmptyData
+-nomethod System.Security.Cryptography.ProtectedDataTests.ProtectedDataTests.RoundTrip
+-nomethod System.Security.Cryptography.ProtectedDataTests.ProtectedDataTests.WrongEntropy
+
+# System.Xml.Linq failures
+-nomethod XLinqTests.TreeManipulationTests.IEnumerableOfXNodeRemove
+-nomethod XLinqTests.TreeManipulationTests.IEnumerableOfXNodeRemoveWithEvents
+
 # System.Net.Tests.WebClientTest
 # WebClient.Proxy throws PlatformNotSupportedException
 -nomethod System.Net.Tests.WebClientTest.DefaultCtor_PropertiesReturnExpectedValues
diff --git a/sdks/wasm/xunit-runner/xunit-runner.cs b/sdks/wasm/xunit-runner/xunit-runner.cs
index 6f0f6d16835..baa00d5c1d3 100644
--- a/sdks/wasm/xunit-runner/xunit-runner.cs
+++ b/sdks/wasm/xunit-runner/xunit-runner.cs
@@ -191,13 +191,13 @@ class WasmRunner : IMessageSink
 				continue;
 			}
 
-			var itrait_attrs = tc.TestMethod.Method.GetCustomAttributes(typeof(ITraitAttribute));
-			// FIXME:
-			if (itrait_attrs.Count () > 0) {
-				Console.WriteLine ("SKIP (ITraitAttribute): " + tc.DisplayName);
-				nfiltered ++;
-				continue;
-			}
+			// var itrait_attrs = tc.TestMethod.Method.GetCustomAttributes(typeof(ITraitAttribute));
+			// // FIXME:
+			// if (itrait_attrs.Count () > 0) {
+			// 	Console.WriteLine ("SKIP (ITraitAttribute): " + tc.DisplayName);
+			// 	nfiltered ++;
+			// 	continue;
+			// }
 			/*
 			foreach (var attr in itrait_attrs) {
 				Console.WriteLine (attr);