diff options
| author | Alexander Köplinger <alex.koeplinger@outlook.com> | 2017-07-15 00:38:31 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-07-15 00:38:31 +0300 |
| commit | 9b4b6d621101fdf06e41b0f76b1ad50b0d1149f2 (patch) | |
| tree | 04435405d6d8ffbac3170a8a1a82e03da747a4f5 /mcs/class/System.DirectoryServices | |
| parent | aa07d1c2d5bd2e70c7139c6ce11ee9f38ca56983 (diff) | |
[bcl] Remove the ValueAdd and InetAccess NUnit categories (#2212)
ValueAdd was added over a decade ago and all the tests marked with this category are passing now.
We have *tons* of tests that rely on working DNS/Internet that aren't marked with
InetAccess (and they actually provide good value so we don't want to exclude them).
Since these categories don't really make sense and just causes confusion
it's better to just remove them.
Diffstat (limited to 'mcs/class/System.DirectoryServices')
3 files changed, 9 insertions, 3 deletions
diff --git a/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesDirectoryEntryTest.cs b/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesDirectoryEntryTest.cs index cecbc7e1fb0..330a8d8a5e7 100644 --- a/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesDirectoryEntryTest.cs +++ b/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesDirectoryEntryTest.cs @@ -13,7 +13,6 @@ using System.DirectoryServices; namespace MonoTests.System.DirectoryServices
{
[TestFixture]
- [Category ("InetAccess")]
public class DirectoryServicesDirectoryEntryTest
{
#region Fields
@@ -30,6 +29,9 @@ namespace MonoTests.System.DirectoryServices {
de = null;
configuration = new TestConfiguration ();
+
+ if (String.IsNullOrEmpty (configuration.ConnectionString))
+ Assert.Ignore ("No configuration");
}
diff --git a/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesDirectorySearcherTest.cs b/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesDirectorySearcherTest.cs index 2775fcb7b4e..95ce2662c54 100644 --- a/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesDirectorySearcherTest.cs +++ b/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesDirectorySearcherTest.cs @@ -15,7 +15,6 @@ using System.Threading; namespace MonoTests.System.DirectoryServices
{
[TestFixture]
- [Category ("InetAccess")]
public class DirectoryServicesDirectorySearcherTest
{
#region Fields
@@ -33,6 +32,9 @@ namespace MonoTests.System.DirectoryServices {
de = null;
configuration = new TestConfiguration ();
+
+ if (String.IsNullOrEmpty (configuration.ConnectionString))
+ Assert.Ignore ("No configuration");
}
diff --git a/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesSearchResultTest.cs b/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesSearchResultTest.cs index 87f69ad7d0f..21aa253301b 100644 --- a/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesSearchResultTest.cs +++ b/mcs/class/System.DirectoryServices/Test/System.DirectoryServices/DirectoryServicesSearchResultTest.cs @@ -13,7 +13,6 @@ using System.DirectoryServices; namespace MonoTests.System.DirectoryServices
{
[TestFixture]
- [Category ("InetAccess")]
public class DirectoryServicesSearchResultTest
{
#region Fields
@@ -31,6 +30,9 @@ namespace MonoTests.System.DirectoryServices {
de = null;
configuration = new TestConfiguration ();
+
+ if (String.IsNullOrEmpty (configuration.ConnectionString))
+ Assert.Ignore ("No configuration");
}
|