diff options
author | Sebastien Pouliot <sebastien@ximian.com> | 2008-01-12 19:58:39 +0300 |
---|---|---|
committer | Sebastien Pouliot <sebastien@ximian.com> | 2008-01-12 19:58:39 +0300 |
commit | 649084c451e0bf996ef5a19c41b1cbd6e31a1443 (patch) | |
tree | d14ac596d88ccc97af0522efb2b6c90991c8c53d /mcs/class/System.Security/System.Security.Cryptography.Xml | |
parent | 999d3d2182f17bd410050c59d810dd5f63610a31 (diff) |
2008-01-12 Sebastien Pouliot <sebastien@ximian.com>
* ReferenceList.cs: Avoid infinite recursion when setting [].
Found by Gendarme.
* XmlDsigXPathTransform.cs: Fix direct comparison with NaN. Found
by Gendarme.
svn path=/trunk/mcs/; revision=92756
Diffstat (limited to 'mcs/class/System.Security/System.Security.Cryptography.Xml')
3 files changed, 9 insertions, 2 deletions
diff --git a/mcs/class/System.Security/System.Security.Cryptography.Xml/ChangeLog b/mcs/class/System.Security/System.Security.Cryptography.Xml/ChangeLog index 71197e063d8..63f39821434 100644 --- a/mcs/class/System.Security/System.Security.Cryptography.Xml/ChangeLog +++ b/mcs/class/System.Security/System.Security.Cryptography.Xml/ChangeLog @@ -1,3 +1,10 @@ +2008-01-12 Sebastien Pouliot <sebastien@ximian.com> + + * ReferenceList.cs: Avoid infinite recursion when setting []. + Found by Gendarme. + * XmlDsigXPathTransform.cs: Fix direct comparison with NaN. Found + by Gendarme. + 2007-11-13 Atsushi Enomoto <atsushi@ximian.com> * XmlDsigExcC14NTransform.cs : removed extra [ComVisible]. diff --git a/mcs/class/System.Security/System.Security.Cryptography.Xml/ReferenceList.cs b/mcs/class/System.Security/System.Security.Cryptography.Xml/ReferenceList.cs index 278f2d1b82c..19dfe2a50a3 100644 --- a/mcs/class/System.Security/System.Security.Cryptography.Xml/ReferenceList.cs +++ b/mcs/class/System.Security/System.Security.Cryptography.Xml/ReferenceList.cs @@ -79,7 +79,7 @@ namespace System.Security.Cryptography.Xml { [IndexerName ("ItemOf")] public EncryptedReference this [int index] { get { return (EncryptedReference) list [index]; } - set { this [index] = value; } + set { list [index] = value; } } public object SyncRoot { diff --git a/mcs/class/System.Security/System.Security.Cryptography.Xml/XmlDsigXPathTransform.cs b/mcs/class/System.Security/System.Security.Cryptography.Xml/XmlDsigXPathTransform.cs index c0652b1f13d..50f7aa6b0d7 100644 --- a/mcs/class/System.Security/System.Security.Cryptography.Xml/XmlDsigXPathTransform.cs +++ b/mcs/class/System.Security/System.Security.Cryptography.Xml/XmlDsigXPathTransform.cs @@ -171,7 +171,7 @@ namespace System.Security.Cryptography.Xml return (bool) ret; if (ret is double) { double d = (double) ret; - return !(d == 0.0 || d == double.NaN); + return !(d == 0.0 || Double.IsNaN (d)); } if (ret is string) return ((string) ret).Length > 0; |