diff options
| author | Stephen Toub <stoub@microsoft.com> | 2019-09-25 17:05:48 +0300 |
|---|---|---|
| committer | Marek Safar <marek.safar@gmail.com> | 2019-09-25 21:13:47 +0300 |
| commit | c256e409c99ddb5b3618e99ba27af83ea38bfe90 (patch) | |
| tree | f511225ae5aba09c07a4101e099adb6380cfa437 /netcore/System.Private.CoreLib/shared/System/Buffer.cs | |
| parent | 39ff579432fc6261469f9f0ce6304ca29a5ef141 (diff) | |
More Corelib cleanup (dotnet/coreclr#26872)
* Remove unnecessary asserts
* Make several classes static
* Use is instead of as+null check
* Use T? instead of Nullable<T>
* more static classes
* Mark locals as const
* Merge declaration and initialization of some variables
* Remove unnecessary casts
* Remove unnecessary "unsafe"s
* Simplify several lambda expressions
* Remove redundant parentheses
* Remove redundant '== true'
* Remove redundant empty lines
* Simplify boolean comparison with '== false'
* Replace if-statement with return statement
* Use while for infinite loop
* Add static to all partial static class declarations
* Use ++/-- operator instead of assignment
* Use string.IsNullOrEmpty
* Use coalesce expression
* Simplify lazy initialization
* Use coalese expression
* Join string expressions
* Use regular string literal instead of verbatim string literal
* Optimize StringBuilder.Append calls
* Remove redundant assignment
* Remove unnecessary unsafe context
* Merge processor directives
* Use String.Equals instead of String.Compare
* Use Debug.Fail instead of Debug.Assert(false
* Remove Attribute suffix
* Use predefined type
* Use compound assignment
* Use while statement to create an infinite loop
* Remove redundant base ctor call
* Avoid using catch (Exception)
* Remove empty regions
* Span comparison to null
* Avoid unnecessary boxing of value type
* Expression is always equal to 'true'
* Remove unused method
* update coalesce assignment
* fix unsafe
* fix redundant parens
* Fix whitespace errors introduced
Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Diffstat (limited to 'netcore/System.Private.CoreLib/shared/System/Buffer.cs')
| -rw-r--r-- | netcore/System.Private.CoreLib/shared/System/Buffer.cs | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/netcore/System.Private.CoreLib/shared/System/Buffer.cs b/netcore/System.Private.CoreLib/shared/System/Buffer.cs index 91f18a79a71..0bde8ac570c 100644 --- a/netcore/System.Private.CoreLib/shared/System/Buffer.cs +++ b/netcore/System.Private.CoreLib/shared/System/Buffer.cs @@ -88,7 +88,7 @@ namespace System // The attributes on this method are chosen for best JIT performance. // Please do not edit unless intentional. - [MethodImplAttribute(MethodImplOptions.AggressiveInlining)] + [MethodImpl(MethodImplOptions.AggressiveInlining)] [CLSCompliant(false)] public static unsafe void MemoryCopy(void* source, void* destination, long destinationSizeInBytes, long sourceBytesToCopy) { @@ -101,7 +101,7 @@ namespace System // The attributes on this method are chosen for best JIT performance. // Please do not edit unless intentional. - [MethodImplAttribute(MethodImplOptions.AggressiveInlining)] + [MethodImpl(MethodImplOptions.AggressiveInlining)] [CLSCompliant(false)] public static unsafe void MemoryCopy(void* source, void* destination, ulong destinationSizeInBytes, ulong sourceBytesToCopy) { @@ -498,7 +498,7 @@ namespace System // Non-inlinable wrapper around the QCall that avoids polluting the fast path // with P/Invoke prolog/epilog. - [MethodImplAttribute(MethodImplOptions.NoInlining)] + [MethodImpl(MethodImplOptions.NoInlining)] private static unsafe void _Memmove(byte* dest, byte* src, nuint len) { __Memmove(dest, src, len); @@ -506,7 +506,7 @@ namespace System // Non-inlinable wrapper around the QCall that avoids polluting the fast path // with P/Invoke prolog/epilog. - [MethodImplAttribute(MethodImplOptions.NoInlining)] + [MethodImpl(MethodImplOptions.NoInlining)] private static unsafe void _Memmove(ref byte dest, ref byte src, nuint len) { fixed (byte* pDest = &dest) |