More corelib cleanup (dotnet/coreclr#26993)

* Make relevant types static (mostly Interop)

* Fix a few stray semicolons

* Remove unnecessary locals

Some can be removed entirely, some can be replaced by discards.

* Remove unnecessary usings

* Move Unix-specific helper method to TimeZoneInfo.Unix.cs

* Remove duplicated code

* Remove duplicative checks

* Remove [ThreadStatic] initialization

These are all the default values and wouldn't be necessary for any static, but inline initialization for [ThreadStatic]s is particularly unuseful (and in non-default cases problematic) because the fields are only set to these values on the initializing thread.

* Fix methods whose return value is never used

* Use string.IsNullOrEmpty

* Remove unnecessary field initialization

All ctors overwrite these values.

* Address PR feedback

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>

1 files changed, 1 insertions, 1 deletions

diff --git a/netcore/System.Private.CoreLib/shared/System/Globalization/GregorianCalendarHelper.cs b/netcore/System.Private.CoreLib/shared/System/Globalization/GregorianCalendarHelper.cs
index c1f8d96ff8c..589a8b662f0 100644
--- a/netcore/System.Private.CoreLib/shared/System/Globalization/GregorianCalendarHelper.cs
+++ b/netcore/System.Private.CoreLib/shared/System/Globalization/GregorianCalendarHelper.cs
@@ -97,7 +97,7 @@ namespace System.Globalization
             0, 31, 60, 91, 121, 152, 182, 213, 244, 274, 305, 335, 366
         };
 
-        internal int m_maxYear = 9999;
+        internal int m_maxYear;
         internal int m_minYear;
         internal Calendar m_Cal;