diff options
author | Ankit Jain <radical@gmail.com> | 2019-02-27 02:41:11 +0300 |
---|---|---|
committer | Alexander Köplinger <alex.koeplinger@outlook.com> | 2019-02-27 02:41:11 +0300 |
commit | f7d053a0d6f7e0e1decb372095821ed9344e4d49 (patch) | |
tree | ebe1a977390b2f65dada89dc00048f25f1959b37 /tools | |
parent | 6a3b12b622c0a80e4f5f662f2a6fe869ecae1e81 (diff) |
nuget-hash-extractor: Improvements to reduce unnecessary diffs on update (#13197)
* [nuget-hash-extractor] Make the order for denied lists deterministic and
.. stable. We were not sorting the list of assemblies with the same
version, causing irrelevant changes in updates.
* Update denied assembly list to fix order
.. to be deterministic. Generated with the updated
nuget-hash-extractor.cs .
* [nuget-hash-extractor] Make the order of assemblies deterministic
The .nupkgs were being processed in arbitrary order, causing unncessary
diffs when updating them which required manual work to check and fix
them.
Diffstat (limited to 'tools')
-rw-r--r-- | tools/nuget-hash-extractor/nuget-hash-extractor.cs | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/tools/nuget-hash-extractor/nuget-hash-extractor.cs b/tools/nuget-hash-extractor/nuget-hash-extractor.cs index 6d17e8095ba..52d97e7fe34 100644 --- a/tools/nuget-hash-extractor/nuget-hash-extractor.cs +++ b/tools/nuget-hash-extractor/nuget-hash-extractor.cs @@ -102,7 +102,8 @@ class Driver { // Sory by assembly name and version var query = ignoredAsmTable.Values .GroupBy (data => data.AssemblyName) - .Select (group => new { AssemblyName = group.Key, NuGets = group.OrderBy (data => data.AssemblyVersion) }); + .OrderBy (group => group.Key) + .Select (group => new { AssemblyName = group.Key, NuGets = group.OrderBy (data => data.AssemblyVersion).ThenBy (data => data.ModuleVersionId) }); foreach (var g in query) { foreach (var data in g.NuGets) { @@ -126,7 +127,7 @@ class Driver { } else { dump_asm = true; } - foreach (var f in Directory.GetFiles (args [0], "*.nupkg")) { + foreach (var f in Directory.GetFiles (args [0], "*.nupkg").OrderBy (nupkg => Path.GetFileName (nupkg))) { DumpNuget (f); } |