diff options
Diffstat (limited to 'mcs/class/referencesource/System.Data.Linq')
27 files changed, 117 insertions, 117 deletions
diff --git a/mcs/class/referencesource/System.Data.Linq/ChangeConflicts.cs b/mcs/class/referencesource/System.Data.Linq/ChangeConflicts.cs index 81533527201..5ce354335c7 100644 --- a/mcs/class/referencesource/System.Data.Linq/ChangeConflicts.cs +++ b/mcs/class/referencesource/System.Data.Linq/ChangeConflicts.cs @@ -279,7 +279,7 @@ namespace System.Data.Linq { private void ResolveDelete() { Debug.Assert(this.IsDeleted); // If the user is attempting to update an entity that no longer exists - // in the database, we first need to [....] the delete into the local cache. + // in the database, we first need to sync the delete into the local cache. if (!trackedObject.IsDeleted) { trackedObject.ConvertToDeleted(); } @@ -287,7 +287,7 @@ namespace System.Data.Linq { // As the object have been deleted, it needs to leave the cache this.Session.Context.Services.RemoveCachedObjectLike(trackedObject.Type, trackedObject.Original); - // Now that our cache is in [....], we accept the changes + // Now that our cache is in sync, we accept the changes this.trackedObject.AcceptChanges(); this.isResolved = true; } diff --git a/mcs/class/referencesource/System.Data.Linq/ChangeDirector.cs b/mcs/class/referencesource/System.Data.Linq/ChangeDirector.cs index 96fc7db3bb7..74f9bf15133 100644 --- a/mcs/class/referencesource/System.Data.Linq/ChangeDirector.cs +++ b/mcs/class/referencesource/System.Data.Linq/ChangeDirector.cs @@ -45,14 +45,14 @@ namespace System.Data.Linq { private enum AutoSyncBehavior { ApplyNewAutoSync, RollbackSavedValues } DataContext context; - [SuppressMessage("Microsoft.MSInternal", "CA908:AvoidTypesThatRequireJitCompilationInPrecompiledAssemblies", Justification="[....]: FxCop bug Dev10:423110 -- List<KeyValuePair<object, object>> is not supposed to be flagged as a violation.")] + [SuppressMessage("Microsoft.MSInternal", "CA908:AvoidTypesThatRequireJitCompilationInPrecompiledAssemblies", Justification="Microsoft: FxCop bug Dev10:423110 -- List<KeyValuePair<object, object>> is not supposed to be flagged as a violation.")] List<KeyValuePair<TrackedObject, object[]>> syncRollbackItems; internal StandardChangeDirector(DataContext context) { this.context = context; } - [SuppressMessage("Microsoft.MSInternal", "CA908:AvoidTypesThatRequireJitCompilationInPrecompiledAssemblies", Justification="[....]: FxCop bug Dev10:423110 -- List<KeyValuePair<object, object>> is not supposed to be flagged as a violation.")] + [SuppressMessage("Microsoft.MSInternal", "CA908:AvoidTypesThatRequireJitCompilationInPrecompiledAssemblies", Justification="Microsoft: FxCop bug Dev10:423110 -- List<KeyValuePair<object, object>> is not supposed to be flagged as a violation.")] private List<KeyValuePair<TrackedObject, object[]>> SyncRollbackItems { get { if (syncRollbackItems == null) { @@ -89,7 +89,7 @@ namespace System.Data.Linq { IEnumerable<object> facts = (IEnumerable<object>)this.context.Provider.Execute(cmd).ReturnValue; object[] syncResults = (object[])facts.FirstOrDefault(); if (syncResults != null) { - // [....] any auto gen or computed members + // sync any auto gen or computed members AutoSyncMembers(syncResults, item, UpdateType.Insert, AutoSyncBehavior.ApplyNewAutoSync); return 1; } @@ -142,7 +142,7 @@ namespace System.Data.Linq { IEnumerable<object> facts = (IEnumerable<object>)this.context.Provider.Execute(cmd).ReturnValue; object[] syncResults = (object[])facts.FirstOrDefault(); if (syncResults != null) { - // [....] any auto gen or computed members + // sync any auto gen or computed members AutoSyncMembers(syncResults, item, UpdateType.Update, AutoSyncBehavior.ApplyNewAutoSync); return 1; } @@ -204,7 +204,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.MSInternal", "CA908:AvoidTypesThatRequireJitCompilationInPrecompiledAssemblies", Justification="[....]: FxCop bug Dev10:423110 -- List<KeyValuePair<object, object>> is not supposed to be flagged as a violation.")] + [SuppressMessage("Microsoft.MSInternal", "CA908:AvoidTypesThatRequireJitCompilationInPrecompiledAssemblies", Justification="Microsoft: FxCop bug Dev10:423110 -- List<KeyValuePair<object, object>> is not supposed to be flagged as a violation.")] internal override void RollbackAutoSync() { // Rolls back any AutoSync values that may have been set already // Those values are no longer valid since the transaction will be rolled back on the server @@ -222,7 +222,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.MSInternal", "CA908:AvoidTypesThatRequireJitCompilationInPrecompiledAssemblies", Justification="[....]: FxCop bug Dev10:423110 -- List<KeyValuePair<object, object>> is not supposed to be flagged as a violation.")] + [SuppressMessage("Microsoft.MSInternal", "CA908:AvoidTypesThatRequireJitCompilationInPrecompiledAssemblies", Justification="Microsoft: FxCop bug Dev10:423110 -- List<KeyValuePair<object, object>> is not supposed to be flagged as a violation.")] internal override void ClearAutoSyncRollback() { this.syncRollbackItems = null; } @@ -260,7 +260,7 @@ namespace System.Data.Linq { private static List<MetaDataMember> GetAutoSyncMembers(MetaType metaType, UpdateType updateType) { List<MetaDataMember> membersToSync = new List<MetaDataMember>(); foreach (MetaDataMember metaMember in metaType.PersistentDataMembers.OrderBy(m => m.Ordinal)) { - // add all auto generated members for the specified update type to the auto-[....] list + // add all auto generated members for the specified update type to the auto-sync list if ((updateType == UpdateType.Insert && metaMember.AutoSync == AutoSync.OnInsert) || (updateType == UpdateType.Update && metaMember.AutoSync == AutoSync.OnUpdate) || metaMember.AutoSync == AutoSync.Always) { @@ -272,14 +272,14 @@ namespace System.Data.Linq { /// <summary> /// Synchronize the specified item by copying in data from the specified results. - /// Used to [....] members after successful insert or update, but also used to rollback to previous values if a failure + /// Used to sync members after successful insert or update, but also used to rollback to previous values if a failure /// occurs on other entities in the same SubmitChanges batch. /// </summary> /// <param name="autoSyncBehavior"> - /// If AutoSyncBehavior.ApplyNewAutoSync, the current value of the property is saved before the [....] occurs. This is used for normal synchronization after a successful update/insert. - /// Otherwise, the current value is not saved. This is used for rollback operations when something in the SubmitChanges batch failed, rendering the previously-[....]'d values invalid. + /// If AutoSyncBehavior.ApplyNewAutoSync, the current value of the property is saved before the sync occurs. This is used for normal synchronization after a successful update/insert. + /// Otherwise, the current value is not saved. This is used for rollback operations when something in the SubmitChanges batch failed, rendering the previously-sync'd values invalid. /// </param> - [SuppressMessage("Microsoft.MSInternal", "CA908:AvoidTypesThatRequireJitCompilationInPrecompiledAssemblies", Justification="[....]: FxCop bug Dev10:423110 -- List<KeyValuePair<object, object>> is not supposed to be flagged as a violation.")] + [SuppressMessage("Microsoft.MSInternal", "CA908:AvoidTypesThatRequireJitCompilationInPrecompiledAssemblies", Justification="Microsoft: FxCop bug Dev10:423110 -- List<KeyValuePair<object, object>> is not supposed to be flagged as a violation.")] private void AutoSyncMembers(object[] syncResults, TrackedObject item, UpdateType updateType, AutoSyncBehavior autoSyncBehavior) { System.Diagnostics.Debug.Assert(item != null); System.Diagnostics.Debug.Assert(item.IsNew || item.IsPossiblyModified, "AutoSyncMembers should only be called for new and modified objects."); diff --git a/mcs/class/referencesource/System.Data.Linq/ChangeProcessor.cs b/mcs/class/referencesource/System.Data.Linq/ChangeProcessor.cs index 4eaa79b5a06..0affa3cb60a 100644 --- a/mcs/class/referencesource/System.Data.Linq/ChangeProcessor.cs +++ b/mcs/class/referencesource/System.Data.Linq/ChangeProcessor.cs @@ -115,9 +115,9 @@ namespace System.Data.Linq { // if we have accumulated any failed updates, throw the exception now if (conflicts.Count > 0) { - // First we need to rollback any value that have already been auto-[....]'d, since the values are no longer valid on the server + // First we need to rollback any value that have already been auto-sync'd, since the values are no longer valid on the server changeDirector.RollbackAutoSync(); - // Also rollback any dependent items that were [....]'d, since their parent values may have been rolled back + // Also rollback any dependent items that were sync'd, since their parent values may have been rolled back foreach (TrackedObject syncDependentItem in syncDependentItems) { Debug.Assert(syncDependentItem.IsNew || syncDependentItem.IsPossiblyModified, "SynchDependent data should only be rolled back for new and modified objects."); syncDependentItem.SynchDependentData(); diff --git a/mcs/class/referencesource/System.Data.Linq/ChangeTracker.cs b/mcs/class/referencesource/System.Data.Linq/ChangeTracker.cs index 76d80426bb1..4e850afa9b4 100644 --- a/mcs/class/referencesource/System.Data.Linq/ChangeTracker.cs +++ b/mcs/class/referencesource/System.Data.Linq/ChangeTracker.cs @@ -560,7 +560,7 @@ namespace System.Data.Linq { } } - // Return value indicates whether or not any data was actually [....]'d + // Return value indicates whether or not any data was actually sync'd internal override bool SynchDependentData() { bool valueWasSet = false; diff --git a/mcs/class/referencesource/System.Data.Linq/CompiledQuery.cs b/mcs/class/referencesource/System.Data.Linq/CompiledQuery.cs index 275883b0227..ee789b785f3 100644 --- a/mcs/class/referencesource/System.Data.Linq/CompiledQuery.cs +++ b/mcs/class/referencesource/System.Data.Linq/CompiledQuery.cs @@ -31,7 +31,7 @@ namespace System.Data.Linq { get { return this.query; } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TResult> Compile<TArg0, TResult>(Expression<Func<TArg0, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -44,7 +44,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TResult> Compile<TArg0, TArg1, TResult>(Expression<Func<TArg0, TArg1, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -57,7 +57,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TResult> Compile<TArg0, TArg1, TArg2, TResult>(Expression<Func<TArg0, TArg1, TArg2, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -70,7 +70,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -83,7 +83,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -96,7 +96,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -109,7 +109,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -122,7 +122,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -135,7 +135,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -148,7 +148,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -161,7 +161,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -174,7 +174,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -187,7 +187,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -200,7 +200,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TArg13, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TArg13, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TArg13, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -213,7 +213,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TArg13, TArg14, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TArg13, TArg14, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TArg13, TArg14, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); @@ -226,7 +226,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] public static Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TArg13, TArg14, TArg15, TResult> Compile<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TArg13, TArg14, TArg15, TResult>(Expression<Func<TArg0, TArg1, TArg2, TArg3, TArg4, TArg5, TArg6, TArg7, TArg8, TArg9, TArg10, TArg11, TArg12, TArg13, TArg14, TArg15, TResult>> query) where TArg0 : DataContext { if (query == null) { Error.ArgumentNull("query"); diff --git a/mcs/class/referencesource/System.Data.Linq/DataContext.cs b/mcs/class/referencesource/System.Data.Linq/DataContext.cs index 5d7fb47e71f..822c6ea1bef 100644 --- a/mcs/class/referencesource/System.Data.Linq/DataContext.cs +++ b/mcs/class/referencesource/System.Data.Linq/DataContext.cs @@ -352,7 +352,7 @@ namespace System.Data.Linq { /// <typeparam name="TEntity">The type of the entity objects. In case of a persistent hierarchy /// the entity specified must be the base type of the hierarchy.</typeparam> /// <returns></returns> - [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "[....]: Generic parameters are required for strong-typing of the return type.")] + [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "Microsoft: Generic parameters are required for strong-typing of the return type.")] public Table<TEntity> GetTable<TEntity>() where TEntity : class { CheckDispose(); MetaTable metaTable = this.services.Model.GetTable(typeof(TEntity)); @@ -483,7 +483,7 @@ namespace System.Data.Linq { /// You can override this method to implement common conflict resolution behaviors. /// </summary> /// <param name="failureMode">Determines how SubmitChanges handles conflicts.</param> - [SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes", Justification = "[....]: In the middle of attempting to rollback a transaction, outer transaction is thrown.")] + [SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes", Justification = "Microsoft: In the middle of attempting to rollback a transaction, outer transaction is thrown.")] public virtual void SubmitChanges(ConflictMode failureMode) { CheckDispose(); CheckNotInSubmitChanges(); @@ -718,7 +718,7 @@ namespace System.Data.Linq { /// <param name="query">The query specified in the server's native query language.</param> /// <param name="parameters">The parameter values to use for the query.</param> /// <returns>An IEnumerable sequence of objects.</returns> - [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "[....]: Generic parameters are required for strong-typing of the return type.")] + [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "Microsoft: Generic parameters are required for strong-typing of the return type.")] public IEnumerable<TResult> ExecuteQuery<TResult>(string query, params object[] parameters) { CheckDispose(); if (query == null) { @@ -786,7 +786,7 @@ namespace System.Data.Linq { /// <param name="methodInfo">The reflection MethodInfo for the method to invoke.</param> /// <param name="parameters">The parameters for the method call.</param> /// <returns>The returned query object</returns> - [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "[....]: Generic parameters are required for strong-typing of the return type.")] + [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "Microsoft: Generic parameters are required for strong-typing of the return type.")] internal protected IQueryable<TResult> CreateMethodCallQuery<TResult>(object instance, MethodInfo methodInfo, params object[] parameters) { CheckDispose(); if (instance == null) { @@ -884,7 +884,7 @@ namespace System.Data.Linq { /// <typeparam name="TResult">The element type of the resulting sequence</typeparam> /// <param name="reader">The DbDataReader to translate</param> /// <returns>The translated sequence of objects</returns> - [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "[....]: Generic parameters are required for strong-typing of the return type.")] + [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "Microsoft: Generic parameters are required for strong-typing of the return type.")] public IEnumerable<TResult> Translate<TResult>(DbDataReader reader) { CheckDispose(); return (IEnumerable<TResult>)this.Translate(typeof(TResult), reader); @@ -999,7 +999,7 @@ namespace System.Data.Linq { /// ITable is the common interface for DataContext tables. It can be used as the source /// of a dynamic/runtime-generated query. /// </summary> - [SuppressMessage("Microsoft.Naming", "CA1710:IdentifiersShouldHaveCorrectSuffix", Justification="[....]: Meant to represent a database table which is delayed loaded and doesn't provide collection semantics.")] + [SuppressMessage("Microsoft.Naming", "CA1710:IdentifiersShouldHaveCorrectSuffix", Justification="Microsoft: Meant to represent a database table which is delayed loaded and doesn't provide collection semantics.")] public interface ITable : IQueryable { /// <summary> /// The DataContext containing this Table. @@ -1102,7 +1102,7 @@ namespace System.Data.Linq { /// persisted in the database. Use it as a source of queries and to add/insert and remove/delete entities. /// </summary> /// <typeparam name="TEntity"></typeparam> - [SuppressMessage("Microsoft.Naming", "CA1710:IdentifiersShouldHaveCorrectSuffix", Justification="[....]: Meant to represent a database table which is delayed loaded and doesn't provide collection semantics.")] + [SuppressMessage("Microsoft.Naming", "CA1710:IdentifiersShouldHaveCorrectSuffix", Justification="Microsoft: Meant to represent a database table which is delayed loaded and doesn't provide collection semantics.")] public sealed class Table<TEntity> : IQueryable<TEntity>, IQueryProvider, IEnumerable<TEntity>, IQueryable, IEnumerable, ITable, IListSource, ITable<TEntity> where TEntity : class { DataContext context; @@ -1156,7 +1156,7 @@ namespace System.Data.Linq { return (IQueryable)Activator.CreateInstance(dqType, new object[] { this.context, expression }); } - [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "[....]: Generic parameters are required for strong-typing of the return type.")] + [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "Microsoft: Generic parameters are required for strong-typing of the return type.")] IQueryable<TResult> IQueryProvider.CreateQuery<TResult>(Expression expression) { if (expression == null) { throw Error.ArgumentNull("expression"); @@ -1171,7 +1171,7 @@ namespace System.Data.Linq { return this.context.Provider.Execute(expression).ReturnValue; } - [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "[....]: Generic parameters are required for strong-typing of the return type.")] + [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "Microsoft: Generic parameters are required for strong-typing of the return type.")] TResult IQueryProvider.Execute<TResult>(Expression expression) { return (TResult)this.context.Provider.Execute(expression).ReturnValue; } @@ -1680,7 +1680,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Performance", "CA1815:OverrideEqualsAndOperatorEqualsOnValueTypes", Justification = "[....]: Types are never compared to each other. When comparisons happen it is against the entities that are represented by these constructs.")] + [SuppressMessage("Microsoft.Performance", "CA1815:OverrideEqualsAndOperatorEqualsOnValueTypes", Justification = "Microsoft: Types are never compared to each other. When comparisons happen it is against the entities that are represented by these constructs.")] public struct ModifiedMemberInfo { MemberInfo member; object current; diff --git a/mcs/class/referencesource/System.Data.Linq/DataShape.cs b/mcs/class/referencesource/System.Data.Linq/DataShape.cs index e46bb6ee15c..940b746fa2d 100644 --- a/mcs/class/referencesource/System.Data.Linq/DataShape.cs +++ b/mcs/class/referencesource/System.Data.Linq/DataShape.cs @@ -17,8 +17,8 @@ namespace System.Data.Linq { /// <summary> /// Describe a property that is automatically loaded when the containing instance is loaded /// </summary> - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] - [SuppressMessage("Microsoft.Design", "CA1011:ConsiderPassingBaseTypesAsParameters", Justification = "[....]: Need to provide static typing.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1011:ConsiderPassingBaseTypesAsParameters", Justification = "Microsoft: Need to provide static typing.")] public void LoadWith<T>(Expression<Func<T, object>> expression) { if (expression == null) { throw Error.ArgumentNull("expression"); @@ -41,8 +41,8 @@ namespace System.Data.Linq { /// <summary> /// Place a subquery on the given association. /// </summary> - [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "[....]: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] - [SuppressMessage("Microsoft.Design", "CA1011:ConsiderPassingBaseTypesAsParameters", Justification = "[....]: Need to provide static typing.")] + [SuppressMessage("Microsoft.Design", "CA1006:DoNotNestGenericTypesInMemberSignatures", Justification = "Microsoft: Generic types are an important part of Linq APIs and they could not exist without nested generic support.")] + [SuppressMessage("Microsoft.Design", "CA1011:ConsiderPassingBaseTypesAsParameters", Justification = "Microsoft: Need to provide static typing.")] public void AssociateWith<T>(Expression<Func<T, object>> expression) { if (expression == null) { throw Error.ArgumentNull("expression"); @@ -234,7 +234,7 @@ namespace System.Data.Linq { } edges = newEdges; } - throw new InvalidOperationException("Bug in ValidateTypeGraphAcyclic"); // Getting here means a bug. + throw new InvalidOperationException("Bug in ValidateTypeGraphAcyclic"); // Getting here means a } private static Type GetIncludeTarget(MemberInfo mi) { diff --git a/mcs/class/referencesource/System.Data.Linq/DbConvert.cs b/mcs/class/referencesource/System.Data.Linq/DbConvert.cs index 03af1adc404..7d21b20de9b 100644 --- a/mcs/class/referencesource/System.Data.Linq/DbConvert.cs +++ b/mcs/class/referencesource/System.Data.Linq/DbConvert.cs @@ -15,12 +15,12 @@ namespace System.Data.Linq { public static class DBConvert { private static Type[] StringArg = new Type[] { typeof(string) }; - [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "[....]: Generic parameters are required for strong-typing of the return type.")] + [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "Microsoft: Generic parameters are required for strong-typing of the return type.")] public static T ChangeType<T>(object value) { return (T)ChangeType(value, typeof(T)); } - [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] + [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] public static object ChangeType(object value, Type type) { if (value == null) diff --git a/mcs/class/referencesource/System.Data.Linq/FunctionResults.cs b/mcs/class/referencesource/System.Data.Linq/FunctionResults.cs index 2a8050fb295..3deee1bf5c3 100644 --- a/mcs/class/referencesource/System.Data.Linq/FunctionResults.cs +++ b/mcs/class/referencesource/System.Data.Linq/FunctionResults.cs @@ -35,7 +35,7 @@ namespace System.Data.Linq { /// <summary> /// An interface for representing the result of a mapped function with a single return sequence. /// </summary> - [SuppressMessage("Microsoft.Naming", "CA1710:IdentifiersShouldHaveCorrectSuffix", Justification="[....]: Meant to represent a database table which is delayed loaded and doesn't provide collection semantics.")] + [SuppressMessage("Microsoft.Naming", "CA1710:IdentifiersShouldHaveCorrectSuffix", Justification="tadam: Meant to represent a database table which is delayed loaded and doesn't provide collection semantics.")] public interface ISingleResult<T> : IEnumerable<T>, IFunctionResult, IDisposable { } /// <summary> @@ -47,7 +47,7 @@ namespace System.Data.Linq { /// </summary> /// <typeparam name="TElement"></typeparam> /// <returns></returns> - [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "[....]: Generic parameters are required for strong-typing of the return type.")] + [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "tadam: Generic parameters are required for strong-typing of the return type.")] IEnumerable<TElement> GetResult<TElement>(); } -} +}
\ No newline at end of file diff --git a/mcs/class/referencesource/System.Data.Linq/IdentityManager.cs b/mcs/class/referencesource/System.Data.Linq/IdentityManager.cs index 414c1934337..dbc4eae8f3d 100644 --- a/mcs/class/referencesource/System.Data.Linq/IdentityManager.cs +++ b/mcs/class/referencesource/System.Data.Linq/IdentityManager.cs @@ -97,8 +97,8 @@ namespace System.Data.Linq { #region Nested type definitions // These types are internal rather than private to work around - // CLR bug #117419 related to type visibility under partial trust - // in nested class scenarios. + // CLR + internal abstract class KeyManager { internal abstract Type KeyType { get; } diff --git a/mcs/class/referencesource/System.Data.Linq/Mapping/MetaModel.cs b/mcs/class/referencesource/System.Data.Linq/Mapping/MetaModel.cs index d07e222bafd..68b69b3defc 100644 --- a/mcs/class/referencesource/System.Data.Linq/Mapping/MetaModel.cs +++ b/mcs/class/referencesource/System.Data.Linq/Mapping/MetaModel.cs @@ -501,7 +501,7 @@ namespace System.Data.Linq.Mapping { /// </summary> /// <param name="instance">The instance to set the value into.</param> /// <param name="value">The value to set.</param> - [SuppressMessage("Microsoft.Design", "CA1007:UseGenericsWhereAppropriate", Justification="[....]: Needs to handle classes and structs.")] + [SuppressMessage("Microsoft.Design", "CA1007:UseGenericsWhereAppropriate", Justification="Microsoft: Needs to handle classes and structs.")] [SuppressMessage("Microsoft.Design", "CA1045:DoNotPassTypesByReference", Justification="Unknown reason.")] public abstract void SetBoxedValue(ref object instance, object value); /// <summary> diff --git a/mcs/class/referencesource/System.Data.Linq/Provider/IProvider.cs b/mcs/class/referencesource/System.Data.Linq/Provider/IProvider.cs index 56eccaa93be..98438415b0c 100644 --- a/mcs/class/referencesource/System.Data.Linq/Provider/IProvider.cs +++ b/mcs/class/referencesource/System.Data.Linq/Provider/IProvider.cs @@ -140,8 +140,8 @@ namespace System.Data.Linq.Provider { /// <param name="item"></param> /// <param name="resultSelector"></param> /// <returns></returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "[....]: The method is being used to represent a method signature")] - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "resultSelector", Justification = "[....]: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "Microsoft: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "resultSelector", Justification = "Microsoft: The method is being used to represent a method signature")] public static TResult Insert<TEntity, TResult>(TEntity item, Func<TEntity, TResult> resultSelector) { throw new NotImplementedException(); } @@ -152,7 +152,7 @@ namespace System.Data.Linq.Provider { /// <typeparam name="TEntity"></typeparam> /// <param name="item"></param> /// <returns></returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "[....]: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "Microsoft: The method is being used to represent a method signature")] public static int Insert<TEntity>(TEntity item) { throw new NotImplementedException(); } @@ -166,9 +166,9 @@ namespace System.Data.Linq.Provider { /// <param name="check"></param> /// <param name="resultSelector"></param> /// <returns></returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "[....]: The method is being used to represent a method signature")] - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "check", Justification = "[....]: The method is being used to represent a method signature")] - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "resultSelector", Justification = "[....]: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "Microsoft: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "check", Justification = "Microsoft: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "resultSelector", Justification = "Microsoft: The method is being used to represent a method signature")] public static TResult Update<TEntity, TResult>(TEntity item, Func<TEntity, bool> check, Func<TEntity, TResult> resultSelector) { throw new NotImplementedException(); } @@ -181,8 +181,8 @@ namespace System.Data.Linq.Provider { /// <param name="item"></param> /// <param name="resultSelector"></param> /// <returns></returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "[....]: The method is being used to represent a method signature")] - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "resultSelector", Justification = "[....]: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "Microsoft: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "resultSelector", Justification = "Microsoft: The method is being used to represent a method signature")] public static TResult Update<TEntity, TResult>(TEntity item, Func<TEntity, TResult> resultSelector) { throw new NotImplementedException(); } @@ -194,8 +194,8 @@ namespace System.Data.Linq.Provider { /// <param name="item"></param> /// <param name="check"></param> /// <returns></returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "[....]: The method is being used to represent a method signature")] - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "check", Justification = "[....]: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "Microsoft: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "check", Justification = "Microsoft: The method is being used to represent a method signature")] public static int Update<TEntity>(TEntity item, Func<TEntity, bool> check) { throw new NotImplementedException(); } @@ -206,7 +206,7 @@ namespace System.Data.Linq.Provider { /// <typeparam name="TEntity"></typeparam> /// <param name="item"></param> /// <returns></returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "[....]: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "Microsoft: The method is being used to represent a method signature")] public static int Update<TEntity>(TEntity item) { throw new NotImplementedException(); } @@ -218,8 +218,8 @@ namespace System.Data.Linq.Provider { /// <param name="item"></param> /// <param name="check"></param> /// <returns></returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "[....]: The method is being used to represent a method signature")] - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "check", Justification = "[....]: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "Microsoft: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "check", Justification = "Microsoft: The method is being used to represent a method signature")] public static int Delete<TEntity>(TEntity item, Func<TEntity, bool> check) { throw new NotImplementedException(); } @@ -230,7 +230,7 @@ namespace System.Data.Linq.Provider { /// <typeparam name="TEntity"></typeparam> /// <param name="item"></param> /// <returns></returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "[....]: The method is being used to represent a method signature")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "item", Justification = "Microsoft: The method is being used to represent a method signature")] public static int Delete<TEntity>(TEntity item) { throw new NotImplementedException(); } diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/Common/SqlVisitor.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/Common/SqlVisitor.cs index 9f35835e429..87d874585ce 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/Common/SqlVisitor.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/Common/SqlVisitor.cs @@ -9,7 +9,7 @@ namespace System.Data.Linq.SqlClient { int nDepth; // Visit a SqlNode - [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification="[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] + [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification="Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] [SuppressMessage("Microsoft.Maintainability", "CA1506:AvoidExcessiveClassCoupling", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] internal virtual SqlNode Visit(SqlNode node) { diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/Funcletizer.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/Funcletizer.cs index 57d09b761ad..50ccc2c6d09 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/Funcletizer.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/Funcletizer.cs @@ -142,7 +142,7 @@ namespace System.Data.Linq.SqlClient { } [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] - [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] + [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] internal virtual Expression Visit(Expression exp) { if (exp == null) return exp; diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/QueryConverter.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/QueryConverter.cs index 55ae51ee957..a9135481d56 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/QueryConverter.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/QueryConverter.cs @@ -143,7 +143,7 @@ namespace System.Data.Linq.SqlClient { return result; } - [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] + [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] private SqlNode VisitInner(Expression node) { if (node == null) return null; diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlBinder.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlBinder.cs index 26645270af2..6d5c6e6156b 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlBinder.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlBinder.cs @@ -1266,7 +1266,7 @@ namespace System.Data.Linq.SqlClient { throw Error.UnexpectedNode(node.NodeType); } - [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] + [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] [SuppressMessage("Microsoft.Maintainability", "CA1506:AvoidExcessiveClassCoupling", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] internal SqlExpression ConvertToFetchedExpression(SqlNode node) { diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlComparer.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlComparer.cs index 06a76c701a1..d70c0becbe9 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlComparer.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlComparer.cs @@ -13,7 +13,7 @@ namespace System.Data.Linq.SqlClient { internal SqlComparer() { } - [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] + [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] [SuppressMessage("Microsoft.Maintainability", "CA1506:AvoidExcessiveClassCoupling", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] [SuppressMessage("Microsoft.Maintainability", "CA1505:AvoidUnmaintainableCode", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlDeflator.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlDeflator.cs index b290c007cd7..ed4f0e66eca 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlDeflator.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlDeflator.cs @@ -236,7 +236,7 @@ namespace System.Data.Linq.SqlClient { return select; } - [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification="[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] + [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification="Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] private void CheckJoinCondition(SqlExpression expr) { switch (expr.NodeType) { case SqlNodeType.And: { diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlFlattener.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlFlattener.cs index 9b7d7de01af..9717a97a0cc 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlFlattener.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlFlattener.cs @@ -20,7 +20,7 @@ namespace System.Data.Linq.SqlClient { } class Visitor : SqlVisitor { - [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields", Justification = "[....]: part of our standard visitor pattern")] + [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields", Justification = "Microsoft: part of our standard visitor pattern")] SqlFactory sql; SqlColumnizer columnizer; bool isTopLevel; diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlMethodCallConverter.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlMethodCallConverter.cs index ddbca5a93db..79be6fe37eb 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlMethodCallConverter.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/Query/SqlMethodCallConverter.cs @@ -939,7 +939,7 @@ namespace System.Data.Linq.SqlClient { //Recognized pattern has set return value so return if (returnValue != null) { - // Assert here to verify that actual translation stays in [....] with + // Assert here to verify that actual translation stays in sync with // method support logic Debug.Assert(GetMethodSupport(mc) == MethodSupport.Method); return returnValue; @@ -973,7 +973,7 @@ namespace System.Data.Linq.SqlClient { returnValue = TranslateDateTimeOffsetInstanceMethod(mc); } if (returnValue != null) { - // Assert here to verify that actual translation stays in [....] with + // Assert here to verify that actual translation stays in sync with // method support logic Debug.Assert(GetMethodSupport(mc) == MethodSupport.Method); return returnValue; @@ -2159,7 +2159,7 @@ namespace System.Data.Linq.SqlClient { throw GetMethodSupportException(mc); } - [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "[....]: These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] + [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "Microsoft: These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] internal override SqlNode VisitMember(SqlMember m) { SqlExpression exp = this.VisitExpression(m.Expression); MemberInfo member = m.Member; diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/Reader/ObjectReader.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/Reader/ObjectReader.cs index 2b2b6fd3062..af65ca3c364 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/Reader/ObjectReader.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/Reader/ObjectReader.cs @@ -42,4 +42,4 @@ namespace System.Data.Linq.SqlClient { internal interface ICompiledSubQuery { IExecuteResult Execute(IProvider provider, object[] parentArgs, object[] userArgs); } -} +}
\ No newline at end of file diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/Reader/ObjectReaderCompiler.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/Reader/ObjectReaderCompiler.cs index 44139f927c2..70507c24596 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/Reader/ObjectReaderCompiler.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/Reader/ObjectReaderCompiler.cs @@ -35,18 +35,18 @@ namespace System.Data.Linq.SqlClient { [SuppressMessage("Microsoft.Design", "CA1012:AbstractTypesShouldNotHaveConstructors", Justification = "Unknown reason.")] public abstract class ObjectMaterializer<TDataReader> where TDataReader : DbDataReader { // These are public fields rather than properties for access speed - [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "[....]: This is a public type that is not intended for public use.")] + [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "Microsoft: This is a public type that is not intended for public use.")] public int[] Ordinals; [SuppressMessage("Microsoft.Naming", "CA1704:IdentifiersShouldBeSpelledCorrectly", MessageId = "Globals", Justification = "Spelling is correct.")] - [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "[....]: This is a public type that is not intended for public use.")] + [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "Microsoft: This is a public type that is not intended for public use.")] public object[] Globals; - [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "[....]: This is a public type that is not intended for public use.")] + [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "Microsoft: This is a public type that is not intended for public use.")] public object[] Locals; - [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "[....]: This is a public type that is not intended for public use.")] + [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "Microsoft: This is a public type that is not intended for public use.")] public object[] Arguments; - [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "[....]: This is a public type that is not intended for public use.")] + [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "Microsoft: This is a public type that is not intended for public use.")] public TDataReader DataReader; - [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "[....]: This is a public type that is not intended for public use.")] + [SuppressMessage("Microsoft.Design", "CA1051:DoNotDeclareVisibleInstanceFields", Justification = "Microsoft: This is a public type that is not intended for public use.")] public DbDataReader BufferReader; public ObjectMaterializer() { @@ -57,16 +57,16 @@ namespace System.Data.Linq.SqlClient { public abstract void SendEntityMaterialized(int globalMetaType, object instance); public abstract IEnumerable ExecuteSubQuery(int iSubQuery, object[] args); - [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "[....]: Generic parameters are required for strong-typing of the return type.")] + [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "Microsoft: Generic parameters are required for strong-typing of the return type.")] public abstract IEnumerable<T> GetLinkSource<T>(int globalLink, int localFactory, object[] keyValues); - [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "[....]: Generic parameters are required for strong-typing of the return type.")] + [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "Microsoft: Generic parameters are required for strong-typing of the return type.")] public abstract IEnumerable<T> GetNestedLinkSource<T>(int globalLink, int localFactory, object instance); public abstract bool Read(); public abstract bool CanDeferLoad { get; } [SuppressMessage("Microsoft.Design", "CA1000:DoNotDeclareStaticMembersOnGenericTypes", Justification = "xiaoruda: The method has to be static because it's used in our generated code and there is no instance of the type.")] - [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "[....]: Generic parameters are required for strong-typing of the return type.")] + [SuppressMessage("Microsoft.Design", "CA1004:GenericMethodsShouldProvideTypeParameter", Justification = "Microsoft: Generic parameters are required for strong-typing of the return type.")] public static IEnumerable<TOutput> Convert<TOutput>(IEnumerable source) { foreach (object value in source) { yield return DBConvert.ChangeType<TOutput>(value); @@ -717,7 +717,7 @@ namespace System.Data.Linq.SqlClient { return this.Generate(node, null); } - [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] + [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] [SuppressMessage("Microsoft.Maintainability", "CA1502:AvoidExcessiveComplexity", Justification = "These issues are related to our use of if-then and case statements for node types, which adds to the complexity count however when reviewed they are easy to navigate and understand.")] private Type Generate(SqlNode node, LocalBuilder locInstance) { #if DEBUG @@ -2212,7 +2212,7 @@ namespace System.Data.Linq.SqlClient { } } - [SuppressMessage("Microsoft.Performance", "CA1804:RemoveUnusedLocals", Justification = "[....]: The variable tc for which the rule fires is used in both a Debug.Assert and in a switch statement")] + [SuppressMessage("Microsoft.Performance", "CA1804:RemoveUnusedLocals", Justification = "Microsoft: The variable tc for which the rule fires is used in both a Debug.Assert and in a switch statement")] private void GenerateArrayAssign(Type type) { // This method was copied out of the expression compiler codebase. // Since DLINQ doesn't currently consume array indexers most of this @@ -2263,7 +2263,7 @@ namespace System.Data.Linq.SqlClient { } } - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "address", Justification = "[....]: See comments in source. Usage commented out to improve code coverage test")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "address", Justification = "Microsoft: See comments in source. Usage commented out to improve code coverage test")] private Type GenerateArrayAccess(Type type, bool address) { // This method was copied out of the expression compiler codebase. // Since DLINQ doesn't currently consume array indexers most of this @@ -2517,7 +2517,7 @@ namespace System.Data.Linq.SqlClient { get { return this.BufferReader != null; } } - [SuppressMessage("Microsoft.Globalization", "CA1306:SetLocaleForDataTypes", Justification = "[....]: Used only as a buffer and never used for string comparison.")] + [SuppressMessage("Microsoft.Globalization", "CA1306:SetLocaleForDataTypes", Justification = "Microsoft: Used only as a buffer and never used for string comparison.")] internal void Buffer() { if (this.BufferReader == null && (this.hasCurrentRow || !this.hasRead)) { if (this.session.IsBuffered) { @@ -2801,7 +2801,7 @@ namespace System.Data.Linq.SqlClient { get { return this.buffer != null; } } - [SuppressMessage("Microsoft.Globalization", "CA1306:SetLocaleForDataTypes", Justification = "[....]: Used only as a buffer and never used for string comparison.")] + [SuppressMessage("Microsoft.Globalization", "CA1306:SetLocaleForDataTypes", Justification = "Microsoft: Used only as a buffer and never used for string comparison.")] public void Buffer() { if (this.buffer == null) { if (this.currentReader != null && !this.currentReader.IsBuffered) { diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlMethods.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlMethods.cs index e11bca1e8a5..da3696d31d1 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlMethods.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlMethods.cs @@ -562,8 +562,8 @@ namespace System.Data.Linq.SqlClient { /// <param name="match_expression">The string that is to be matched.</param> /// <param name="pattern">The pattern which may involve wildcards %,_,[,],^.</param> /// <returns>true if there is a match.</returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "pattern", Justification = "[....]: Method is a placeholder for a server-side method.")] - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "matchExpression", Justification = "[....]: Method is a placeholder for a server-side method.")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "pattern", Justification = "Microsoft: Method is a placeholder for a server-side method.")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "matchExpression", Justification = "Microsoft: Method is a placeholder for a server-side method.")] public static bool Like(string matchExpression, string pattern) { throw Error.SqlMethodOnlyForSql(MethodInfo.GetCurrentMethod()); } @@ -576,9 +576,9 @@ namespace System.Data.Linq.SqlClient { /// <param name="pattern">The pattern which may involve wildcards %,_,[,],^.</param> /// <param name="escape_character">The escape character to use in front of %,_,[,],^ if they are not used as wildcards.</param> /// <returns>true if there is a match.</returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "pattern", Justification = "[....]: Method is a placeholder for a server-side method.")] - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "matchExpression", Justification = "[....]: Method is a placeholder for a server-side method.")] - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "escapeCharacter", Justification = "[....]: Method is a placeholder for a server-side method.")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "pattern", Justification = "Microsoft: Method is a placeholder for a server-side method.")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "matchExpression", Justification = "Microsoft: Method is a placeholder for a server-side method.")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "escapeCharacter", Justification = "Microsoft: Method is a placeholder for a server-side method.")] public static bool Like(string matchExpression, string pattern, char escapeCharacter) { throw Error.SqlMethodOnlyForSql(MethodInfo.GetCurrentMethod()); } @@ -591,7 +591,7 @@ namespace System.Data.Linq.SqlClient { /// </summary> /// <param name="value">The string to take the length of.</param> /// <returns>length of the string</returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "[....]: Method is a placeholder for a server-side method.")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "Microsoft: Method is a placeholder for a server-side method.")] internal static int RawLength(string value) { throw Error.SqlMethodOnlyForSql(MethodInfo.GetCurrentMethod()); } @@ -602,7 +602,7 @@ namespace System.Data.Linq.SqlClient { /// </summary> /// <param name="value">The byte array to take the length of.</param> /// <returns>length of the array</returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "[....]: Method is a placeholder for a server-side method.")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "Microsoft: Method is a placeholder for a server-side method.")] internal static int RawLength(byte[] value) { throw Error.SqlMethodOnlyForSql(MethodInfo.GetCurrentMethod()); } @@ -613,7 +613,7 @@ namespace System.Data.Linq.SqlClient { /// </summary> /// <param name="value">The Binary value to take the length of.</param> /// <returns>length of the Binary</returns> - [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "[....]: Method is a placeholder for a server-side method.")] + [SuppressMessage("Microsoft.Usage", "CA1801:ReviewUnusedParameters", MessageId = "value", Justification = "Microsoft: Method is a placeholder for a server-side method.")] internal static int RawLength(Binary value) { throw Error.SqlMethodOnlyForSql(MethodInfo.GetCurrentMethod()); } diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlProvider.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlProvider.cs index f3dce0d1cfc..437759cb900 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlProvider.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlProvider.cs @@ -738,7 +738,7 @@ namespace System.Data.Linq.SqlClient { } } - [SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes", Justification="[....]: Code needs to return false regarless of exception.")] + [SuppressMessage("Microsoft.Design", "CA1031:DoNotCatchGeneralExceptionTypes", Justification="Microsoft: Code needs to return false regarless of exception.")] [ResourceExposure(ResourceScope.None)] // Exposure is via other methods that set dbName. [ResourceConsumption(ResourceScope.Machine, ResourceScope.Machine)] // File.Exists method call. bool IProvider.DatabaseExists() { @@ -1779,7 +1779,7 @@ namespace System.Data.Linq.SqlClient { IObjectReaderSession session; int iReturnParameter = -1; object value; - [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields", Justification = "[....]: used in an assert in ReturnValue.set")] + [SuppressMessage("Microsoft.Performance", "CA1823:AvoidUnusedPrivateFields", Justification = "Microsoft: used in an assert in ReturnValue.set")] bool useReturnValue; bool isDisposed; diff --git a/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlTypeSystemProvider.cs b/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlTypeSystemProvider.cs index 06bb4d3af7c..f71e8659778 100644 --- a/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlTypeSystemProvider.cs +++ b/mcs/class/referencesource/System.Data.Linq/SqlClient/SqlTypeSystemProvider.cs @@ -1316,7 +1316,7 @@ namespace System.Data.Linq.SqlClient { } } - [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "[....]: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] + [SuppressMessage("Microsoft.Performance", "CA1800:DoNotCastUnnecessarily", Justification = "Microsoft: Cast is dependent on node type and casts do not happen unecessarily in a single code path.")] internal override ProviderType GetBestType(ProviderType typeA, ProviderType typeB) { // first determine the type precedence SqlType bestType = (SqlType)(typeA.ComparePrecedenceTo(typeB) > 0 ? typeA : typeB); diff --git a/mcs/class/referencesource/System.Data.Linq/Types.cs b/mcs/class/referencesource/System.Data.Linq/Types.cs index c6d89a01061..d132e20d55e 100644 --- a/mcs/class/referencesource/System.Data.Linq/Types.cs +++ b/mcs/class/referencesource/System.Data.Linq/Types.cs @@ -17,7 +17,7 @@ namespace System.Data.Linq { internal static readonly IEnumerable<T> Assigned = (IEnumerable<T>)new T[] { }; } - [SuppressMessage("Microsoft.Performance", "CA1815:OverrideEqualsAndOperatorEqualsOnValueTypes", Justification = "[....]: Types are never compared to each other. When comparisons happen it is against the entities that are represented by these constructs.")] + [SuppressMessage("Microsoft.Performance", "CA1815:OverrideEqualsAndOperatorEqualsOnValueTypes", Justification = "Microsoft: Types are never compared to each other. When comparisons happen it is against the entities that are represented by these constructs.")] public struct Link<T> { T underlyingValue; IEnumerable<T> source; @@ -80,7 +80,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Performance", "CA1815:OverrideEqualsAndOperatorEqualsOnValueTypes", Justification="[....]: Types are never compared to each other. When comparisons happen it is against the entities that are represented by these constructs.")] + [SuppressMessage("Microsoft.Performance", "CA1815:OverrideEqualsAndOperatorEqualsOnValueTypes", Justification="Microsoft: Types are never compared to each other. When comparisons happen it is against the entities that are represented by these constructs.")] public struct EntityRef<TEntity> where TEntity : class { IEnumerable<TEntity> source; @@ -146,7 +146,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Naming", "CA1710:IdentifiersShouldHaveCorrectSuffix", Justification="[....]: Naming chosen to represent a different concept from a collection because it is delayed loaded.")] + [SuppressMessage("Microsoft.Naming", "CA1710:IdentifiersShouldHaveCorrectSuffix", Justification="Microsoft: Naming chosen to represent a different concept from a collection because it is delayed loaded.")] public sealed class EntitySet<TEntity> : IList, IList<TEntity>, IListSource where TEntity : class { IEnumerable<TEntity> source; @@ -213,7 +213,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", MessageId = "0#", Justification = "[....]: Naming the parameter entity makes it more discoverable because it is clear what type of data should be added to this collection.")] + [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", MessageId = "0#", Justification = "Microsoft: Naming the parameter entity makes it more discoverable because it is clear what type of data should be added to this collection.")] public void Add(TEntity entity) { if (entity == null) { throw Error.ArgumentNull("entity"); @@ -279,7 +279,7 @@ namespace System.Data.Linq { OnListChanged(ListChangedType.Reset, 0); } - [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", MessageId = "0#", Justification = "[....]: Naming the parameter entity makes it more discoverable because it is clear what type of data should be added to this collection.")] + [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", MessageId = "0#", Justification = "Microsoft: Naming the parameter entity makes it more discoverable because it is clear what type of data should be added to this collection.")] public bool Contains(TEntity entity) { return IndexOf(entity) >= 0; } @@ -311,13 +311,13 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", MessageId = "0#", Justification = "[....]: Naming the parameter entity makes it more discoverable because it is clear what type of data should be added to this collection.")] + [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", MessageId = "0#", Justification = "Microsoft: Naming the parameter entity makes it more discoverable because it is clear what type of data should be added to this collection.")] public int IndexOf(TEntity entity) { Load(); return entities.IndexOf(entity); } - [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", MessageId = "1#", Justification = "[....]: Naming the parameter entity makes it more discoverable because it is clear what type of data should be added to this collection.")] + [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", MessageId = "1#", Justification = "Microsoft: Naming the parameter entity makes it more discoverable because it is clear what type of data should be added to this collection.")] public void Insert(int index, TEntity entity) { Load(); if (index < 0 || index > Count) @@ -406,7 +406,7 @@ namespace System.Data.Linq { isModified = true; } - [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", MessageId = "0#", Justification = "[....]: Naming the parameter entity makes it more discoverable because it is clear what type of data should be added to this collection.")] + [SuppressMessage("Microsoft.Naming", "CA1725:ParameterNamesShouldMatchBaseDeclaration", MessageId = "0#", Justification = "Microsoft: Naming the parameter entity makes it more discoverable because it is clear what type of data should be added to this collection.")] public bool Remove(TEntity entity) { if (entity == null || entity == onRemoveEntity) return false; CheckModify(); @@ -758,7 +758,7 @@ namespace System.Data.Linq { } } - [SuppressMessage("Microsoft.Naming", "CA1724:TypeNamesShouldNotMatchNamespaces", Justification = "[....]: The name clearly describes function and the namespace is under a DLinq namespace which will make the distinction clear.")] + [SuppressMessage("Microsoft.Naming", "CA1724:TypeNamesShouldNotMatchNamespaces", Justification = "Microsoft: The name clearly describes function and the namespace is under a DLinq namespace which will make the distinction clear.")] [DataContract] [Serializable] public sealed class Binary : IEquatable<Binary> { diff --git a/mcs/class/referencesource/System.Data.Linq/misc/SecurityUtils.cs b/mcs/class/referencesource/System.Data.Linq/misc/SecurityUtils.cs index 76e02fafbaf..159dedbb6c6 100644 --- a/mcs/class/referencesource/System.Data.Linq/misc/SecurityUtils.cs +++ b/mcs/class/referencesource/System.Data.Linq/misc/SecurityUtils.cs @@ -8,11 +8,11 @@ */ -#if WINFORMS_NAMESPACE +#if Microsoft_NAMESPACE namespace System.Windows.Forms #elif DRAWING_NAMESPACE namespace System.Drawing -#elif WINFORMS_PUBLIC_GRAPHICS_LIBRARY +#elif Microsoft_PUBLIC_GRAPHICS_LIBRARY namespace System.Internal #elif SYSTEM_NAMESPACE namespace System @@ -127,7 +127,7 @@ namespace System.Windows.Forms return Activator.CreateInstance(type, flags, null, args, null); } -#if (!WINFORMS_NAMESPACE) +#if (!Microsoft_NAMESPACE) /// <devdoc> /// This helper method provides safe access to Activator.CreateInstance. |