Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/mono/monodevelop.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorIan Toal <iantoal@microsoft.com>2020-01-22 20:41:17 +0300
committerIan Toal <iantoal@microsoft.com>2020-01-23 20:02:25 +0300
commit3201b485f198a6f62ce0f350a61f9cfb15dc566f (patch)
tree8a3ea888b2d7ecb556d89218296a3ded8bda49bc
parenta73f1918a332453d726693ba795329c4761b9c34 (diff)
PR Feedback
- Fix up formatting - Move from IList to IReadOnlyList where appropriate
-rw-r--r--main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateParameters.cs4
-rw-r--r--main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizard.cs2
-rw-r--r--main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizardPage.cs4
3 files changed, 5 insertions, 5 deletions
diff --git a/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateParameters.cs b/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateParameters.cs
index a2d6e91c3d..01e054e236 100644
--- a/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateParameters.cs
+++ b/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateParameters.cs
@@ -59,7 +59,7 @@ namespace MonoDevelop.DotNetCore.Templating
Name = name;
}
- public static IList<AuthenticationParameter> CreateSupportedParameterList (IReadOnlyDictionary<string, string> parameterChoices)
+ public static IReadOnlyList<AuthenticationParameter> CreateSupportedParameterList (IReadOnlyDictionary<string, string> parameterChoices)
{
return parameterChoices.Where (choice => supportedParameters.Contains (choice.Key))
.Select (parameter => new AuthenticationParameter (parameter.Key))
@@ -69,7 +69,7 @@ namespace MonoDevelop.DotNetCore.Templating
class DotNetCoreProjectTemplateParameters
{
- public static IList<AuthenticationParameter> GetAuthenticationParameters (string templateId)
+ public static IReadOnlyList<AuthenticationParameter> GetAuthenticationParameters (string templateId)
{
if (IdeServices.TemplatingService.GetSolutionTemplate (templateId) is MicrosoftTemplateEngineSolutionTemplate template) {
if (template.IsSupportedParameter (AuthenticationParameter.ParameterName)) {
diff --git a/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizard.cs b/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizard.cs
index 61e94bf0e9..18674cffe0 100644
--- a/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizard.cs
+++ b/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizard.cs
@@ -52,7 +52,7 @@ namespace MonoDevelop.DotNetCore.Templating
internal IList<TargetFramework> TargetFrameworks => targetFrameworks;
- internal IList<AuthenticationParameter> SupportedAuthentications { get; private set; }
+ internal IReadOnlyList<AuthenticationParameter> SupportedAuthentications { get; private set; }
/// <summary>
/// When only .NET Core 2.0 is installed there is only one option in the drop down
diff --git a/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizardPage.cs b/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizardPage.cs
index 04f2bb7bba..aedb1b4e4c 100644
--- a/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizardPage.cs
+++ b/main/src/addins/MonoDevelop.DotNetCore/MonoDevelop.DotNetCore.Templating/DotNetCoreProjectTemplateWizardPage.cs
@@ -43,7 +43,7 @@ namespace MonoDevelop.DotNetCore.Templating
public DotNetCoreProjectTemplateWizardPage (
DotNetCoreProjectTemplateWizard wizard,
List<TargetFramework> targetFrameworks,
- IList<AuthenticationParameter> supportedAuthentications)
+ IReadOnlyList<AuthenticationParameter> supportedAuthentications)
{
this.wizard = wizard;
this.targetFrameworks = targetFrameworks;
@@ -118,7 +118,7 @@ namespace MonoDevelop.DotNetCore.Templating
wizard.Parameters [parameter] = "true";
}
- public IList<AuthenticationParameter> SupportedAuthentications { get; }
+ public IReadOnlyList<AuthenticationParameter> SupportedAuthentications { get; }
int selectedAuthenticationIndex;