diff options
| author | David KarlasĖ <david.karlas@microsoft.com> | 2018-08-10 11:06:07 +0300 |
|---|---|---|
| committer | monojenkins <jo.shields+jenkins@xamarin.com> | 2018-08-13 11:56:22 +0300 |
| commit | 70ae4e50cfd71460a20e2c353603548d34549faf (patch) | |
| tree | 665758e9cf76e53f5cafb297d3ce6b3bfbb636ab /main/src/addins/MonoDevelop.Debugger.VSCodeDebugProtocol | |
| parent | 7a498d377f2d487c9618f666f9b8675d799d93f3 (diff) | |
Fix #644166: [Feedback] Starting debugger hangs when debugging C# unit test using Visual Studio for Mac version 7.5.3 (build 7) on MacOS 10.13.5 Problem was that when sending breakpoints to .NET Core Debugger we used `b.Line` instead of `b.OriginalLine` difference between two appears when runtime debugger(.NET Core) sends back to us adjusted location of breakpoint(if user places breakpoint at invalid line, debugger places to closest position and sends updated line back to IDE). So what was happening was when runtime sent updated line to IDE. IDE sent new line to runtime, but runtime then updated line position to different value and we got stuck in loop of changing line. Now we always send same value, hence problem fixed.
Diffstat (limited to 'main/src/addins/MonoDevelop.Debugger.VSCodeDebugProtocol')
| -rw-r--r-- | main/src/addins/MonoDevelop.Debugger.VSCodeDebugProtocol/MonoDevelop.Debugger.VsCodeDebugProtocol/VSCodeDebuggerSession.cs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/main/src/addins/MonoDevelop.Debugger.VSCodeDebugProtocol/MonoDevelop.Debugger.VsCodeDebugProtocol/VSCodeDebuggerSession.cs b/main/src/addins/MonoDevelop.Debugger.VSCodeDebugProtocol/MonoDevelop.Debugger.VsCodeDebugProtocol/VSCodeDebuggerSession.cs index 145df49004..5d04e4b5bf 100644 --- a/main/src/addins/MonoDevelop.Debugger.VSCodeDebugProtocol/MonoDevelop.Debugger.VsCodeDebugProtocol/VSCodeDebuggerSession.cs +++ b/main/src/addins/MonoDevelop.Debugger.VSCodeDebugProtocol/MonoDevelop.Debugger.VsCodeDebugProtocol/VSCodeDebuggerSession.cs @@ -376,8 +376,8 @@ namespace MonoDevelop.Debugger.VsCodeDebugProtocol protocolClient.SendRequest (new SetBreakpointsRequest ( source, sourceFile.Select (b => new SourceBreakpoint { - Line = b.Line, - Column = b.Column, + Line = b.OriginalLine, + Column = b.OriginalColumn, Condition = b.ConditionExpression //TODO: HitCondition = b.HitCountMode + b.HitCount, wait for .Net Core Debugger }).ToList ()), (obj) => { |