[Ide] Try to prevent bad policy names

Disallow creating and loading policies with empty names.

BXC19194 - Adding new policy shows error
'System.Reflection.TargetInvocationException'.

1 files changed, 4 insertions, 3 deletions

diff --git a/main/src/core/MonoDevelop.Core/MonoDevelop.Projects.Policies/PolicySet.cs b/main/src/core/MonoDevelop.Core/MonoDevelop.Projects.Policies/PolicySet.cs
index abcead1ca2..d8b62e1387 100644
--- a/main/src/core/MonoDevelop.Core/MonoDevelop.Projects.Policies/PolicySet.cs
+++ b/main/src/core/MonoDevelop.Core/MonoDevelop.Projects.Policies/PolicySet.cs
@@ -156,7 +156,7 @@ namespace MonoDevelop.Projects.Policies
 		
 		internal void LoadFromFile (StreamReader reader)
 		{
-			var xr = System.Xml.XmlReader.Create (reader);
+			var xr = XmlReader.Create (reader);
 			LoadFromXml (xr);
 		}
 		
@@ -180,8 +180,9 @@ namespace MonoDevelop.Projects.Policies
 			foreach (ScopedPolicy policyPair in PolicyService.DiffDeserializeXml (reader)) {
 				PolicyKey key = new PolicyKey (policyPair.PolicyType, policyPair.Scope);
 				if (policies.ContainsKey (key))
-					throw new InvalidOperationException ("Cannot add second policy of type '" +  
-					                                     key.ToString () + "' to policy set '" + Id + "'");
+					throw new InvalidOperationException (
+						"Cannot add second policy of type '" + key + "' to policy set '" + Id + "'"
+					);
 				policies[key] = policyPair.Policy;
 			}
 		}