diff options
author | Therzok <teromario@yahoo.com> | 2013-08-20 22:04:05 +0400 |
---|---|---|
committer | Therzok <teromario@yahoo.com> | 2013-08-20 22:04:05 +0400 |
commit | ad904d042602231a6d34b4a23294cfa1c18f7d81 (patch) | |
tree | 7d1b2363c0aaa0dbff64eb1d0e9ab2646c2830f8 /main/src | |
parent | b4aba37c9f6a053fc1ae18b5f681ceaabb100ec3 (diff) |
[Verison Control] Main folder cleanup:
Removed redundant Using directives.
Added StringComparison arguments.
Removed unused private function from Repository.
Made some functions static.
Diffstat (limited to 'main/src')
36 files changed, 26 insertions, 105 deletions
diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/AddRemoveMoveCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/AddRemoveMoveCommand.cs index 621b64c68f..0f8bd62ba0 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/AddRemoveMoveCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/AddRemoveMoveCommand.cs @@ -1,16 +1,5 @@ -using System; using System.Linq; -using System.Collections; -using System.IO; - -using Gtk; - -using MonoDevelop.Projects; -using MonoDevelop.Ide.Gui.Pads; using MonoDevelop.Core; -using MonoDevelop.Components.Commands; - -using MonoDevelop.Components; using MonoDevelop.Ide; namespace MonoDevelop.VersionControl diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/BaseView.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/BaseView.cs index 98c0e63667..1bc06e7618 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/BaseView.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/BaseView.cs @@ -1,15 +1,6 @@ using System;
-using System.Collections;
-using System.IO;
-
-using Gtk;
-
-using MonoDevelop.Core;
-
+using System.IO;
using MonoDevelop.Ide.Gui;
-using MonoDevelop.Ide.Gui.Pads;
-using MonoDevelop.Projects;
-using MonoDevelop.Components.Commands;
namespace MonoDevelop.VersionControl {
diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/BlameCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/BlameCommand.cs index 63f0e3df9c..123abd902f 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/BlameCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/BlameCommand.cs @@ -24,7 +24,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -using System; using System.Linq; using Mono.Addins; using MonoDevelop.Ide; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/ChangeLogWriter.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/ChangeLogWriter.cs index ea3ba611dd..40317e6674 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/ChangeLogWriter.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/ChangeLogWriter.cs @@ -26,9 +26,7 @@ // WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. // -using System; using System.IO; -using System.Text; using System.Collections.Generic; using System.Linq; using MonoDevelop.Projects; @@ -73,7 +71,7 @@ namespace MonoDevelop.VersionControl private string GetRelativeEntryPath (string path) { - if (!path.StartsWith (changelog_path)) { + if (!path.StartsWith (changelog_path, System.StringComparison.Ordinal)) { return null; } diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/ChangeSet.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/ChangeSet.cs index 5e029d941d..5b8cb57212 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/ChangeSet.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/ChangeSet.cs @@ -1,6 +1,4 @@ - using System; -using System.Text; using System.Collections; using System.Collections.Generic; using System.Linq;
@@ -60,7 +58,7 @@ namespace MonoDevelop.VersionControl return GeneratePathComment (basePath.FullPath, items, format, userInfo); } - public string GeneratePathComment (string path, IEnumerable<ChangeSetItem> items, + public static string GeneratePathComment (string path, IEnumerable<ChangeSetItem> items, CommitMessageFormat messageFormat, MonoDevelop.Projects.AuthorInformation userInfo) { ChangeLogWriter writer = new ChangeLogWriter (path, userInfo); @@ -163,7 +161,7 @@ namespace MonoDevelop.VersionControl public string Comment { get { string txt = VersionControlService.GetCommitComment (LocalPath); - return txt != null ? txt : String.Empty; + return txt ?? String.Empty; } set { VersionControlService.SetCommitComment (LocalPath, value, true); } } diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CheckoutCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CheckoutCommand.cs index a0ca98ca78..aa64311652 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CheckoutCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CheckoutCommand.cs @@ -58,14 +58,14 @@ namespace MonoDevelop.VersionControl string[] list = System.IO.Directory.GetFiles(path); foreach (string str in list ) { - if (str.EndsWith(".mds")) { + if (str.EndsWith (".mds", System.StringComparison.Ordinal)) { projectFn = str; break; } } if ( projectFn == null ) { foreach ( string str in list ) { - if (str.EndsWith(".mdp")) { + if (str.EndsWith (".mdp", System.StringComparison.Ordinal)) { projectFn = str; break; } diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Commands.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Commands.cs index 33aa21ca5b..a6f81f02a8 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Commands.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Commands.cs @@ -1,5 +1,4 @@ -using System; using MonoDevelop.Components.Commands; using MonoDevelop.Projects; using MonoDevelop.Ide; @@ -32,7 +31,7 @@ namespace MonoDevelop.VersionControl class SolutionVersionControlCommandHandler: CommandHandler { - VersionControlItemList GetItems () + static VersionControlItemList GetItems () { VersionControlItemList list = new VersionControlItemList (); @@ -74,7 +73,7 @@ namespace MonoDevelop.VersionControl class FileVersionControlCommandHandler: CommandHandler { - protected VersionControlItemList GetItems () + protected static VersionControlItemList GetItems () { VersionControlItemList list = new VersionControlItemList (); VersionControlItem it = GetItem (); @@ -84,7 +83,7 @@ namespace MonoDevelop.VersionControl return list; } - protected VersionControlItem GetItem () + protected static VersionControlItem GetItem () { Document doc = IdeApp.Workbench.ActiveDocument; if (doc == null || !doc.IsFile) diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CommitCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CommitCommand.cs index 63ed33fbd2..52467325cc 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CommitCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CommitCommand.cs @@ -1,7 +1,6 @@ using System; using System.Collections; -using System.Linq; using MonoDevelop.VersionControl.Dialogs; using MonoDevelop.Core; using MonoDevelop.Ide; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CommitMessageFormat.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CommitMessageFormat.cs index d25f880f41..df9a84a60b 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CommitMessageFormat.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CommitMessageFormat.cs @@ -25,7 +25,6 @@ // // -using System; namespace MonoDevelop.VersionControl { diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CreatePatchCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CreatePatchCommand.cs index ae0ca431b4..196bc9ebc6 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CreatePatchCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/CreatePatchCommand.cs @@ -26,7 +26,6 @@ // WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. // -using System; using System.Linq; using System.IO; using System.Collections.Generic; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultBlameViewHandler.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultBlameViewHandler.cs index b287006dd8..7259eb95e4 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultBlameViewHandler.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultBlameViewHandler.cs @@ -24,7 +24,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -using System; using MonoDevelop.Ide; using MonoDevelop.Ide.Gui; using MonoDevelop.VersionControl.Views; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultDiffViewHandler.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultDiffViewHandler.cs index 452b8d0aae..8934440ed1 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultDiffViewHandler.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultDiffViewHandler.cs @@ -24,7 +24,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -using System; using MonoDevelop.Ide; using MonoDevelop.Ide.Gui; using MonoDevelop.VersionControl.Views; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultLogViewHandler.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultLogViewHandler.cs index 139220f537..9537bb7dfa 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultLogViewHandler.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultLogViewHandler.cs @@ -24,8 +24,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -using System; -using MonoDevelop.Ide; using MonoDevelop.Ide.Gui; using MonoDevelop.VersionControl.Views; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultMergeViewHandler.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultMergeViewHandler.cs index 320a7eefa2..d9f4efb223 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultMergeViewHandler.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DefaultMergeViewHandler.cs @@ -24,7 +24,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -using System; using MonoDevelop.Ide; using MonoDevelop.Ide.Gui; using MonoDevelop.VersionControl.Views; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DiffCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DiffCommand.cs index c8ee8907a6..9791860917 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DiffCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/DiffCommand.cs @@ -24,7 +24,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -using System; using System.Linq; using Mono.Addins; using MonoDevelop.Ide; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/FileUpdateEventHandler.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/FileUpdateEventHandler.cs index c7d88ef816..f8c3b7eef8 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/FileUpdateEventHandler.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/FileUpdateEventHandler.cs @@ -1,5 +1,4 @@ -using System;
using System.Linq; using MonoDevelop.Core; using System.Collections.Generic; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IRepositoryEditor.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IRepositoryEditor.cs index d730d00b51..e1ecd5957d 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IRepositoryEditor.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IRepositoryEditor.cs @@ -23,7 +23,6 @@ // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -using System; namespace MonoDevelop.VersionControl { diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IVersionControlViewHandler.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IVersionControlViewHandler.cs index a8d0fff291..da8611f941 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IVersionControlViewHandler.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IVersionControlViewHandler.cs @@ -24,8 +24,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -using System; -using MonoDevelop.Core; using MonoDevelop.VersionControl.Views; using MonoDevelop.Ide.Gui; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IgnoreCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IgnoreCommand.cs index d2dcccc72d..7e7de8ac1b 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IgnoreCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/IgnoreCommand.cs @@ -25,11 +25,9 @@ // THE SOFTWARE.
using MonoDevelop.Components.Commands;
using MonoDevelop.Core;
-using MonoDevelop.VersionControl.Dialogs;
using MonoDevelop.Ide;
using System;
using System.Linq;
-using System.Xml;
namespace MonoDevelop.VersionControl
{
diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/LockCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/LockCommand.cs index b4c0fc7591..66507132e4 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/LockCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/LockCommand.cs @@ -25,10 +25,8 @@ // // -using System; using System.Linq; using MonoDevelop.Core; -using System.IO; namespace MonoDevelop.VersionControl { diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/LogCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/LogCommand.cs index 2071ed50d0..ec00f7670c 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/LogCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/LogCommand.cs @@ -24,7 +24,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -using System; using System.Linq; using Mono.Addins; using MonoDevelop.Ide; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/MergeCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/MergeCommand.cs index 8620465093..43f5d86499 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/MergeCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/MergeCommand.cs @@ -24,7 +24,6 @@ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -using System; using System.Linq; using Mono.Addins; using MonoDevelop.Ide; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Repository.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Repository.cs index 661131d5bf..a29b3c566c 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Repository.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Repository.cs @@ -261,10 +261,6 @@ namespace MonoDevelop.VersionControl HashSet<FilePath> filesInQueryQueue = new HashSet<FilePath> (); HashSet<FilePath> directoriesInQueryQueue = new HashSet<FilePath> (); - void QueueVersionInfoQuery (IEnumerable<FilePath> paths, bool getRemoteStatus) - { - } - void AddQuery (object query) { lock (queryLock) { @@ -691,11 +687,12 @@ namespace MonoDevelop.VersionControl string pathRoot = null; while ((line = sr.ReadLine ()) != null) { - if (pathRoot != null && fileName != null && (line.StartsWith ("+++ " + pathRoot) || line.StartsWith ("--- " + pathRoot))) { + if (pathRoot != null && fileName != null && + (line.StartsWith ("+++ " + pathRoot, StringComparison.Ordinal) || line.StartsWith ("--- " + pathRoot, StringComparison.Ordinal))) { line = line.Substring (0, 4) + line.Substring (4 + pathRoot.Length); content.Append (line).Append ('\n'); } - else if (!line.StartsWith ("Index:")) { + else if (!line.StartsWith ("Index:", StringComparison.Ordinal)) { content.Append (line).Append ('\n'); } else { if (fileName != null) { diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Revision.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Revision.cs index 10cc44f07c..6a3115a69f 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Revision.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Revision.cs @@ -1,6 +1,4 @@ using System; -using System.Collections; -using System.IO; namespace MonoDevelop.VersionControl { diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Task.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Task.cs index 63767b02d8..92aaac31c3 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Task.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/Task.cs @@ -3,7 +3,6 @@ using System.Threading; using Gtk; using MonoDevelop.Core; -using MonoDevelop.Ide; namespace MonoDevelop.VersionControl { diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UnlockCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UnlockCommand.cs index ce533dd99f..599e3d56f0 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UnlockCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UnlockCommand.cs @@ -25,10 +25,8 @@ // // -using System; using System.Linq; using MonoDevelop.Core; -using System.IO; namespace MonoDevelop.VersionControl { diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UpdateCommand.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UpdateCommand.cs index 0d5616573d..6677562bb1 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UpdateCommand.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UpdateCommand.cs @@ -1,15 +1,5 @@ -using System; using System.Linq; -using System.Collections; -using System.IO; - -using Gtk; - -using MonoDevelop.Projects; -using MonoDevelop.Ide.Gui.Pads; using MonoDevelop.Core; -using MonoDevelop.Components.Commands; -using MonoDevelop.Components; namespace MonoDevelop.VersionControl { diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UrlBasedRepositoryEditor.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UrlBasedRepositoryEditor.cs index b31904ddfc..8e8c352aa8 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UrlBasedRepositoryEditor.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/UrlBasedRepositoryEditor.cs @@ -1,6 +1,5 @@ using System; -using MonoDevelop.Ide; using System.Linq; using System.Collections.Generic; @@ -63,7 +62,7 @@ namespace MonoDevelop.VersionControl } else { // The url may have a scheme, but it may be an incomplete or incorrect url. Do the best to select // the correct value in the protocol combo - string prot = repo.SupportedProtocols.FirstOrDefault (p => repo.Url.StartsWith (p + "://")); + string prot = repo.SupportedProtocols.FirstOrDefault (p => repo.Url.StartsWith (p + "://", StringComparison.Ordinal)); if (prot != null) { repositoryServerEntry.Text = string.Empty; repositoryPortSpin.Value = 0; @@ -99,7 +98,7 @@ namespace MonoDevelop.VersionControl void UpdateControls () { - if (repo.Uri != null || repo.SupportedProtocols.Any (p => repositoryUrlEntry.Text.StartsWith (p + "://"))) { + if (repo.Uri != null || repo.SupportedProtocols.Any (p => repositoryUrlEntry.Text.StartsWith (p + "://", StringComparison.Ordinal))) { repositoryPathEntry.Sensitive = true; bool isUrl = Protocol != "file"; repositoryServerEntry.Sensitive = isUrl; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlCommandHandler.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlCommandHandler.cs index d1e6fd3e24..ebf2a95537 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlCommandHandler.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlCommandHandler.cs @@ -25,11 +25,8 @@ // // -using System; using MonoDevelop.Projects; -using MonoDevelop.Components.Commands; using MonoDevelop.Ide.Gui.Components; -using MonoDevelop.Ide.Gui.Pads; using MonoDevelop.Ide.Gui.Pads.ProjectPad; namespace MonoDevelop.VersionControl @@ -68,7 +65,7 @@ namespace MonoDevelop.VersionControl return nodeItems; } - public VersionControlItem CreateItem (object obj, bool projRecurse = true) + public static VersionControlItem CreateItem (object obj, bool projRecurse = true) { string path; bool isDir; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlConfiguration.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlConfiguration.cs index 270a69caba..71507479cb 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlConfiguration.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlConfiguration.cs @@ -1,6 +1,4 @@ -using System; -using System.Collections; using System.Collections.Generic; using MonoDevelop.Core.Serialization; diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlItemList.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlItemList.cs index 379dd70f66..955fa42070 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlItemList.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlItemList.cs @@ -25,8 +25,6 @@ // // -using System; -using MonoDevelop.Projects;
using System.Collections.Generic;
using MonoDevelop.Core;
diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlNodeExtension.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlNodeExtension.cs index 350b88fe13..1c2bd2a11e 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlNodeExtension.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlNodeExtension.cs @@ -1,5 +1,4 @@ using System;
-using System.Linq;
using System.Collections.Generic;
using MonoDevelop.Core;
diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlService.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlService.cs index 0cae52a832..31858e05e6 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlService.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlService.cs @@ -216,7 +216,7 @@ namespace MonoDevelop.VersionControl { lock (commentsLock) { Hashtable doc = GetCommitComments (); - if (comment == null || comment.Length == 0) { + if (String.IsNullOrEmpty (comment)) { if (doc.ContainsKey (file)) { doc.Remove (file); if (save) SaveComments (); @@ -490,7 +490,7 @@ namespace MonoDevelop.VersionControl static void SolutionItemAddFile (string rootPath, HashSet<string> files, string file) { - if (!file.StartsWith (rootPath + Path.DirectorySeparatorChar)) + if (!file.StartsWith (rootPath + Path.DirectorySeparatorChar, StringComparison.Ordinal)) return; if (!File.Exists (file)) return;
diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlSystem.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlSystem.cs index 7f5f3bac9e..aec5dff779 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlSystem.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionControlSystem.cs @@ -1,6 +1,3 @@ -using System; -using System.Collections; -using System.IO;
using MonoDevelop.Core; namespace MonoDevelop.VersionControl diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionInfo.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionInfo.cs index 700aa29e58..86ac1d7bb5 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionInfo.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionInfo.cs @@ -1,7 +1,5 @@ -using System;
using MonoDevelop.Core; -using System.IO; namespace MonoDevelop.VersionControl { @@ -31,17 +29,16 @@ namespace MonoDevelop.VersionControl public bool Equals (VersionInfo obj) { - VersionInfo other = obj as VersionInfo; - if (other == null) + if (obj == null) return false; - return localPath == other.localPath && - repositoryPath == other.repositoryPath && - isDirectory == other.isDirectory && - status == other.status && - revision == other.revision && - remoteStatus == other.remoteStatus && - remoteRevision == other.remoteRevision && - AllowedOperations == other.AllowedOperations; + return localPath == obj.localPath && + repositoryPath == obj.repositoryPath && + isDirectory == obj.isDirectory && + status == obj.status && + revision == obj.revision && + remoteStatus == obj.remoteStatus && + remoteRevision == obj.remoteRevision && + AllowedOperations == obj.AllowedOperations; } internal void Init (Repository repo) diff --git a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionInfoCache.cs b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionInfoCache.cs index 6fdc0ace95..c242c980bf 100644 --- a/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionInfoCache.cs +++ b/main/src/addins/VersionControl/MonoDevelop.VersionControl/MonoDevelop.VersionControl/VersionInfoCache.cs @@ -23,7 +23,6 @@ // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN // THE SOFTWARE. -using System; using MonoDevelop.Core; using System.Collections.Generic; using System.Linq; |