diff options
author | Michael Niedermayer <michaelni@gmx.at> | 2011-04-03 04:47:17 +0400 |
---|---|---|
committer | Michael Niedermayer <michaelni@gmx.at> | 2011-04-03 05:18:20 +0400 |
commit | 71aed40b56af81d46c19620af5c4579703167475 (patch) | |
tree | 01793727c6d2c3a2506c83df63809f42775f9d4f /doc/developer.texi | |
parent | 7d6f61bdd26ec1e09328545983730261d5e7978d (diff) |
patch checklist:git format-patch
Signed-off-by: Michael Niedermayer <michaelni@gmx.at>
Diffstat (limited to 'doc/developer.texi')
-rw-r--r-- | doc/developer.texi | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/doc/developer.texi b/doc/developer.texi index 04cd3310c5..cf805288bf 100644 --- a/doc/developer.texi +++ b/doc/developer.texi @@ -321,7 +321,7 @@ send a reminder by email. Your patch should eventually be dealt with. @item Does fate pass with the patch applied? (make fate) @item - Is the patch a unified diff? + Was the patch generated with git format-patch or send-email? @item Is the patch against latest FFmpeg git master branch? @item @@ -342,9 +342,6 @@ send a reminder by email. Your patch should eventually be dealt with. tools/trasher and the noise bitstream filter. Your decoder or demuxer should not crash or end in a (near) infinite loop when fed damaged data. @item - Is the patch created from the root of the source tree, so it can be - applied with @code{patch -p0}? -@item Does the patch not mix functional and cosmetic changes? @item Did you add tabs or trailing whitespace to the code? Both are forbidden. @@ -379,8 +376,6 @@ send a reminder by email. Your patch should eventually be dealt with. @item Lines with similar content should be aligned vertically when doing so improves readability. -@item - Did you provide a suggestion for a clear commit log message? @end enumerate @section Patch review process |