Add a static assert to guard potentially dangerous code.

As long as the structure is packed on 4 bytes, the shortcut we use is safe.

1 files changed, 2 insertions, 0 deletions

diff --git a/src/Subtitles/VobSubFile.cpp b/src/Subtitles/VobSubFile.cpp
index f1f8e33be..5aea79665 100644
--- a/src/Subtitles/VobSubFile.cpp
+++ b/src/Subtitles/VobSubFile.cpp
@@ -598,6 +598,8 @@ bool CVobSubFile::ReadIdx(CString fn, int& ver)
             }

             m_nLang = (iLang < 0 && size_t(iLang) >= m_langs.size()) ? SIZE_T_ERROR : size_t(iLang);

         } else if (entry == _T("palette")) {

+            // The assert guarantees that the shortcut we use will work as expected

+            static_assert(sizeof(RGBQUAD) == 4, "Packing error");

             if (_stscanf_s(str, _T("%x,%x,%x,%x,%x,%x,%x,%x,%x,%x,%x,%x,%x,%x,%x,%x"),

                            &m_orgpal[0], &m_orgpal[1], &m_orgpal[2], &m_orgpal[3],

                            &m_orgpal[4], &m_orgpal[5], &m_orgpal[6], &m_orgpal[7],