Fix overlay regression that in some cases prevented injection into devices in myCreateDevice(/Ex)

Incorrect checking for element existence in the std::map using the operator[]
caused interfaces to be added to the device map that weren't actually injected
to yet.

To minimize code impact before DX11 branch merge replace correct existence
checks triggering the bug with checks on whether there's a valid handle
(!= NULL) present for that device in the map. This way the default constructed
(and hence NULL) elements caused by the use of the operator[] are harmless.

For the future we'll have to decide whether we accept additional elements for
"simpler" coding or use the "logically cleaner" style of using find and
iterators.

1 files changed, 2 insertions, 2 deletions

diff --git a/overlay/d3d9.cpp b/overlay/d3d9.cpp
index 883b61d22..29a7cf832 100644
--- a/overlay/d3d9.cpp
+++ b/overlay/d3d9.cpp
@@ -700,7 +700,7 @@ static HRESULT __stdcall myCreateDevice(IDirect3D9 * id3d, UINT Adapter, D3DDEVT
 	idd->AddRef();
 	ds->initRefCount = idd->Release();
 
-	if (devMap.find(idd) != devMap.end()) {
+	if (devMap[idd] != NULL) {
 		ods("Device exists in devMap already - canceling injection into device");
 		delete ds;
 		return hr;
@@ -764,7 +764,7 @@ static HRESULT __stdcall myCreateDeviceEx(IDirect3D9Ex * id3d, UINT Adapter, D3D
 	idd->AddRef();
 	ds->initRefCount = idd->Release();
 
-	if (devMap.find(idd) != devMap.end()) {
+	if (devMap[idd] != NULL) {
 		ods("Device exists in devMap already - canceling injection into device");
 		delete ds;
 		return hr;