REFAC(positional-audio): Proper functions/classes for module-related operations

Previously, only module() was present: it retrieved the base address of the specified module.

It worked fine, but it iterated through the process' modules every time it was called.

This commit replaces it with modules(), which returns an std::unordered_map containing all modules.

The map uses the module name as key and Module as value.

Aside from the performance improvement, the new code also provides info for each module region:

- Start address.
- Size.
- Whether it's readable, writable and/or executable.

1 files changed, 7 insertions, 1 deletions

diff --git a/plugins/ProcessWindows.cpp b/plugins/ProcessWindows.cpp
index b872cf64d..77cf304fa 100644
--- a/plugins/ProcessWindows.cpp
+++ b/plugins/ProcessWindows.cpp
@@ -8,7 +8,13 @@
 #include "mumble_plugin_win32_internals.h"
 
 ProcessWindows::ProcessWindows(const procid_t id, const std::string &name) : Process(id, name) {
-	const auto address = module(name);
+	const auto mods = modules();
+	const auto iter = mods.find(name);
+	if (iter == mods.cend()) {
+		return;
+	}
+
+	const auto address = iter->second.baseAddress();
 	if (!address) {
 		return;
 	}