diff options
author | Mikkel Krautz <mikkel@krautz.dk> | 2017-02-26 01:10:38 +0300 |
---|---|---|
committer | Mikkel Krautz <mikkel@krautz.dk> | 2017-02-26 01:10:38 +0300 |
commit | d5f04b42234fe369bfac686670837ff3fcb7afc6 (patch) | |
tree | 13db605dec06386e8b102613aafc4e6698b560ad /src/murmur/Cert.cpp | |
parent | e95dd303fb1c863f79d59a09217a37e66ccd129c (diff) |
Meta: avoid cluttering the global QSslSocket::defaultCaCertificates() list.
Before this commit, we would add any intermediate certificates found in
the SSL certificate's PEM bundle to the default CA list via
QSslSocket::addDefaultCaCertificates().
We would also add any certificates found in the sslCA PEM bundle to the
default CA list, using the same method.
Due to the way the hot-reload feature for SSL settings is going to work,
these patterns wouldn't work well in that environment, because reloading
the settings would keep adding entries to the global QSslSocket default
CA certificates list. (QSslSocket::defaultCaCertificates())
To combat this, this series of commits try to be more strict about how
default CAs and intermediates in general are handled.
Generally, instead of adding them to the global QSslSocket default CA
list, we add them to each QSslSocket as necessary.
Note: this commit does not stand on its own. It requires the follow-up
commits in this PR. It is split out to aid in reviewing.
Diffstat (limited to 'src/murmur/Cert.cpp')
0 files changed, 0 insertions, 0 deletions