diff options
author | Jesse Mazzella <ozyx@users.noreply.github.com> | 2022-05-26 19:45:16 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-05-26 19:45:16 +0300 |
commit | 6c71fa01f5845d1ab5a75794e5a5f54823cfb0de (patch) | |
tree | e8636d98120573ed4233e7f768f41448024644a4 /.eslintrc.js | |
parent | c56d458ecb448a060448bf5daa759ea22849a163 (diff) |
Fix existing eslint warnings, configure eslint to fail on warning (#5258)
* [e2e] Remove unnecessary step with force click
* `test.skip()` -> `test.fixme()`
* Bypass `no-wait-for-timeout` rule for visual tests
* Fail lint step if warnings > 0
* Set default value for `imageUrl`
- Resolves `vue/require-default-prop` warning
* Disable eslint rule `you-dont-need-lodash-underscore/get`
- Disable the rule for now as the implementation they suggest doesn't match lodash `_.get()` functionality, and fails a bunch of our tests. See https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/issues/311 and https://github.com/you-dont-need/You-Dont-Need-Lodash-Underscore/issues/294
* Disable `no-wait-for-timeout` warning for `visual` folder
* Add rule exception and comments in logPlot test
- Add exception and FIXME for timeout
- Add comment on fixme test to discourage community contribution
* clean up tests
- remove unnecessary awaits
- update locators to use data-testid where possible
- remove unnecessary wait
* Wait for image count condition instead of timeout
* code review comments: use expect.poll()
* readability
* .fixme() + comment instead of .skip()
* disable `.skip()` warning for memleak test suite
Diffstat (limited to '.eslintrc.js')
-rw-r--r-- | .eslintrc.js | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/.eslintrc.js b/.eslintrc.js index 319d7cf44..26e807490 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -29,6 +29,7 @@ module.exports = { "you-dont-need-lodash-underscore/omit": "off", "you-dont-need-lodash-underscore/throttle": "off", "you-dont-need-lodash-underscore/flatten": "off", + "you-dont-need-lodash-underscore/get": "off", "no-bitwise": "error", "curly": "error", "eqeqeq": "error", |