Add a suite of tests for ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Test ShareModel error handling

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Improve testing of user/group shares in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add testing for maximum share expire date enforcement in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

4 files changed, 10 insertions, 2 deletions

diff --git a/src/gui/filedetails/sharemodel.cpp b/src/gui/filedetails/sharemodel.cpp
index 19e603b23..fdf2b28de 100644
--- a/src/gui/filedetails/sharemodel.cpp
+++ b/src/gui/filedetails/sharemodel.cpp
@@ -196,6 +196,7 @@ void ShareModel::resetData()
     _hasInitialShareFetchCompleted = false;
     _sharees.clear();
 
+    Q_EMIT sharePermissionsChanged();
     Q_EMIT fetchOngoingChanged();
     Q_EMIT hasInitialShareFetchCompletedChanged();
     Q_EMIT shareesChanged();
@@ -362,8 +363,10 @@ void ShareModel::slotPropfindReceived(const QVariantMap &result)
 
 void ShareModel::slotSharesFetched(const QList<SharePtr> &shares)
 {
-    _hasInitialShareFetchCompleted = true;
-    Q_EMIT hasInitialShareFetchCompletedChanged();
+    if(!_hasInitialShareFetchCompleted) {
+        _hasInitialShareFetchCompleted = true;
+        Q_EMIT hasInitialShareFetchCompletedChanged();
+    }
 
     qCInfo(lcSharing) << "Fetched" << shares.count() << "shares";
 
diff --git a/src/gui/folderman.h b/src/gui/folderman.h
index bf7a8e8c8..8cc499cd8 100644
--- a/src/gui/folderman.h
+++ b/src/gui/folderman.h
@@ -27,6 +27,7 @@
 
 class TestFolderMan;
 class TestCfApiShellExtensionsIPC;
+class TestShareModel;
 
 namespace OCC {
 
@@ -379,6 +380,7 @@ private:
     friend class OCC::Application;
     friend class ::TestFolderMan;
     friend class ::TestCfApiShellExtensionsIPC;
+    friend class ::TestShareModel;
 };
 
 } // namespace OCC
diff --git a/src/gui/sharemanager.cpp b/src/gui/sharemanager.cpp
index 7a264557d..621ab6c47 100644
--- a/src/gui/sharemanager.cpp
+++ b/src/gui/sharemanager.cpp
@@ -478,6 +478,7 @@ void ShareManager::fetchShares(const QString &path)
 
 void ShareManager::slotSharesFetched(const QJsonDocument &reply)
 {
+    qDebug() << reply;
     auto tmpShares = reply.object().value("ocs").toObject().value("data").toArray();
     const QString versionString = _account->serverVersion();
     qCDebug(lcSharing) << versionString << "Fetched" << tmpShares.count() << "shares";
diff --git a/src/gui/sharepermissions.h b/src/gui/sharepermissions.h
index 92ce95766..28028e9dd 100644
--- a/src/gui/sharepermissions.h
+++ b/src/gui/sharepermissions.h
@@ -35,4 +35,6 @@ Q_DECLARE_OPERATORS_FOR_FLAGS(SharePermissions)
 
 } // namespace OCC
 
+Q_DECLARE_METATYPE(OCC::SharePermission)
+
 #endif