Age | Commit message (Collapse) | Author |
|
Signed-off-by: Nathan Pratta Teodosio <nathan.teodosio@canonical.com>
|
|
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
|
dispatch_source_cancel is done
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
|
|
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
|
|
nullptr
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
|
|
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
|
|
close #3572
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
|
qt creator for example requires that headers are explcitly given in the
source lists
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
|
For development a app bundle is not needed. The app bundle is only
needed for distribution and macdeployqt takes a lot of time.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
|
|
Fix: https://github.com/nextcloud/desktop/issues/3967
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
|
|
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
|
Issue #3584
Signed-off-by: Mathias Eggert <mathias.eggert@nexenio.com>
|
|
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
|
|
CMake provides what we wan out of the box
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
|
|
our requirements guarantee availability of override keyword so we just
use it
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
|
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
|
|
identifier's name.
Signed-off-by: allexzander <blackslayer4@gmail.com>
|
|
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
|
|
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
|
|
We don't need ECM to check for KIO
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
|
|
Remove some stuff that is not needed.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
|
|
|
|
Done by ckamm and dschmidt
|
|
It appears that several extension can be loaded at the same time, but their
classname for the extension need to be different, otherwise only the last
loaded one would be active.
Issue #6524
|
|
Everyone uses their private mail, so ensure people can get in touch.
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Use CMake to generate a WXI fragment to handle the DLL registration and file deployment for the shellext components.
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
APPLICATION_EXECUTABLE
Avoid interference with foreign pipes as this is always a bad idea ;p
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
update version info
This also ensures a clear separation in the system registry.
SelfReg is not recommended by Microsoft and will be handled by the MSI package to allow proper Repair and Uninstall.
However, we keep it for backward compatibility with the NSIS installer.
For details see:
https://stackoverflow.com/questions/364187/how-do-you-register-a-win32-com-dll-file-in-wix-3#364210
https://docs.microsoft.com/en-us/windows/win32/msi/selfreg-table#remarks
Another fix by this commit:
The "Version" registry value in the NCOverlays self reg should be a key and not a value.
Details: https://wixtoolset.org/documentation/manual/v3/xsd/wix/class.html
Example:
[HKCR\CLSID\{01234567-89AB-CDEF-0123-456789ABCDEF}\Version]
@="1.0.0.0"
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Previously side by side installation with ownCloud or other NC custom builds would break the shell integration because the same GUIDs and registry keys were used.
Now we specify our custom GUIDs in NEXTCLOUD.cmake and use CMake to generate a header file and WiX (MSI) include file with these constants.
Note: Using generators like "guidgen" or "uuidgen" ensures that GUIDs are unique, as manual changes are not guaranteed to be.
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Otherwise we can't have operation that has many many filename
As reported in #6780
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
It's a copy from OCContextMenu/resources.h
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
To set the dll's metadata.
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
|
|
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
|
|
Make the codebase consistent, we already have a lot of implicit pointer comparisons.
Exception: Stay explicit on return's, example:
return _db != nullptr;
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
Merging PR #2057 caused the Windows build to fail:
shell_integration\windows\OCUtil\RegistryUtil.cpp(43): error C2664: 'LSTATUS RegOpenKeyExW(HKEY,LPCWSTR,DWORD,REGSAM,PHKEY)': cannot convert argument 3 from 'nullptr' to 'DWORD'
The previous implementation prior the PR supplied NULL as the argument 3 to RegOpenKeyEx,
so it was silently accepted and translated to zero, satisfying the DWORD's type requirement.
Signed-off-by: Michael Schuster <michael@schuster.ms>
|
|
We keep NULL in the pure C files in src/csync/std and test/csync.
We also replace Doxygen documentation referring to "NULL" to
"\c nullptr" (formatted as code).
Signed-off-by: Stephan Beyer <s-beyer@gmx.net>
|
|
This both removes older Qt from the CI and also adjust all the
find_package calls in CMakeLists.txt
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
|
|
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
|
|
Signed-off-by: Daniel Vedder <d.vedder@web.de>
|
|
Fixes issue #1948: https://github.com/nextcloud/desktop/issues/1948
The client already resolves symlinks when adding new paths to the
sync-list, but the Nautilus plugin did not do this yet, causing it
to not recognise synced folders if they were accessed via a symlink.
Signed-off-by: Daniel Vedder <d.vedder@web.de>
|