add tests for externalApiController

1 files changed, 318 insertions, 0 deletions

diff --git a/tests/unit/controller/ExternalApiControllerTest.php b/tests/unit/controller/ExternalApiControllerTest.php
new file mode 100644
index 0000000..61d2a5b
--- /dev/null
+++ b/tests/unit/controller/ExternalApiControllerTest.php
@@ -0,0 +1,318 @@
+<?php
+
+namespace OCA\OJSXC\Controller;
+
+use OCA\OJSXC\Controller\ExternalApiController;
+use OCA\OJSXC\Controller\SignatureProtectedApiController;
+use OCP\IRequest;
+use OCP\IUserManager;
+use OCP\IGroupManager;
+use OCP\ILogger;
+use OCP\IUser;
+use OCP\IGroup;
+use PHPUnit\Framework\TestCase;
+
+class ExternalApiControllerTest extends TestCase {
+   private $request;
+   private $userManager;
+   private $groupManager;
+   private $logger;
+   private $user;
+   private $externalApiController;
+
+   public function setUp() {
+      parent::setUp();
+
+      $this->request = $this->createMock(IRequest::class);
+      $this->userManager = $this->createMock(IUserManager::class);
+      $this->groupManager = $this->createMock(IGroupManager::class);
+      $this->logger = $this->createMock(ILogger::class);
+      $this->user = $this->createMock(IUser::class);
+
+      $this->externalApiController = new ExternalApiController(
+         'ojsxc',
+         $this->request,
+         $this->userManager,
+         $this->groupManager,
+         $this->logger
+      );
+   }
+
+   public function testSignatureProtected() {
+      $this->assertInstanceOf(SignatureProtectedApiController::class, $this->externalApiController);
+   }
+
+   public function testCheckPasswordWithInvalidParams() {
+      $this->userManager
+               ->expects($this->once())
+               ->method('checkPassword')
+               ->with('foo', 'bar')
+               ->willReturn(false);
+
+      $return = $this->externalApiController->checkPassword('foo', 'bar');
+
+      $this->assertEquals('noauth', $return['result']);
+   }
+
+   public function testCheckPasswordWithInvalidParamsAndDomain() {
+      $this->userManager
+               ->expects($this->once())
+               ->method('checkPassword')
+               ->with('foo@localhost', 'bar')
+               ->willReturn(false);
+
+      $return = $this->externalApiController->checkPassword('foo', 'bar', 'localhost');
+
+      $this->assertEquals('noauth', $return['result']);
+   }
+
+   public function testCheckPasswordWithValidParams() {
+      $uid = 'foo';
+      $this->user
+               ->expects($this->once())
+               ->method('getUID')
+               ->willReturn($uid);
+      $this->userManager
+               ->expects($this->once())
+               ->method('checkPassword')
+               ->with('foo', 'bar')
+               ->willReturn($this->user);
+
+      $return = $this->externalApiController->checkPassword('foo', 'bar');
+
+      $this->assertEquals('success', $return['result']);
+      $this->assertEquals($uid, $return['data']['uid']);
+   }
+
+   public function testCheckPasswordWithValidParamsAndDomain() {
+      $uid = 'foo';
+      $this->user
+               ->expects($this->once())
+               ->method('getUID')
+               ->willReturn($uid);
+      $this->userManager
+               ->expects($this->once())
+               ->method('checkPassword')
+               ->with('foo@localhost', 'bar')
+               ->willReturn($this->user);
+
+      $return = $this->externalApiController->checkPassword('foo', 'bar', 'localhost');
+
+      $this->assertEquals('success', $return['result']);
+      $this->assertEquals($uid, $return['data']['uid']);
+   }
+
+   public function testIsUserFail() {
+      $this->userManager
+               ->expects($this->once())
+               ->method('userExists')
+               ->with('foo')
+               ->willReturn(false);
+
+      $return = $this->externalApiController->isUser('foo');
+
+      $this->assertEquals('success', $return['result']);
+      $this->assertEquals(false, $return['data']['isUser']);
+   }
+
+   public function testIsUserFailWithDomain() {
+      $this->userManager
+               ->expects($this->once())
+               ->method('userExists')
+               ->with('foo@localhost')
+               ->willReturn(false);
+
+      $return = $this->externalApiController->isUser('foo', 'localhost');
+
+      $this->assertEquals('success', $return['result']);
+      $this->assertEquals(false, $return['data']['isUser']);
+   }
+
+   public function testIsUserSuccess() {
+      $this->userManager
+               ->expects($this->once())
+               ->method('userExists')
+               ->with('foo')
+               ->willReturn(true);
+
+      $return = $this->externalApiController->isUser('foo');
+
+      $this->assertEquals('success', $return['result']);
+      $this->assertEquals(true, $return['data']['isUser']);
+   }
+
+   public function testIsUserSuccessWithDomain() {
+      $this->userManager
+               ->expects($this->once())
+               ->method('userExists')
+               ->with('foo@localhost')
+               ->willReturn(true);
+
+      $return = $this->externalApiController->isUser('foo', 'localhost');
+
+      $this->assertEquals('success', $return['result']);
+      $this->assertEquals(true, $return['data']['isUser']);
+   }
+
+   public function testSharedRosterWithoutUsername() {
+      $this->expectException(\Exception::class);
+      $this->expectExceptionMessage('No username provided');
+
+      $this->externalApiController->sharedRoster();
+   }
+
+   public function testSharedRosterNoGroups() {
+      $user = $this->createUserMock('foobar');
+
+      $this->userManager
+               ->expects($this->once())
+               ->method('get')
+               ->with($user->getUID())
+               ->willReturn($user);
+
+      $this->groupManager
+               ->expects($this->once())
+               ->method('getUserGroups')
+               ->with($user)
+               ->willReturn([]);
+
+      $return = $this->externalApiController->sharedRoster($user->getUID());
+
+      $this->assertEquals('success', $return['result']);
+      $this->assertEquals([], $return['data']['sharedRoster']);
+   }
+
+   public function testSharedRosterMultipleDistinctGroups() {
+      $user = $this->createUserMock('foobar');
+
+      $this->userManager
+               ->expects($this->once())
+               ->method('get')
+               ->with($user->getUID())
+               ->willReturn($user);
+
+      $this->groupManager
+               ->expects($this->once())
+               ->method('getUserGroups')
+               ->with($user)
+               ->willReturn([
+                  $this->createGroupMock('Group1', ['Foo Bar', 'John Doo', 'user42']),
+                  $this->createGroupMock('Group2', ['Fritz', 'John', 'Eve'])
+               ]);
+
+      $expectedResult = [
+         'Foo-Bar' => [
+            'name' => 'Foo Bar',
+            'groups' => ['Group1']
+         ],
+         'John-Doo' => [
+            'name' => 'John Doo',
+            'groups' => ['Group1']
+         ],
+         'user42' => [
+            'name' => 'user42',
+            'groups' => ['Group1']
+         ],
+         'Fritz' => [
+            'name' => 'Fritz',
+            'groups' => ['Group2']
+         ],
+         'John' => [
+            'name' => 'John',
+            'groups' => ['Group2']
+         ],
+         'Eve' => [
+            'name' => 'Eve',
+            'groups' => ['Group2']
+         ]
+      ];
+
+      $return = $this->externalApiController->sharedRoster($user->getUID());
+
+      $this->assertEquals('success', $return['result']);
+
+      foreach($return['data']['sharedRoster'] as $key=>$value) {
+         $this->assertEquals($expectedResult[$key], $value);
+      }
+   }
+
+   public function testSharedRosterMultipleOverlapGroups() {
+      $user = $this->createUserMock('foobar');
+
+      $this->userManager
+               ->expects($this->once())
+               ->method('get')
+               ->with($user->getUID())
+               ->willReturn($user);
+
+      $this->groupManager
+               ->expects($this->once())
+               ->method('getUserGroups')
+               ->with($user)
+               ->willReturn([
+                  $this->createGroupMock('Group1', ['Foo Bar', 'John Doo', 'user42']),
+                  $this->createGroupMock('Group2', ['user42', 'John', 'Foo Bar'])
+               ]);
+
+      $expectedResult = [
+         'Foo-Bar' => [
+            'name' => 'Foo Bar',
+            'groups' => ['Group1', 'Group2']
+         ],
+         'John-Doo' => [
+            'name' => 'John Doo',
+            'groups' => ['Group1']
+         ],
+         'user42' => [
+            'name' => 'user42',
+            'groups' => ['Group1', 'Group2']
+         ],
+         'John' => [
+            'name' => 'John',
+            'groups' => ['Group2']
+         ]
+      ];
+
+      $return = $this->externalApiController->sharedRoster($user->getUID());
+
+      $this->assertEquals('success', $return['result']);
+
+      foreach($return['data']['sharedRoster'] as $key=>$value) {
+         $this->assertEquals($expectedResult[$key], $value);
+      }
+   }
+
+   private function createGroupMock($groupName, $displayNames = []) {
+      $users = [];
+
+      foreach($displayNames as $displayName) {
+         $users[] = $this->createUserMock($displayName);
+      }
+
+      $group = $this->createMock(IGroup::class);
+
+      $group
+         ->method('getDisplayName')
+         ->willReturn($groupName);
+
+      $group
+         ->method('getUsers')
+         ->willReturn($users);
+
+      return $group;
+   }
+
+   private function createUserMock($displayName) {
+      $user = $this->createMock(IUser::class);
+
+      $user
+         ->method('getUID')
+         ->willReturn(preg_replace('/ /', '-', $displayName));
+
+      $user
+         ->method('getDisplayName')
+         ->willReturn($displayName);
+
+      return $user;
+   }
+}