Remove unneccessary account checkperf/remove-account-check

As we're already joining on the user accounts table, the account doesn't need to be queried again for a single show.

This is a mini performance optimistation.

THe complete account data could also be returned with the JOIN queries as a second
performance improvement, instead of querying the entity fromt he DB again

The update method does just that at the moment.

Signed-off-by: Anna Larch <anna@nextcloud.com>

2 files changed, 0 insertions, 22 deletions

diff --git a/lib/Controller/OutboxController.php b/lib/Controller/OutboxController.php
index e8716ad28..d4e868455 100644
--- a/lib/Controller/OutboxController.php
+++ b/lib/Controller/OutboxController.php
@@ -75,7 +75,6 @@ class OutboxController extends Controller {
 	 */
 	public function show(int $id): JsonResponse {
 		$message = $this->service->getMessage($id, $this->userId);
-		$this->accountService->find($this->userId, $message->getAccountId());
 		return JsonResponse::success($message);
 	}
 
diff --git a/tests/Unit/Controller/OutboxControllerTest.php b/tests/Unit/Controller/OutboxControllerTest.php
index 688c3bc21..313511936 100644
--- a/tests/Unit/Controller/OutboxControllerTest.php
+++ b/tests/Unit/Controller/OutboxControllerTest.php
@@ -98,8 +98,6 @@ class OutboxControllerTest extends TestCase {
 			->method('getMessage')
 			->with($message->getId(), $this->userId)
 			->willReturn($message);
-		$this->accountService->expects(self::once())
-			->method('find');
 
 		$expected = JsonResponse::success($message);
 		$actual = $this->controller->show($message->getId());
@@ -115,30 +113,11 @@ class OutboxControllerTest extends TestCase {
 			->method('getMessage')
 			->with($message->getId(), $this->userId)
 			->willThrowException(new DoesNotExistException(''));
-		$this->accountService->expects(self::never())
-			->method('find');
 
 		$this->expectException(DoesNotExistException::class);
 		$this->controller->show($message->getId());
 	}
 
-	public function testShowAccountNotFound(): void {
-		$message = new LocalMessage();
-		$message->setId(1);
-		$message->setAccountId(1);
-
-		$this->service->expects(self::once())
-			->method('getMessage')
-			->with($message->getId(), $this->userId)
-			->willReturn($message);
-		$this->accountService->expects(self::once())
-			->method('find')
-			->willThrowException(new ClientException('', 400));
-
-		$this->expectException(ClientException::class);
-		$this->controller->show($message->getId());
-	}
-
 	public function testSend(): void {
 		$message = new LocalMessage();
 		$message->setId(1);