Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nextcloud/news-android.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDavid-Development <david-dev@live.de>2022-07-29 19:47:43 +0300
committerDavid Luhmer <david-dev@live.de>2022-07-29 19:47:43 +0300
commite4185d80d28ceed9d0f39cf9484349d0d9afa83c (patch)
tree69242371386a52d3896572d0ff3492509e54325a
parent1c3029f41f01e20f92f1e129261a992b67d49a32 (diff)
fix bug where svg favicons are not shown inside detail view
Signed-off-by: David Luhmer <david-dev@live.de>
-rw-r--r--News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/async_tasks/RssItemToHtmlTask.java10
1 files changed, 6 insertions, 4 deletions
diff --git a/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/async_tasks/RssItemToHtmlTask.java b/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/async_tasks/RssItemToHtmlTask.java
index 0bd768db..77780a85 100644
--- a/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/async_tasks/RssItemToHtmlTask.java
+++ b/News-Android-App/src/main/java/de/luhmer/owncloudnewsreader/async_tasks/RssItemToHtmlTask.java
@@ -1,5 +1,8 @@
package de.luhmer.owncloudnewsreader.async_tasks;
+import static de.luhmer.owncloudnewsreader.NewsDetailActivity.INCOGNITO_MODE_ENABLED;
+import static de.luhmer.owncloudnewsreader.helper.ThemeChooser.THEME;
+
import android.content.Context;
import android.content.SharedPreferences;
import android.os.AsyncTask;
@@ -24,9 +27,6 @@ import de.luhmer.owncloudnewsreader.database.model.RssItem;
import de.luhmer.owncloudnewsreader.helper.ImageHandler;
import de.luhmer.owncloudnewsreader.helper.ThemeChooser;
-import static de.luhmer.owncloudnewsreader.NewsDetailActivity.INCOGNITO_MODE_ENABLED;
-import static de.luhmer.owncloudnewsreader.helper.ThemeChooser.THEME;
-
public class RssItemToHtmlTask extends AsyncTask<Void, Void, String> {
@@ -211,7 +211,9 @@ public class RssItemToHtmlTask extends AsyncTask<Void, Void, String> {
private static String getCachedFavIcon(String favIconUrl) {
DiskCache diskCache = ImageLoader.getInstance().getDiskCache();
File file = diskCache.get(favIconUrl);
- if(file != null) {
+ // note that the universalimageloader does NOT support svg icons.
+ // Therefore we don't want to use any cached items (the webview can render svg's just fine)
+ if (file != null && !favIconUrl.endsWith(".svg")) {
return "file://" + file.getAbsolutePath();
} else {
return favIconUrl; // Return favicon url if not cached