diff options
| author | Carl Schwan <carl@carlschwan.eu> | 2021-11-10 19:43:42 +0300 |
|---|---|---|
| committer | Carl Schwan <carl@carlschwan.eu> | 2021-11-10 19:44:01 +0300 |
| commit | a50e37cce594a75d6ad858e447ed1e20297cea06 (patch) | |
| tree | d81b9daaee1ad5eebe6f7bb8161642db6e5ffa82 | |
| parent | a1c627824765f1bd6f6eef3445c70756c6bae98a (diff) | |
[stable20] Update psaml baselinepsaml-baseline-stable20
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
| -rw-r--r-- | build/psalm-baseline.xml | 1164 |
1 files changed, 341 insertions, 823 deletions
diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml index dc2726c7c37..9b1c8b13d6a 100644 --- a/build/psalm-baseline.xml +++ b/build/psalm-baseline.xml @@ -1,10 +1,5 @@ <?xml version="1.0" encoding="UTF-8"?> -<files psalm-version="3.15@de6e7f324f44dde540ebe7ebd4eb481b97c86f30"> - <file src="3rdparty/doctrine/dbal/lib/Doctrine/DBAL/Connection.php"> - <ImplementedReturnTypeMismatch occurrences="1"> - <code>string|null</code> - </ImplementedReturnTypeMismatch> - </file> +<files psalm-version="4.8.1@f73f2299dbc59a3e6c4d66cff4605176e728ee69"> <file src="3rdparty/sabre/dav/lib/CalDAV/Calendar.php"> <MoreSpecificImplementedParamType occurrences="1"> <code>$calendarData</code> @@ -54,9 +49,7 @@ <InvalidScalarArgument occurrences="1"> <code>$e->getCode()</code> </InvalidScalarArgument> - <TypeDoesNotContainType occurrences="1"> - <code>is_array($notification)</code> - </TypeDoesNotContainType> + <TypeDoesNotContainType occurrences="1"/> </file> <file src="apps/comments/lib/JSSettingsHelper.php"> <InvalidScalarArgument occurrences="1"> @@ -80,9 +73,9 @@ </file> <file src="apps/contactsinteraction/lib/Db/CardSearchDao.php"> <ImplicitToStringCast occurrences="3"> - <code>$propQuery->createFunction($addressbooksQuery->getSQL())</code> - <code>$cardQuery->createFunction($propQuery->getSQL())</code> <code>$cardQuery->createFunction($addressbooksQuery->getSQL())</code> + <code>$cardQuery->createFunction($propQuery->getSQL())</code> + <code>$propQuery->createFunction($addressbooksQuery->getSQL())</code> </ImplicitToStringCast> </file> <file src="apps/dav/appinfo/v1/caldav.php"> @@ -103,8 +96,8 @@ </file> <file src="apps/dav/appinfo/v1/publicwebdav.php"> <InternalMethod occurrences="2"> - <code>\OC\Files\Filesystem::logWarningWhenAddingStorageWrapper(false)</code> <code>\OC\Files\Filesystem::logWarningWhenAddingStorageWrapper($previousLog)</code> + <code>\OC\Files\Filesystem::logWarningWhenAddingStorageWrapper(false)</code> </InternalMethod> <UndefinedGlobalVariable occurrences="1"> <code>$baseuri</code> @@ -176,10 +169,10 @@ <code>setDateTime</code> </UndefinedMethod> <UndefinedPropertyFetch occurrences="4"> - <code>$newCalendarData->VEVENT->DTSTART</code> <code>$existingBirthday->VEVENT->DTSTART</code> - <code>$newCalendarData->VEVENT->SUMMARY</code> <code>$existingBirthday->VEVENT->SUMMARY</code> + <code>$newCalendarData->VEVENT->DTSTART</code> + <code>$newCalendarData->VEVENT->SUMMARY</code> </UndefinedPropertyFetch> </file> <file src="apps/dav/lib/CalDAV/CachedSubscription.php"> @@ -203,29 +196,29 @@ </file> <file src="apps/dav/lib/CalDAV/CalDavBackend.php"> <ImplicitToStringCast occurrences="7"> - <code>$query->createParameter('principaluri')</code> + <code>$calendarObjectIdQuery->createNamedParameter($componentTypes, IQueryBuilder::PARAM_STR_ARRAY)</code> + <code>$outerQuery->createFunction($innerQuery->getSQL())</code> + <code>$query->createNamedParameter($matches, IQueryBuilder::PARAM_INT_ARRAY)</code> <code>$query->createNamedParameter(self::ACCESS_PUBLIC)</code> <code>$query->createNamedParameter(self::ACCESS_PUBLIC)</code> + <code>$query->createParameter('principaluri')</code> <code>$query->createParameter('uri')</code> - <code>$outerQuery->createFunction($innerQuery->getSQL())</code> - <code>$calendarObjectIdQuery->createNamedParameter($componentTypes, IQueryBuilder::PARAM_STR_ARRAY)</code> - <code>$query->createNamedParameter($matches, IQueryBuilder::PARAM_INT_ARRAY)</code> </ImplicitToStringCast> <InvalidArgument occurrences="14"> + <code>'\OCA\DAV\CalDAV\CalDavBackend::createCachedCalendarObject'</code> <code>'\OCA\DAV\CalDAV\CalDavBackend::createCalendar'</code> - <code>'\OCA\DAV\CalDAV\CalDavBackend::updateCalendar'</code> - <code>'\OCA\DAV\CalDAV\CalDavBackend::deleteCalendar'</code> <code>'\OCA\DAV\CalDAV\CalDavBackend::createCalendarObject'</code> - <code>'\OCA\DAV\CalDAV\CalDavBackend::createCachedCalendarObject'</code> - <code>'\OCA\DAV\CalDAV\CalDavBackend::updateCalendarObject'</code> - <code>'\OCA\DAV\CalDAV\CalDavBackend::updateCachedCalendarObject'</code> - <code>'\OCA\DAV\CalDAV\CalDavBackend::deleteCalendarObject'</code> - <code>'\OCA\DAV\CalDAV\CalDavBackend::deleteCachedCalendarObject'</code> <code>'\OCA\DAV\CalDAV\CalDavBackend::createSubscription'</code> - <code>'\OCA\DAV\CalDAV\CalDavBackend::updateSubscription'</code> + <code>'\OCA\DAV\CalDAV\CalDavBackend::deleteCachedCalendarObject'</code> + <code>'\OCA\DAV\CalDAV\CalDavBackend::deleteCalendar'</code> + <code>'\OCA\DAV\CalDAV\CalDavBackend::deleteCalendarObject'</code> <code>'\OCA\DAV\CalDAV\CalDavBackend::deleteSubscription'</code> - <code>'\OCA\DAV\CalDAV\CalDavBackend::updateShares'</code> <code>'\OCA\DAV\CalDAV\CalDavBackend::publishCalendar'</code> + <code>'\OCA\DAV\CalDAV\CalDavBackend::updateCachedCalendarObject'</code> + <code>'\OCA\DAV\CalDAV\CalDavBackend::updateCalendar'</code> + <code>'\OCA\DAV\CalDAV\CalDavBackend::updateCalendarObject'</code> + <code>'\OCA\DAV\CalDAV\CalDavBackend::updateShares'</code> + <code>'\OCA\DAV\CalDAV\CalDavBackend::updateSubscription'</code> </InvalidArgument> <InvalidNullableReturnType occurrences="2"> <code>array</code> @@ -249,35 +242,30 @@ <code>dispatch</code> <code>dispatch</code> <code>dispatch</code> - <code>purgeProperties</code> <code>dispatch</code> <code>dispatch</code> <code>dispatch</code> <code>dispatch</code> <code>dispatch</code> + <code>purgeProperties</code> </TooManyArguments> <UndefinedFunction occurrences="4"> + <code>Uri\split($principalUri)</code> <code>Uri\split($row['principaluri'])</code> <code>Uri\split($row['principaluri'])</code> <code>Uri\split($row['principaluri'])</code> - <code>Uri\split($principalUri)</code> </UndefinedFunction> </file> - <file src="apps/dav/lib/CalDAV/Calendar.php"> - <NullableReturnStatement occurrences="1"> - <code>parent::getOwner()</code> - </NullableReturnStatement> - </file> <file src="apps/dav/lib/CalDAV/CalendarHome.php"> <InvalidClass occurrences="1"> <code>\Sabre\CalDAv\Notifications\Collection</code> </InvalidClass> <InvalidReturnStatement occurrences="5"> + <code>$calendarPlugin->getCalendarInCalendarHome($this->principalInfo['uri'], $calendarUri)</code> <code>new Inbox($this->caldavBackend, $this->principalInfo['uri'])</code> <code>new Outbox($this->config, $this->principalInfo['uri'])</code> - <code>new \Sabre\CalDAv\Notifications\Collection($this->caldavBackend, $this->principalInfo['uri'])</code> <code>new Subscription($this->caldavBackend, $subscription)</code> - <code>$calendarPlugin->getCalendarInCalendarHome($this->principalInfo['uri'], $calendarUri)</code> + <code>new \Sabre\CalDAv\Notifications\Collection($this->caldavBackend, $this->principalInfo['uri'])</code> </InvalidReturnStatement> <InvalidReturnType occurrences="1"> <code>getChild</code> @@ -311,27 +299,25 @@ </file> <file src="apps/dav/lib/CalDAV/Reminder/NotificationProvider/AbstractProvider.php"> <UndefinedMethod occurrences="3"> - <code>isFloating</code> <code>hasTime</code> <code>isFloating</code> + <code>isFloating</code> </UndefinedMethod> </file> <file src="apps/dav/lib/CalDAV/Reminder/NotificationProvider/EmailProvider.php"> <FalsableReturnStatement occurrences="4"> - <code>$l10n->l('weekdayName', $dt, ['width' => 'abbreviated'])</code> <code>$l10n->l('date', $dt, ['width' => 'medium'])</code> <code>$l10n->l('datetime', $dt, ['width' => 'medium|short'])</code> <code>$l10n->l('time', $dt, ['width' => 'short'])</code> - </FalsableReturnStatement> - <InvalidReturnStatement occurrences="5"> - <code>[$organizerEMail => $name]</code> <code>$l10n->l('weekdayName', $dt, ['width' => 'abbreviated'])</code> + </FalsableReturnStatement> + <InvalidReturnStatement occurrences="4"> <code>$l10n->l('date', $dt, ['width' => 'medium'])</code> <code>$l10n->l('datetime', $dt, ['width' => 'medium|short'])</code> <code>$l10n->l('time', $dt, ['width' => 'short'])</code> + <code>$l10n->l('weekdayName', $dt, ['width' => 'abbreviated'])</code> </InvalidReturnStatement> - <InvalidReturnType occurrences="5"> - <code>array|null</code> + <InvalidReturnType occurrences="4"> <code>string</code> <code>string</code> <code>string</code> @@ -339,22 +325,22 @@ </InvalidReturnType> <UndefinedMethod occurrences="3"> <code>getDateTime</code> - <code>isFloating</code> <code>getDateTime</code> + <code>isFloating</code> </UndefinedMethod> </file> <file src="apps/dav/lib/CalDAV/Reminder/Notifier.php"> <FalsableReturnStatement occurrences="4"> - <code>$this->l10n->l('weekdayName', $dt, ['width' => 'abbreviated'])</code> <code>$this->l10n->l('date', $dt, ['width' => 'medium'])</code> <code>$this->l10n->l('datetime', $dt, ['width' => 'medium|short'])</code> <code>$this->l10n->l('time', $dt, ['width' => 'short'])</code> + <code>$this->l10n->l('weekdayName', $dt, ['width' => 'abbreviated'])</code> </FalsableReturnStatement> <InvalidReturnStatement occurrences="4"> - <code>$this->l10n->l('weekdayName', $dt, ['width' => 'abbreviated'])</code> <code>$this->l10n->l('date', $dt, ['width' => 'medium'])</code> <code>$this->l10n->l('datetime', $dt, ['width' => 'medium|short'])</code> <code>$this->l10n->l('time', $dt, ['width' => 'short'])</code> + <code>$this->l10n->l('weekdayName', $dt, ['width' => 'abbreviated'])</code> </InvalidReturnStatement> <InvalidReturnType occurrences="4"> <code>string</code> @@ -397,34 +383,28 @@ </file> <file src="apps/dav/lib/CalDAV/Schedule/IMipPlugin.php"> <ImplicitToStringCast occurrences="2"> - <code>$vevent->SUMMARY</code> <code>$vevent->LOCATION</code> + <code>$vevent->SUMMARY</code> </ImplicitToStringCast> <InvalidNullableReturnType occurrences="1"> <code>string</code> </InvalidNullableReturnType> - <InvalidScalarArgument occurrences="2"> - <code>[$sender => $senderName]</code> - <code>[$recipient => $recipientName]</code> - </InvalidScalarArgument> <NullableReturnStatement occurrences="1"> <code>$lang->getValue()</code> </NullableReturnStatement> - <UndefinedMethod occurrences="15"> + <UndefinedMethod occurrences="10"> <code>getDateTime</code> <code>getDateTime</code> <code>getDateTime</code> - <code>hasTime</code> <code>getDateTime</code> - <code>isFloating</code> <code>getDateTime</code> - <code>setDateTime</code> - <code>hasTime</code> - <code>isFloating</code> <code>getDateTime</code> - <code>setDateTime</code> <code>getDateTime</code> <code>getDateTime</code> + <code>hasTime</code> + <code>hasTime</code> + <code>isFloating</code> + <code>isFloating</code> <code>isFloating</code> </UndefinedMethod> <UndefinedPropertyFetch occurrences="1"> @@ -440,14 +420,14 @@ <code>split($principalUrl)</code> </UndefinedFunction> <UndefinedInterfaceMethod occurrences="2"> - <code>getChildren</code> <code>get</code> + <code>getChildren</code> </UndefinedInterfaceMethod> <UndefinedMethod occurrences="5"> <code>getDateTime</code> - <code>isFloating</code> <code>hasTime</code> <code>isFloating</code> + <code>isFloating</code> <code>principalSearch</code> </UndefinedMethod> </file> @@ -463,22 +443,13 @@ </InvalidReturnType> </file> <file src="apps/dav/lib/CalDAV/Search/Xml/Request/CalendarSearchReport.php"> - <TypeDoesNotContainType occurrences="3"> - <code>is_array($newProps['filters']['comps'])</code> - <code>is_array($newProps['filters']['props'])</code> - <code>is_array($newProps['filters']['params'])</code> - </TypeDoesNotContainType> + <TypeDoesNotContainType occurrences="3"/> </file> <file src="apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php"> <InvalidArgument occurrences="1"> <code>$webcalData</code> </InvalidArgument> </file> - <file src="apps/dav/lib/CardDAV/AddressBook.php"> - <NullableReturnStatement occurrences="1"> - <code>parent::getOwner()</code> - </NullableReturnStatement> - </file> <file src="apps/dav/lib/CardDAV/AddressBookImpl.php"> <InvalidArgument occurrences="1"> <code>$id</code> @@ -493,14 +464,14 @@ <code>false</code> </FalsableReturnStatement> <ImplicitToStringCast occurrences="3"> + <code>$query->createNamedParameter($matches, IQueryBuilder::PARAM_INT_ARRAY)</code> <code>$query->createParameter('principaluri')</code> <code>$query->createParameter('uri')</code> - <code>$query->createNamedParameter($matches, IQueryBuilder::PARAM_INT_ARRAY)</code> </ImplicitToStringCast> <InvalidArgument occurrences="3"> <code>'\OCA\DAV\CardDAV\CardDavBackend::createCard'</code> - <code>'\OCA\DAV\CardDAV\CardDavBackend::updateCard'</code> <code>'\OCA\DAV\CardDAV\CardDavBackend::deleteCard'</code> + <code>'\OCA\DAV\CardDAV\CardDavBackend::updateCard'</code> </InvalidArgument> <InvalidNullableReturnType occurrences="1"> <code>array</code> @@ -520,8 +491,8 @@ <code>$addressBooks[$row['id']][$readOnlyPropertyName] === 0</code> </TypeDoesNotContainType> <UndefinedFunction occurrences="2"> - <code>\Sabre\Uri\split($row['principaluri'])</code> <code>\Sabre\Uri\split($principalUri)</code> + <code>\Sabre\Uri\split($row['principaluri'])</code> </UndefinedFunction> </file> <file src="apps/dav/lib/CardDAV/MultiGetExportPlugin.php"> @@ -559,9 +530,7 @@ </NullArgument> </file> <file src="apps/dav/lib/CardDAV/SystemAddressbook.php"> - <RedundantCondition occurrences="1"> - <code>$shareEnumeration && $restrictShareEnumeration</code> - </RedundantCondition> + <RedundantCondition occurrences="1"/> </file> <file src="apps/dav/lib/CardDAV/UserAddressBooks.php"> <InvalidArgument occurrences="2"> @@ -600,9 +569,7 @@ </InvalidArgument> </file> <file src="apps/dav/lib/Comments/EntityTypeCollection.php"> - <TypeDoesNotContainType occurrences="1"> - <code>is_string($name)</code> - </TypeDoesNotContainType> + <TypeDoesNotContainType occurrences="1"/> </file> <file src="apps/dav/lib/Comments/RootCollection.php"> <InvalidArgument occurrences="1"> @@ -625,11 +592,6 @@ <code>\Sabre\Uri\split($principal)</code> </UndefinedFunction> </file> - <file src="apps/dav/lib/Connector/PublicAuth.php"> - <InvalidScalarArgument occurrences="1"> - <code>'DummyBasic realm="' . $this->realm . '"'</code> - </InvalidScalarArgument> - </file> <file src="apps/dav/lib/Connector/Sabre/AnonymousOptionsPlugin.php"> <InvalidNullableReturnType occurrences="1"> <code>bool</code> @@ -699,9 +661,9 @@ </file> <file src="apps/dav/lib/Connector/Sabre/FilesPlugin.php"> <UndefinedFunction occurrences="3"> - <code>\Sabre\Uri\split($source)</code> <code>\Sabre\Uri\split($destination)</code> <code>\Sabre\Uri\split($filePath)</code> + <code>\Sabre\Uri\split($source)</code> </UndefinedFunction> </file> <file src="apps/dav/lib/Connector/Sabre/FilesReportPlugin.php"> @@ -722,8 +684,8 @@ <code>\OCA\Circles\Api\v1\Circles</code> </UndefinedClass> <UndefinedInterfaceMethod occurrences="2"> - <code>getPath</code> <code>getById</code> + <code>getPath</code> </UndefinedInterfaceMethod> </file> <file src="apps/dav/lib/Connector/Sabre/Node.php"> @@ -739,15 +701,15 @@ <code>$this->info->getId()</code> </NullableReturnStatement> <UndefinedFunction occurrences="2"> - <code>\Sabre\Uri\split($this->path)</code> <code>\Sabre\Uri\split($name)</code> + <code>\Sabre\Uri\split($this->path)</code> </UndefinedFunction> </file> <file src="apps/dav/lib/Connector/Sabre/ObjectTree.php"> <UndefinedFunction occurrences="3"> - <code>\Sabre\Uri\split($path)</code> <code>\Sabre\Uri\split($destinationPath)</code> <code>\Sabre\Uri\split($destinationPath)</code> + <code>\Sabre\Uri\split($path)</code> </UndefinedFunction> </file> <file src="apps/dav/lib/Connector/Sabre/Principal.php"> @@ -817,9 +779,9 @@ <UndefinedInterfaceMethod occurrences="5"> <code>getId</code> <code>getId</code> + <code>getId</code> <code>getPath</code> <code>getPath</code> - <code>getId</code> </UndefinedInterfaceMethod> <UndefinedPropertyAssignment occurrences="1"> <code>$server->xml->namespacesMap</code> @@ -908,8 +870,8 @@ </file> <file src="apps/dav/lib/Files/FileSearchBackend.php"> <InvalidArgument occurrences="2"> - <code>$operator->arguments</code> <code>$argument</code> + <code>$operator->arguments</code> </InvalidArgument> <InvalidReturnStatement occurrences="1"> <code>$value</code> @@ -966,16 +928,14 @@ <InvalidReturnType occurrences="1"> <code>string</code> </InvalidReturnType> - <UndefinedMethod occurrences="9"> + <UndefinedMethod occurrences="5"> + <code>getDateTime</code> <code>getDateTime</code> <code>getDateTime</code> - <code>isFloating</code> <code>getDateTime</code> - <code>setDateTime</code> <code>hasTime</code> <code>isFloating</code> - <code>getDateTime</code> - <code>setDateTime</code> + <code>isFloating</code> </UndefinedMethod> </file> <file src="apps/dav/lib/Search/TasksSearchProvider.php"> @@ -987,8 +947,8 @@ </file> <file src="apps/dav/lib/Server.php"> <InvalidArgument occurrences="2"> - <code>'OCA\DAV\Connector\Sabre::authInit'</code> <code>'OCA\DAV\Connector\Sabre::addPlugin'</code> + <code>'OCA\DAV\Connector\Sabre::authInit'</code> </InvalidArgument> <TooManyArguments occurrences="3"> <code>dispatch</code> @@ -1036,15 +996,15 @@ <code>$members</code> </MoreSpecificImplementedParamType> <UndefinedFunction occurrences="9"> + <code>\Sabre\Uri\split($member)</code> <code>\Sabre\Uri\split($principal)</code> <code>\Sabre\Uri\split($principal)</code> <code>\Sabre\Uri\split($principalUri)</code> - <code>\Sabre\Uri\split($member)</code> <code>\Sabre\Uri\split($principalUri)</code> - <code>\Sabre\Uri\split($realPrincipalUri)</code> <code>\Sabre\Uri\split($principalUri)</code> <code>\Sabre\Uri\split($principalUri)</code> <code>\Sabre\Uri\split($principalUri)</code> + <code>\Sabre\Uri\split($realPrincipalUri)</code> </UndefinedFunction> </file> <file src="apps/dav/lib/Upload/AssemblyStream.php"> @@ -1069,61 +1029,14 @@ <code>\Sabre\Uri\split($this->principalInfo['uri'])</code> </UndefinedFunction> </file> - <file src="apps/encryption/lib/AppInfo/Application.php"> - <UndefinedClass occurrences="33"> - <code>'UserSetup'</code> - <code>'KeyManager'</code> - <code>'UserSetup'</code> - <code>'Util'</code> - <code>'Session'</code> - <code>'Crypt'</code> - <code>'Recovery'</code> - <code>'Crypt'</code> - <code>'KeyManager'</code> - <code>'Util'</code> - <code>'Session'</code> - <code>'EncryptAll'</code> - <code>'DecryptAll'</code> - <code>'Crypt'</code> - <code>'Util'</code> - <code>'Crypt'</code> - <code>'KeyManager'</code> - <code>'Recovery'</code> - <code>'Session'</code> - <code>'KeyManager'</code> - <code>'Crypt'</code> - <code>'Session'</code> - <code>'Util'</code> - <code>'Crypt'</code> - <code>'KeyManager'</code> - <code>'Crypt'</code> - <code>'UserSetup'</code> - <code>'KeyManager'</code> - <code>'Util'</code> - <code>'Util'</code> - <code>'KeyManager'</code> - <code>'Crypt'</code> - <code>'Session'</code> - </UndefinedClass> - </file> - <file src="apps/encryption/lib/Command/ScanLegacyFormat.php"> - <RedundantCondition occurrences="1"> - <code>$result</code> - </RedundantCondition> - </file> <file src="apps/encryption/lib/Crypto/Crypt.php"> - <RedundantCondition occurrences="1"> - <code>$userSession && $userSession->isLoggedIn()</code> - </RedundantCondition> + <RedundantCondition occurrences="1"/> </file> <file src="apps/encryption/lib/Crypto/EncryptAll.php"> - <InvalidArgument occurrences="1"> - <code>[$to => $recipientDisplayName]</code> - </InvalidArgument> <UndefinedInterfaceMethod occurrences="3"> - <code>setSubject</code> <code>setHtmlBody</code> <code>setPlainBody</code> + <code>setSubject</code> </UndefinedInterfaceMethod> </file> <file src="apps/encryption/lib/Crypto/Encryption.php"> @@ -1148,20 +1061,15 @@ <InvalidThrow occurrences="1"> <code>throw $exception;</code> </InvalidThrow> - <RedundantCondition occurrences="2"> - <code>$userSession && $userSession->isLoggedIn()</code> - <code>$encryptedFileKey && $shareKey</code> - </RedundantCondition> + <RedundantCondition occurrences="1"/> </file> <file src="apps/encryption/lib/Recovery.php"> <InvalidScalarArgument occurrences="3"> - <code>1</code> <code>0</code> <code>0</code> + <code>1</code> </InvalidScalarArgument> - <RedundantCondition occurrences="1"> - <code>$userSession && $userSession->isLoggedIn()</code> - </RedundantCondition> + <RedundantCondition occurrences="1"/> </file> <file src="apps/encryption/lib/Session.php"> <TooManyArguments occurrences="1"> @@ -1169,14 +1077,10 @@ </TooManyArguments> </file> <file src="apps/encryption/lib/Users/Setup.php"> - <RedundantCondition occurrences="1"> - <code>$userSession && $userSession->isLoggedIn()</code> - </RedundantCondition> + <RedundantCondition occurrences="1"/> </file> <file src="apps/encryption/lib/Util.php"> - <RedundantCondition occurrences="1"> - <code>$userSession && $userSession->isLoggedIn()</code> - </RedundantCondition> + <RedundantCondition occurrences="1"/> </file> <file src="apps/federatedfilesharing/lib/BackgroundJob/RetryJob.php"> <MoreSpecificImplementedParamType occurrences="1"> @@ -1186,15 +1090,14 @@ </file> <file src="apps/federatedfilesharing/lib/Controller/RequestHandlerController.php"> <InvalidScalarArgument occurrences="7"> - <code>$remoteId</code> <code>$id</code> <code>$id</code> <code>$id</code> <code>$id</code> <code>$id</code> <code>$id</code> + <code>$remoteId</code> </InvalidScalarArgument> - <RedundantCondition occurrences="1"/> <TypeDoesNotContainNull occurrences="2"> <code>$permission === null</code> <code>$remoteId === null</code> @@ -1202,12 +1105,12 @@ </file> <file src="apps/federatedfilesharing/lib/FederatedShareProvider.php"> <ImplicitToStringCast occurrences="6"> + <code>$qb->createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code> <code>$qb->createNamedParameter($this->supportedShareType, IQueryBuilder::PARAM_INT_ARRAY)</code> <code>$qb->createNamedParameter($this->supportedShareType, IQueryBuilder::PARAM_INT_ARRAY)</code> <code>$qb->createNamedParameter($this->supportedShareType, IQueryBuilder::PARAM_INT_ARRAY)</code> <code>$qb->createNamedParameter($this->supportedShareType, IQueryBuilder::PARAM_INT_ARRAY)</code> <code>$qb->createNamedParameter($this->supportedShareType, IQueryBuilder::PARAM_INT_ARRAY)</code> - <code>$qb->createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code> </ImplicitToStringCast> <InvalidReturnStatement occurrences="1"> <code>$shares</code> @@ -1237,13 +1140,13 @@ <InvalidReturnType occurrences="1"> <code>string</code> </InvalidReturnType> - <InvalidScalarArgument occurrences="6"> + <InvalidScalarArgument occurrences="5"> <code>$id</code> <code>$id</code> <code>$id</code> - <code>(int)$share['id']</code> <code>$id</code> <code>$id</code> + <code>(int)$share['id']</code> </InvalidScalarArgument> </file> <file src="apps/federatedfilesharing/lib/Settings/Personal.php"> @@ -1320,9 +1223,9 @@ </file> <file src="apps/files/lib/BackgroundJob/ScanFiles.php"> <InvalidScalarArgument occurrences="3"> - <code>0</code> <code>$offset</code> <code>$offset</code> + <code>0</code> </InvalidScalarArgument> </file> <file src="apps/files/lib/Command/Scan.php"> @@ -1361,8 +1264,8 @@ <code>$templateId</code> </InvalidArgument> <UndefinedInterfaceMethod occurrences="2"> - <code>open</code> <code>getTemplates</code> + <code>open</code> </UndefinedInterfaceMethod> </file> <file src="apps/files/lib/Controller/ViewController.php"> @@ -1432,21 +1335,7 @@ <code>run</code> </InvalidReturnType> </file> - <file src="apps/files_external/lib/Command/Applicable.php"> - <InvalidArgument occurrences="1"> - <code>$mountId</code> - </InvalidArgument> - </file> - <file src="apps/files_external/lib/Command/Config.php"> - <InvalidArgument occurrences="1"> - <code>$mountId</code> - </InvalidArgument> - </file> <file src="apps/files_external/lib/Command/Delete.php"> - <InvalidArgument occurrences="2"> - <code>$mountId</code> - <code>$mountId</code> - </InvalidArgument> <NullArgument occurrences="1"> <code>null</code> </NullArgument> @@ -1455,8 +1344,7 @@ <ImplicitToStringCast occurrences="1"> <code>$qb->createNamedParameter($storageIds, IQueryBuilder::PARAM_INT_ARRAY, ':storage_ids')</code> </ImplicitToStringCast> - <InvalidArgument occurrences="2"> - <code>$input->getArgument('mount_id')</code> + <InvalidArgument occurrences="1"> <code>$storage</code> </InvalidArgument> <InvalidReturnStatement occurrences="1"/> @@ -1471,12 +1359,9 @@ </UndefinedInterfaceMethod> </file> <file src="apps/files_external/lib/Command/Verify.php"> - <InvalidArgument occurrences="1"> - <code>$mountId</code> - </InvalidArgument> <InvalidScalarArgument occurrences="2"> - <code>$status</code> <code>$e->getCode()</code> + <code>$status</code> </InvalidScalarArgument> </file> <file src="apps/files_external/lib/Config/ConfigAdapter.php"> @@ -1486,10 +1371,10 @@ </file> <file src="apps/files_external/lib/Controller/StoragesController.php"> <InvalidScalarArgument occurrences="4"> + <code>$e->getCode()</code> + <code>$status</code> <code>$this->service->getVisibilityType()</code> <code>$this->service->getVisibilityType()</code> - <code>$status</code> - <code>$e->getCode()</code> </InvalidScalarArgument> </file> <file src="apps/files_external/lib/Controller/UserGlobalStoragesController.php"> @@ -1516,8 +1401,8 @@ </file> <file src="apps/files_external/lib/Lib/IdentifierTrait.php"> <UndefinedDocblockClass occurrences="2"> - <code>IdentifierTrait</code> <code>$this->deprecateTo</code> + <code>IdentifierTrait</code> </UndefinedDocblockClass> </file> <file src="apps/files_external/lib/Lib/LegacyDependencyCheckPolyfill.php"> @@ -1546,10 +1431,6 @@ </ParamNameMismatch> </file> <file src="apps/files_external/lib/Lib/Storage/SFTPReadStream.php"> - <FalsableReturnStatement occurrences="2"> - <code>false</code> - <code>false</code> - </FalsableReturnStatement> <InvalidArgument occurrences="2"> <code>$this->handle</code> <code>$this->handle</code> @@ -1568,11 +1449,6 @@ </InvalidReturnType> </file> <file src="apps/files_external/lib/Lib/Storage/SFTPWriteStream.php"> - <FalsableReturnStatement occurrences="3"> - <code>false</code> - <code>false</code> - <code>false</code> - </FalsableReturnStatement> <InvalidArgument occurrences="2"> <code>$this->handle</code> <code>$this->handle</code> @@ -1591,9 +1467,6 @@ </InvalidReturnType> </file> <file src="apps/files_external/lib/Lib/Storage/SMB.php"> - <FalsableReturnStatement occurrences="1"> - <code>false</code> - </FalsableReturnStatement> <InvalidArgument occurrences="1"> <code>$files</code> </InvalidArgument> @@ -1643,10 +1516,10 @@ </file> <file src="apps/files_external/lib/MountConfig.php"> <InternalMethod occurrences="4"> - <code>setIV</code> + <code>decrypt</code> <code>encrypt</code> <code>setIV</code> - <code>decrypt</code> + <code>setIV</code> </InternalMethod> <InvalidNullableReturnType occurrences="1"> <code>string</code> @@ -1709,12 +1582,6 @@ <code>$_</code> </UndefinedVariable> </file> - <file src="apps/files_sharing/lib/AppInfo/Application.php"> - <UndefinedClass occurrences="2"> - <code>'ExternalMountProvider'</code> - <code>'\OCP\Collaboration\Resources::loadAdditionalScripts'</code> - </UndefinedClass> - </file> <file src="apps/files_sharing/lib/Cache.php"> <FalsableReturnStatement occurrences="1"> <code>false</code> @@ -1745,9 +1612,6 @@ </UndefinedInterfaceMethod> </file> <file src="apps/files_sharing/lib/Controller/DeletedShareAPIController.php"> - <UndefinedClass occurrences="1"> - <code>'\OCA\Talk\Share\Helper\DeletedShareAPIController'</code> - </UndefinedClass> <UndefinedDocblockClass occurrences="2"> <code>$this->getRoomShareHelper()</code> <code>\OCA\Talk\Share\Helper\DeletedShareAPIController</code> @@ -1755,15 +1619,15 @@ </file> <file src="apps/files_sharing/lib/Controller/ExternalSharesController.php"> <InvalidArgument occurrences="2"> - <code>'https'</code> <code>'http'</code> + <code>'https'</code> </InvalidArgument> </file> <file src="apps/files_sharing/lib/Controller/ShareAPIController.php"> <InvalidScalarArgument occurrences="3"> - <code>Constants::PERMISSION_ALL</code> <code>$code</code> <code>$code</code> + <code>Constants::PERMISSION_ALL</code> </InvalidScalarArgument> <NullArgument occurrences="1"> <code>null</code> @@ -1771,9 +1635,8 @@ <TypeDoesNotContainType occurrences="1"> <code>$date === false</code> </TypeDoesNotContainType> - <UndefinedClass occurrences="3"> + <UndefinedClass occurrences="2"> <code>\OCA\Circles\Api\v1\Circles</code> - <code>'\OCA\Talk\Share\Helper\ShareAPIController'</code> <code>\OCA\Circles\Api\v1\Circles</code> </UndefinedClass> <UndefinedDocblockClass occurrences="4"> @@ -1785,13 +1648,13 @@ </file> <file src="apps/files_sharing/lib/Controller/ShareController.php"> <InvalidArgument occurrences="2"> - <code>'Share is read-only'</code> <code>$files_list</code> + <code>'Share is read-only'</code> </InvalidArgument> <InvalidScalarArgument occurrences="3"> + <code>$freeSpace</code> <code>$maxUploadFilesize</code> <code>$maxUploadFilesize</code> - <code>$freeSpace</code> </InvalidScalarArgument> <NullArgument occurrences="1"> <code>null</code> @@ -1809,10 +1672,10 @@ </file> <file src="apps/files_sharing/lib/External/Cache.php"> <UndefinedInterfaceMethod occurrences="4"> + <code>$file</code> <code>$result</code> <code>$result</code> <code>$result</code> - <code>$file</code> </UndefinedInterfaceMethod> </file> <file src="apps/files_sharing/lib/External/Manager.php"> @@ -1889,28 +1752,24 @@ </InvalidReturnType> </file> <file src="apps/files_sharing/lib/SharedStorage.php"> - <FalsableReturnStatement occurrences="5"> + <FalsableReturnStatement occurrences="1"> <code>$this->sourceRootInfo</code> - <code>false</code> - <code>false</code> - <code>false</code> - <code>$this->nonMaskedStorage->fopen($this->getUnjailedPath($path), $mode)</code> </FalsableReturnStatement> <InvalidNullableReturnType occurrences="1"> <code>ICacheEntry</code> </InvalidNullableReturnType> <InvalidReturnStatement occurrences="5"> <code>$this->getPermissions($path) & \OCP\Constants::PERMISSION_CREATE</code> - <code>$this->getPermissions($path) & \OCP\Constants::PERMISSION_UPDATE</code> <code>$this->getPermissions($path) & \OCP\Constants::PERMISSION_DELETE</code> <code>$this->getPermissions($path) & \OCP\Constants::PERMISSION_SHARE</code> + <code>$this->getPermissions($path) & \OCP\Constants::PERMISSION_UPDATE</code> <code>new FailedCache()</code> </InvalidReturnStatement> <InvalidReturnType occurrences="4"> <code>isCreatable</code> - <code>isUpdatable</code> <code>isDeletable</code> <code>isSharable</code> + <code>isUpdatable</code> </InvalidReturnType> <NullableReturnStatement occurrences="1"> <code>$this->sourceRootInfo</code> @@ -1935,11 +1794,6 @@ <code>dispatch</code> </TooManyArguments> </file> - <file src="apps/files_trashbin/lib/BackgroundJob/ExpireTrash.php"> - <UndefinedClass occurrences="1"> - <code>'Expiration'</code> - </UndefinedClass> - </file> <file src="apps/files_trashbin/lib/Sabre/AbstractTrash.php"> <InvalidNullableReturnType occurrences="1"> <code>int</code> @@ -1949,9 +1803,6 @@ </NullableReturnStatement> </file> <file src="apps/files_trashbin/lib/Sabre/AbstractTrashFolder.php"> - <ImplementedReturnTypeMismatch occurrences="1"> - <code>ITrash</code> - </ImplementedReturnTypeMismatch> <InvalidReturnStatement occurrences="1"> <code>$entry</code> </InvalidReturnStatement> @@ -1978,9 +1829,6 @@ </UndefinedFunction> </file> <file src="apps/files_trashbin/lib/Sabre/TrashRoot.php"> - <ImplementedReturnTypeMismatch occurrences="1"> - <code>ITrash</code> - </ImplementedReturnTypeMismatch> <InvalidReturnStatement occurrences="1"> <code>$entry</code> </InvalidReturnStatement> @@ -2019,10 +1867,6 @@ <code>$timestamp</code> <code>$timestamp</code> </InvalidScalarArgument> - <UndefinedClass occurrences="2"> - <code>'Expiration'</code> - <code>'Expiration'</code> - </UndefinedClass> </file> <file src="apps/files_versions/appinfo/routes.php"> <InvalidScope occurrences="2"> @@ -2069,17 +1913,8 @@ </TooManyArguments> </file> <file src="apps/lookup_server_connector/lib/BackgroundJobs/RetryJob.php"> - <InvalidArrayOffset occurrences="10"> + <InvalidArrayOffset occurrences="1"> <code>$publicData[IAccountManager::PROPERTY_DISPLAYNAME]['value']</code> - <code>$publicData[IAccountManager::PROPERTY_EMAIL]['value']</code> - <code>$publicData[IAccountManager::PROPERTY_ADDRESS]['value']</code> - <code>$publicData[IAccountManager::PROPERTY_WEBSITE]['value']</code> - <code>$publicData[IAccountManager::PROPERTY_TWITTER]['value']</code> - <code>$publicData[IAccountManager::PROPERTY_PHONE]['value']</code> - <code>$publicData[IAccountManager::PROPERTY_TWITTER]['signature']</code> - <code>$publicData[IAccountManager::PROPERTY_WEBSITE]['signature']</code> - <code>$publicData[IAccountManager::PROPERTY_WEBSITE]['verified']</code> - <code>$publicData[IAccountManager::PROPERTY_TWITTER]['verified']</code> </InvalidArrayOffset> <InvalidScalarArgument occurrences="1"> <code>$this->retries + 1</code> @@ -2092,9 +1927,9 @@ </file> <file src="apps/oauth2/lib/Controller/SettingsController.php"> <UndefinedMagicMethod occurrences="4"> + <code>getClientIdentifier</code> <code>getName</code> <code>getRedirectUri</code> - <code>getClientIdentifier</code> <code>getSecret</code> </UndefinedMagicMethod> </file> @@ -2113,23 +1948,14 @@ <InvalidScalarArgument occurrences="1"> <code>$quota</code> </InvalidScalarArgument> - <RedundantCondition occurrences="1"> - <code>$groupid === null || trim($groupid) === ''</code> - </RedundantCondition> <TypeDoesNotContainNull occurrences="1"> <code>$groupid === null</code> </TypeDoesNotContainNull> - <UndefinedInterfaceMethod occurrences="1"> - <code>getSubAdmin</code> - </UndefinedInterfaceMethod> </file> <file src="apps/settings/lib/AppInfo/Application.php"> <InvalidScalarArgument occurrences="1"> <code>\OC_User::getUser()</code> </InvalidScalarArgument> - <UndefinedClass occurrences="1"> - <code>'ServerContainer'</code> - </UndefinedClass> <UndefinedInterfaceMethod occurrences="1"> <code>getSettingsManager</code> </UndefinedInterfaceMethod> @@ -2146,23 +1972,23 @@ </file> <file src="apps/settings/lib/Controller/CheckSetupController.php"> <InvalidArgument occurrences="3"> + <code>IDBConnection::CHECK_MISSING_COLUMNS_EVENT</code> <code>IDBConnection::CHECK_MISSING_INDEXES_EVENT</code> <code>IDBConnection::CHECK_MISSING_PRIMARY_KEYS_EVENT</code> - <code>IDBConnection::CHECK_MISSING_COLUMNS_EVENT</code> </InvalidArgument> <InvalidOperand occurrences="1"> <code>$lastCronRun</code> </InvalidOperand> <InvalidReturnStatement occurrences="2"> - <code>new DataDisplayResponse('Integrity checker has been disabled. Integrity cannot be verified.')</code> <code>$response</code> + <code>new DataDisplayResponse('Integrity checker has been disabled. Integrity cannot be verified.')</code> </InvalidReturnStatement> <InvalidReturnType occurrences="1"> <code>DataResponse</code> </InvalidReturnType> <InvalidScalarArgument occurrences="2"> - <code>0</code> <code>$lastCronRun</code> + <code>0</code> </InvalidScalarArgument> <TooManyArguments occurrences="3"> <code>dispatch</code> @@ -2172,26 +1998,11 @@ </file> <file src="apps/settings/lib/Controller/MailSettingsController.php"> <InvalidArgument occurrences="3"> - <code>$this->l10n->t('Invalid SMTP password.')</code> <code>$this->l10n->t('A problem occurred while sending the email. Please revise your settings. (Error: %s)', [$e->getMessage()])</code> + <code>$this->l10n->t('Invalid SMTP password.')</code> <code>$this->l10n->t('You need to set your user email before being able to send test emails.')</code> </InvalidArgument> </file> - <file src="apps/settings/lib/Controller/UsersController.php"> - <UndefinedClass occurrences="1"> - <code>'OC\Settings\Users::loadAdditionalScripts'</code> - </UndefinedClass> - </file> - <file src="apps/settings/lib/Hooks.php"> - <InvalidArgument occurrences="1"> - <code>[$user->getEMailAddress() => $user->getDisplayName()]</code> - </InvalidArgument> - </file> - <file src="apps/settings/lib/Mailer/NewUserMailHelper.php"> - <InvalidArgument occurrences="1"> - <code>[$user->getEMailAddress() => $user->getDisplayName()]</code> - </InvalidArgument> - </file> <file src="apps/settings/lib/Settings/Admin/Security.php"> <UndefinedInterfaceMethod occurrences="1"> <code>isReady</code> @@ -2248,9 +2059,9 @@ <code>getSharesInFolder</code> </InvalidReturnType> <InvalidScalarArgument occurrences="4"> + <code>$share->getId()</code> <code>$shareId</code> <code>$shareId</code> - <code>$share->getId()</code> <code>(int)$data['id']</code> </InvalidScalarArgument> </file> @@ -2262,11 +2073,11 @@ </file> <file src="apps/testing/lib/Controller/LockingController.php"> <InvalidScalarArgument occurrences="5"> - <code>$type</code> - <code>$type</code> <code>$this->config->getAppValue('testing', $lock)</code> <code>$this->config->getAppValue('testing', $lock)</code> <code>$this->config->getAppValue('testing', $lock)</code> + <code>$type</code> + <code>$type</code> </InvalidScalarArgument> </file> <file src="apps/theming/lib/Controller/IconController.php"> @@ -2284,8 +2095,8 @@ </file> <file src="apps/theming/lib/IconBuilder.php"> <InvalidScalarArgument occurrences="2"> - <code>$offset_w</code> <code>$offset_h</code> + <code>$offset_w</code> </InvalidScalarArgument> </file> <file src="apps/theming/lib/ImageManager.php"> @@ -2341,8 +2152,8 @@ <code>$newToken</code> </InvalidArgument> <InvalidScalarArgument occurrences="2"> - <code>0</code> <code>$this->timeFactory->getTime()</code> + <code>0</code> </InvalidScalarArgument> </file> <file src="apps/updatenotification/lib/Notification/BackgroundJob.php"> @@ -2350,9 +2161,9 @@ <code>$this->users</code> </InvalidPropertyAssignmentValue> <InvalidScalarArgument occurrences="3"> - <code>0</code> <code>$errors</code> <code>0</code> + <code>0</code> </InvalidScalarArgument> </file> <file src="apps/updatenotification/lib/Notification/Notifier.php"> @@ -2391,36 +2202,29 @@ <code>$record</code> </InvalidArgument> <InvalidReturnStatement occurrences="2"> - <code>$values</code> <code>$uuid</code> + <code>$values</code> </InvalidReturnStatement> <InvalidReturnType occurrences="1"> <code>string[]</code> </InvalidReturnType> - <InvalidScalarArgument occurrences="4"> + <InvalidScalarArgument occurrences="3"> <code>$e->getCode()</code> <code>$key</code> <code>$key</code> - <code>[$attr => $result['values']]</code> </InvalidScalarArgument> <NullArgument occurrences="1"> <code>$cookie</code> </NullArgument> - <RedundantCondition occurrences="5"> - <code>!isset($ldapName[0]) && empty($ldapName[0])</code> - <code>is_null($limit)</code> - <code>!is_null($limit) && (int)$this->connection->ldapPagingSize !== 0</code> + <RedundantCondition occurrences="3"> <code>is_array($result)</code> - <code>$limit === 0 && !empty($this->lastCookie)</code> </RedundantCondition> <TypeDoesNotContainNull occurrences="2"> - <code>is_null($findings)</code> <code>!$attribute === null</code> + <code>is_null($findings)</code> </TypeDoesNotContainNull> - <TypeDoesNotContainType occurrences="3"> - <code>is_array($attr)</code> + <TypeDoesNotContainType occurrences="2"> <code>!is_null($attr) && !is_array($attr)</code> - <code>isset($ldapRecord[$this->connection->$uuidAttr])</code> </TypeDoesNotContainType> </file> <file src="apps/user_ldap/lib/AppInfo/Application.php"> @@ -2454,11 +2258,11 @@ <code>$this->cachedGroupsByMember[$uid]</code> </InvalidArgument> <InvalidPropertyAssignmentValue occurrences="5"> + <code>$this->cachedGroupsByMember</code> + <code>$this->cachedNestedGroups</code> <code>new CappedMemoryCache()</code> <code>new CappedMemoryCache()</code> <code>new CappedMemoryCache()</code> - <code>$this->cachedNestedGroups</code> - <code>$this->cachedGroupsByMember</code> </InvalidPropertyAssignmentValue> <InvalidReturnStatement occurrences="1"> <code>$groupName</code> @@ -2471,8 +2275,8 @@ <code>$groupID</code> </InvalidScalarArgument> <RedundantCondition occurrences="2"> - <code>is_array($list)</code> <code>is_array($groupDNs)</code> + <code>is_array($list)</code> </RedundantCondition> </file> <file src="apps/user_ldap/lib/Helper.php"> @@ -2487,21 +2291,21 @@ </file> <file src="apps/user_ldap/lib/Jobs/CleanUp.php"> <InvalidScalarArgument occurrences="3"> - <code>0</code> <code>$newOffset</code> + <code>0</code> <code>50</code> </InvalidScalarArgument> </file> <file src="apps/user_ldap/lib/Jobs/Sync.php"> <InvalidOperand occurrences="2"> - <code>$lastChange</code> <code>$i</code> + <code>$lastChange</code> </InvalidOperand> <InvalidScalarArgument occurrences="5"> - <code>self::MIN_INTERVAL</code> <code>$interval</code> <code>0</code> <code>0</code> + <code>self::MIN_INTERVAL</code> </InvalidScalarArgument> <MoreSpecificImplementedParamType occurrences="1"> <code>$argument</code> @@ -2523,46 +2327,46 @@ </file> <file src="apps/user_ldap/lib/LDAP.php"> <ImplementedParamTypeMismatch occurrences="22"> + <code>$baseDN</code> + <code>$baseDN</code> <code>$link</code> <code>$link</code> - <code>$result</code> <code>$link</code> <code>$link</code> <code>$link</code> - <code>$result</code> <code>$link</code> - <code>$result</code> <code>$link</code> - <code>$result</code> <code>$link</code> - <code>$result</code> <code>$link</code> <code>$link</code> - <code>$baseDN</code> <code>$link</code> - <code>$baseDN</code> <code>$link</code> <code>$link</code> <code>$link</code> <code>$resource</code> + <code>$result</code> + <code>$result</code> + <code>$result</code> + <code>$result</code> + <code>$result</code> </ImplementedParamTypeMismatch> <InvalidArgument occurrences="1"> <code>$baseDN</code> </InvalidArgument> <LessSpecificImplementedReturnType occurrences="13"> + <code>array|mixed</code> + <code>array|mixed</code> + <code>bool|mixed</code> + <code>bool|mixed</code> <code>bool|mixed</code> - <code>mixed|true</code> <code>mixed</code> <code>mixed</code> - <code>array|mixed</code> - <code>mixed|string</code> - <code>array|mixed</code> <code>mixed</code> <code>mixed</code> <code>mixed</code> - <code>bool|mixed</code> + <code>mixed|string</code> + <code>mixed|true</code> <code>mixed|true</code> - <code>bool|mixed</code> </LessSpecificImplementedReturnType> <UndefinedDocblockClass occurrences="1"> <code>Resource</code> @@ -2614,8 +2418,8 @@ </InvalidReturnType> <InvalidScalarArgument occurrences="3"> <code>$this->getHomePath($ldapEntry[$attr][0])</code> - <code>true</code> <code>1</code> + <code>true</code> </InvalidScalarArgument> </file> <file src="apps/user_ldap/lib/User_LDAP.php"> @@ -2623,9 +2427,9 @@ <code>string|false</code> </ImplementedReturnTypeMismatch> <InvalidScalarArgument occurrences="3"> - <code>$path</code> <code>$limit</code> <code>$offset</code> + <code>$path</code> </InvalidScalarArgument> <MoreSpecificImplementedParamType occurrences="2"> <code>$limit</code> @@ -2635,41 +2439,33 @@ <code>null</code> </NullableReturnStatement> </file> - <file src="apps/user_ldap/lib/User_Proxy.php"> - <FalseOperand occurrences="1"> - <code>$users</code> - </FalseOperand> - </file> <file src="apps/user_ldap/lib/Wizard.php"> <FalsableReturnStatement occurrences="2"> <code>false</code> <code>false</code> </FalsableReturnStatement> <InvalidArgument occurrences="4"> + <code>$attributes</code> <code>$er</code> <code>$er</code> <code>$er</code> - <code>$attributes</code> </InvalidArgument> <InvalidDocblock occurrences="3"> - <code>private function detectGroupMemberAssoc() {</code> <code>private function checkAgentRequirements() {</code> + <code>private function detectGroupMemberAssoc() {</code> <code>private function getAttributeValuesFromEntry($result, $attribute, &$known) {</code> </InvalidDocblock> <InvalidScalarArgument occurrences="8"> <code>$port</code> <code>$port</code> - <code>LDAP_OPT_PROTOCOL_VERSION</code> - <code>LDAP_OPT_REFERRALS</code> <code>LDAP_OPT_NETWORK_TIMEOUT</code> + <code>LDAP_OPT_NETWORK_TIMEOUT</code> + <code>LDAP_OPT_PROTOCOL_VERSION</code> <code>LDAP_OPT_PROTOCOL_VERSION</code> <code>LDAP_OPT_REFERRALS</code> - <code>LDAP_OPT_NETWORK_TIMEOUT</code> + <code>LDAP_OPT_REFERRALS</code> </InvalidScalarArgument> - <RedundantCondition occurrences="2"> - <code>is_array($item['cn'])</code> - <code>!isset($item['cn']) && !is_array($item['cn']) && !isset($item['cn'][0])</code> - </RedundantCondition> + <RedundantCondition occurrences="1"/> <TypeDoesNotContainType occurrences="1"> <code>$total === false</code> </TypeDoesNotContainType> @@ -2686,16 +2482,11 @@ </file> <file src="apps/user_status/lib/Db/UserStatusMapper.php"> <ImplicitToStringCast occurrences="2"> - <code>$qb->createNamedParameter([IUserStatus::ONLINE, IUserStatus::AWAY, IUserStatus::OFFLINE], IQueryBuilder::PARAM_STR_ARRAY)</code> <code>$qb->createNamedParameter($userIds, IQueryBuilder::PARAM_STR_ARRAY)</code> + <code>$qb->createNamedParameter([IUserStatus::ONLINE, IUserStatus::AWAY, IUserStatus::OFFLINE], IQueryBuilder::PARAM_STR_ARRAY)</code> </ImplicitToStringCast> <MoreSpecificImplementedParamType occurrences="1"/> </file> - <file src="apps/user_status/lib/Service/StatusService.php"> - <MismatchingDocblockParamType occurrences="1"> - <code>string|null</code> - </MismatchingDocblockParamType> - </file> <file src="apps/workflowengine/lib/Check/AbstractStringCheck.php"> <NullArgument occurrences="1"> <code>null</code> @@ -2738,11 +2529,6 @@ <InvalidArgument occurrences="1"> <code>$deleted</code> </InvalidArgument> - <InvalidScalarArgument occurrences="3"> - <code>$e->getCode()</code> - <code>$e->getCode()</code> - <code>$e->getCode()</code> - </InvalidScalarArgument> </file> <file src="apps/workflowengine/lib/Entity/File.php"> <InvalidReturnType occurrences="1"> @@ -2754,9 +2540,9 @@ <code>$query->createNamedParameter($checkIds, IQueryBuilder::PARAM_INT_ARRAY)</code> </ImplicitToStringCast> <InvalidArgument occurrences="3"> + <code>IManager::EVENT_NAME_REG_CHECK</code> <code>IManager::EVENT_NAME_REG_ENTITY</code> <code>IManager::EVENT_NAME_REG_OPERATION</code> - <code>IManager::EVENT_NAME_REG_CHECK</code> </InvalidArgument> <InvalidPropertyAssignmentValue occurrences="1"> <code>[]</code> @@ -2787,18 +2573,13 @@ </file> <file src="apps/workflowengine/lib/Service/RuleMatcher.php"> <UndefinedInterfaceMethod occurrences="5"> - <code>isUserScopeEnabled</code> - <code>getOperations</code> <code>getAllConfiguredScopesForOperation</code> - <code>getOperations</code> <code>getChecks</code> + <code>getOperations</code> + <code>getOperations</code> + <code>isUserScopeEnabled</code> </UndefinedInterfaceMethod> </file> - <file src="apps/workflowengine/lib/Settings/ASettings.php"> - <UndefinedClass occurrences="1"> - <code>'OCP\WorkflowEngine::loadAdditionalSettingScripts'</code> - </UndefinedClass> - </file> <file src="apps/workflowengine/lib/Settings/Personal.php"> <InvalidNullableReturnType occurrences="1"> <code>getSection</code> @@ -2833,11 +2614,6 @@ <code>array</code> </LessSpecificImplementedReturnType> </file> - <file src="core/Command/Broadcast/Test.php"> - <UndefinedClass occurrences="1"> - <code>'broadcasttest'</code> - </UndefinedClass> - </file> <file src="core/Command/Config/App/GetConfig.php"> <ImplementedReturnTypeMismatch occurrences="1"> <code>null|int</code> @@ -2893,13 +2669,6 @@ </TooManyArguments> </file> <file src="core/Command/Db/ConvertType.php"> - <InternalMethod occurrences="1"> - <code>setFilterSchemaAssetsExpression</code> - </InternalMethod> - <InvalidArgument occurrences="2"> - <code>$chunkSize</code> - <code>$chunk * $chunkSize</code> - </InvalidArgument> <InvalidScalarArgument occurrences="2"> <code>0</code> <code>1</code> @@ -2976,16 +2745,16 @@ <file src="core/Command/Upgrade.php"> <InvalidScalarArgument occurrences="11"> <code>0</code> - <code>1</code> - <code>1</code> - <code>1</code> <code>0</code> - <code>1</code> <code>0</code> <code>0</code> <code>0</code> <code>0</code> <code>0</code> + <code>1</code> + <code>1</code> + <code>1</code> + <code>1</code> </InvalidScalarArgument> <UndefinedThisPropertyAssignment occurrences="1"> <code>$this->installer</code> @@ -2994,11 +2763,6 @@ <code>$this->installer</code> </UndefinedThisPropertyFetch> </file> - <file src="core/Command/User/Setting.php"> - <InvalidScalarArgument occurrences="1"> - <code>$input->getOption('default-value')</code> - </InvalidScalarArgument> - </file> <file src="core/Controller/AppPasswordController.php"> <InvalidArgument occurrences="1"> <code>'app_password_created'</code> @@ -3016,13 +2780,7 @@ </TooManyArguments> </file> <file src="core/Controller/ClientFlowLoginV2Controller.php"> - <RedundantCondition occurrences="2"> - <code>!is_string($stateToken) || !is_string($currentToken)</code> - <code>is_string($stateToken)</code> - </RedundantCondition> - <TypeDoesNotContainType occurrences="1"> - <code>is_string($stateToken)</code> - </TypeDoesNotContainType> + <TypeDoesNotContainType occurrences="1"/> </file> <file src="core/Controller/CollaborationResourcesController.php"> <UndefinedInterfaceMethod occurrences="1"> @@ -3055,17 +2813,17 @@ <file src="core/ajax/update.php"> <InvalidScalarArgument occurrences="12"> <code>0</code> - <code>1</code> <code>0</code> - <code>1</code> <code>0</code> - <code>1</code> <code>0</code> - <code>1</code> <code>0</code> <code>0</code> <code>0</code> <code>0</code> + <code>1</code> + <code>1</code> + <code>1</code> + <code>1</code> </InvalidScalarArgument> </file> <file src="core/register_command.php"> @@ -3087,8 +2845,8 @@ </file> <file src="lib/base.php"> <InternalMethod occurrences="2"> - <code>getIncompatibleApps</code> <code>getAppsNeedingUpgrade</code> + <code>getIncompatibleApps</code> </InternalMethod> <InvalidArgument occurrences="1"> <code>$restrictions</code> @@ -3128,9 +2886,9 @@ </file> <file src="lib/private/App/AppManager.php"> <InvalidArgument occurrences="3"> + <code>ManagerEvent::EVENT_APP_DISABLE</code> <code>ManagerEvent::EVENT_APP_ENABLE</code> <code>ManagerEvent::EVENT_APP_ENABLE_FOR_GROUPS</code> - <code>ManagerEvent::EVENT_APP_DISABLE</code> </InvalidArgument> <LessSpecificImplementedReturnType occurrences="2"> <code>array</code> @@ -3232,9 +2990,6 @@ <code>\OCP\IServerContainer</code> <code>mixed</code> </InvalidReturnType> - <UndefinedClass occurrences="1"> - <code>'AppName'</code> - </UndefinedClass> <UndefinedInterfaceMethod occurrences="1"> <code>getAppDataDir</code> </UndefinedInterfaceMethod> @@ -3261,18 +3016,16 @@ </InvalidReturnType> </file> <file src="lib/private/AppFramework/Http/Request.php"> - <NullableReturnStatement occurrences="11"> - <code>$this->server[$name]</code> - <code>$this->method</code> - <code>isset($this->files[$key]) ? $this->files[$key] : null</code> - <code>isset($this->env[$key]) ? $this->env[$key] : null</code> - <code>isset($this->cookies[$key]) ? $this->cookies[$key] : null</code> - <code>$this->server['UNIQUE_ID']</code> - <code>$remoteAddress</code> - <code>$uri</code> + <NullableReturnStatement occurrences="9"> + <code>$host</code> <code>$name</code> + <code>$remoteAddress</code> <code>$this->getOverwriteHost()</code> - <code>$host</code> + <code>$this->method</code> + <code>$uri</code> + <code>isset($this->cookies[$key]) ? $this->cookies[$key] : null</code> + <code>isset($this->env[$key]) ? $this->env[$key] : null</code> + <code>isset($this->files[$key]) ? $this->files[$key] : null</code> </NullableReturnStatement> <RedundantCondition occurrences="1"> <code>\is_array($params)</code> @@ -3308,7 +3061,7 @@ <InvalidScalarArgument occurrences="1"> <code>$exception->getCode()</code> </InvalidScalarArgument> - <NoInterfaceProperties occurrences="3"> + <NoInterfaceProperties occurrences="2"> <code>$this->request->server</code> <code>$this->request->server</code> <code>$this->request->server</code> @@ -3316,12 +3069,12 @@ </file> <file src="lib/private/AppFramework/Middleware/Security/RateLimitingMiddleware.php"> <InvalidScalarArgument occurrences="6"> - <code>$userLimit</code> - <code>$userPeriod</code> <code>$anonLimit</code> <code>$anonPeriod</code> <code>$exception->getCode()</code> <code>$exception->getCode()</code> + <code>$userLimit</code> + <code>$userPeriod</code> </InvalidScalarArgument> </file> <file src="lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php"> @@ -3350,9 +3103,6 @@ <InvalidArrayOffset occurrences="1"> <code>$action['url-postfix']</code> </InvalidArrayOffset> - <RedundantCondition occurrences="1"> - <code>strtolower</code> - </RedundantCondition> </file> <file src="lib/private/AppFramework/Services/AppConfig.php"> <MoreSpecificImplementedParamType occurrences="1"> @@ -3380,26 +3130,24 @@ </ImplementedReturnTypeMismatch> </file> <file src="lib/private/Authentication/LoginCredentials/Store.php"> - <RedundantCondition occurrences="1"> - <code>$trySession && $this->session->exists('login_credentials')</code> - </RedundantCondition> + <RedundantCondition occurrences="1"/> </file> <file src="lib/private/Authentication/Token/DefaultToken.php"> <UndefinedMethod occurrences="14"> + <code>parent::getExpires()</code> + <code>parent::getLastCheck()</code> <code>parent::getLoginName()</code> + <code>parent::getName()</code> <code>parent::getPassword()</code> - <code>parent::getLastCheck()</code> - <code>parent::setLastCheck($time)</code> + <code>parent::getRemember()</code> <code>parent::getScope()</code> - <code>parent::setScope(json_encode($scope))</code> - <code>parent::setScope((string)$scope)</code> - <code>parent::getName()</code> + <code>parent::setExpires($expires)</code> + <code>parent::setLastCheck($time)</code> <code>parent::setName($name)</code> - <code>parent::getRemember()</code> - <code>parent::setToken($token)</code> <code>parent::setPassword($password)</code> - <code>parent::setExpires($expires)</code> - <code>parent::getExpires()</code> + <code>parent::setScope((string)$scope)</code> + <code>parent::setScope(json_encode($scope))</code> + <code>parent::setToken($token)</code> </UndefinedMethod> </file> <file src="lib/private/Authentication/Token/DefaultTokenProvider.php"> @@ -3409,21 +3157,21 @@ </file> <file src="lib/private/Authentication/Token/PublicKeyToken.php"> <UndefinedMethod occurrences="16"> + <code>parent::getExpires()</code> + <code>parent::getLastCheck()</code> <code>parent::getLoginName()</code> + <code>parent::getName()</code> <code>parent::getPassword()</code> - <code>parent::getLastCheck()</code> - <code>parent::setLastCheck($time)</code> + <code>parent::getRemember()</code> <code>parent::getScope()</code> - <code>parent::setScope(json_encode($scope))</code> - <code>parent::setScope((string)$scope)</code> - <code>parent::getName()</code> + <code>parent::setExpires($expires)</code> + <code>parent::setLastCheck($time)</code> <code>parent::setName($name)</code> - <code>parent::getRemember()</code> - <code>parent::setToken($token)</code> <code>parent::setPassword($password)</code> - <code>parent::setExpires($expires)</code> - <code>parent::getExpires()</code> <code>parent::setPasswordInvalid($invalid)</code> + <code>parent::setScope((string)$scope)</code> + <code>parent::setScope(json_encode($scope))</code> + <code>parent::setToken($token)</code> <code>parent::setType(IToken::WIPE_TOKEN)</code> </UndefinedMethod> </file> @@ -3432,15 +3180,15 @@ <code>$providers</code> </InvalidReturnStatement> <InvalidReturnType occurrences="2"> - <code>string[]</code> <code>int[]</code> + <code>string[]</code> </InvalidReturnType> </file> <file src="lib/private/Authentication/TwoFactorAuth/Manager.php"> <InvalidArgument occurrences="3"> - <code>IProvider::EVENT_SUCCESS</code> - <code>IProvider::EVENT_FAILED</code> <code>$tokenId</code> + <code>IProvider::EVENT_FAILED</code> + <code>IProvider::EVENT_SUCCESS</code> </InvalidArgument> <InvalidReturnStatement occurrences="1"> <code>$providerStates</code> @@ -3449,9 +3197,9 @@ <code>string[]</code> </InvalidReturnType> <InvalidScalarArgument occurrences="3"> - <code>$tokenId</code> - <code>$token->getId()</code> <code>$this->timeFactory->getTime()</code> + <code>$token->getId()</code> + <code>$tokenId</code> </InvalidScalarArgument> <TooManyArguments occurrences="2"> <code>dispatch</code> @@ -3463,8 +3211,8 @@ <code>$this->providers</code> </InvalidArgument> <InvalidPropertyAssignmentValue occurrences="2"> - <code>[]</code> <code>$this->providers</code> + <code>[]</code> </InvalidPropertyAssignmentValue> <InvalidReturnStatement occurrences="1"> <code>$this->providers</code> @@ -3505,9 +3253,9 @@ <code>ISimpleFile</code> </ImplementedReturnTypeMismatch> <InvalidScalarArgument occurrences="3"> - <code>(int) $this->config->getUserValue($this->user->getUID(), 'avatar', 'version', 0) + 1</code> <code>$data</code> <code>$data</code> + <code>(int) $this->config->getUserValue($this->user->getUID(), 'avatar', 'version', 0) + 1</code> </InvalidScalarArgument> </file> <file src="lib/private/BackgroundJob/JobList.php"> @@ -3571,11 +3319,6 @@ <code>null</code> </NullArgument> </file> - <file src="lib/private/Config.php"> - <TypeDoesNotContainType occurrences="1"> - <code>$needsUpdate</code> - </TypeDoesNotContainType> - </file> <file src="lib/private/Console/Application.php"> <InvalidArgument occurrences="1"> <code>ConsoleEvent::EVENT_RUN</code> @@ -3633,9 +3376,9 @@ </file> <file src="lib/private/ContactsManager.php"> <InvalidNullableReturnType occurrences="3"> - <code>bool</code> - <code>array</code> <code>IAddressBook</code> + <code>array</code> + <code>bool</code> </InvalidNullableReturnType> <NullableReturnStatement occurrences="5"> <code>null</code> @@ -3653,44 +3396,28 @@ <code>int</code> </InvalidReturnType> </file> - <file src="lib/private/DB/AdapterPgSql.php"> - <FalsableReturnStatement occurrences="1"> - <code>$this->conn->fetchColumn('SELECT lastval()')</code> - </FalsableReturnStatement> - </file> <file src="lib/private/DB/Connection.php"> <ImplementedReturnTypeMismatch occurrences="1"> <code>string</code> </ImplementedReturnTypeMismatch> <InvalidReturnStatement occurrences="2"> - <code>$this->adapter->lastInsertId($seqName)</code> <code>$insertQb->execute()</code> + <code>$this->adapter->lastInsertId($seqName)</code> </InvalidReturnStatement> <InvalidReturnType occurrences="2"> - <code>string</code> <code>int</code> + <code>string</code> </InvalidReturnType> - <InvalidScalarArgument occurrences="1"> - <code>$e->getCode()</code> - </InvalidScalarArgument> <ParamNameMismatch occurrences="1"> <code>$statement</code> </ParamNameMismatch> </file> - <file src="lib/private/DB/ConnectionFactory.php"> - <InternalClass occurrences="1"> - <code>new Configuration()</code> - </InternalClass> - </file> <file src="lib/private/DB/MDB2SchemaReader.php"> <InvalidScalarArgument occurrences="1"> <code>$options['default']</code> </InvalidScalarArgument> </file> <file src="lib/private/DB/MDB2SchemaWriter.php"> - <InternalMethod occurrences="1"> - <code>setFilterSchemaAssetsExpression</code> - </InternalMethod> <InvalidScalarArgument occurrences="1"> <code>$column->getLength()</code> </InvalidScalarArgument> @@ -3701,27 +3428,22 @@ <code>$offset</code> </InvalidOperand> <UndefinedThisPropertyAssignment occurrences="4"> - <code>$this->migrationsPath</code> <code>$this->migrationsNamespace</code> - <code>$this->migrationsPath</code> <code>$this->migrationsNamespace</code> + <code>$this->migrationsPath</code> + <code>$this->migrationsPath</code> </UndefinedThisPropertyAssignment> <UndefinedThisPropertyFetch occurrences="4"> - <code>$this->migrationsPath</code> <code>$this->migrationsNamespace</code> <code>$this->migrationsNamespace</code> <code>$this->migrationsPath</code> + <code>$this->migrationsPath</code> </UndefinedThisPropertyFetch> </file> <file src="lib/private/DB/Migrator.php"> - <InternalMethod occurrences="3"> - <code>setFilterSchemaAssetsExpression</code> - <code>setFilterSchemaAssetsExpression</code> - <code>setFilterSchemaAssetsExpression</code> - </InternalMethod> <InvalidArgument occurrences="2"> - <code>'\OC\DB\Migrator::executeSql'</code> <code>'\OC\DB\Migrator::checkTable'</code> + <code>'\OC\DB\Migrator::executeSql'</code> </InvalidArgument> <TooManyArguments occurrences="2"> <code>dispatch</code> @@ -3733,11 +3455,6 @@ <code>$key[0]</code> </InvalidArrayAccess> </file> - <file src="lib/private/DB/PgSqlTools.php"> - <InternalMethod occurrences="1"> - <code>setFilterSchemaAssetsExpression</code> - </InternalMethod> - </file> <file src="lib/private/DB/QueryBuilder/ExpressionBuilder/ExpressionBuilder.php"> <ImplicitToStringCast occurrences="1"> <code>$this->functionBuilder->lower($x)</code> @@ -3901,11 +3618,11 @@ <code>null</code> </NullableReturnStatement> <UndefinedInterfaceMethod occurrences="5"> - <code>$sourceData</code> - <code>$sourceData</code> + <code>$entry</code> <code>$parentData</code> <code>$parentData</code> - <code>$entry</code> + <code>$sourceData</code> + <code>$sourceData</code> </UndefinedInterfaceMethod> </file> <file src="lib/private/Files/Cache/CacheQueryBuilder.php"> @@ -3918,9 +3635,9 @@ <code>[]</code> </InvalidReturnStatement> <InvalidReturnType occurrences="3"> - <code>put</code> - <code>insert</code> <code>getIncomplete</code> + <code>insert</code> + <code>put</code> </InvalidReturnType> </file> <file src="lib/private/Files/Cache/HomeCache.php"> @@ -3931,11 +3648,11 @@ <code>$path</code> </MoreSpecificImplementedParamType> <UndefinedInterfaceMethod occurrences="5"> + <code>$data</code> <code>$entry</code> <code>$entry</code> <code>$entry</code> <code>$filesData</code> - <code>$data</code> </UndefinedInterfaceMethod> </file> <file src="lib/private/Files/Cache/Propagator.php"> @@ -3964,9 +3681,6 @@ <code>$path</code> <code>self::SCAN_RECURSIVE_INCOMPLETE</code> </InvalidScalarArgument> - <TypeDoesNotContainType occurrences="1"> - <code>$data ?? $this->getData($file)</code> - </TypeDoesNotContainType> <UndefinedInterfaceMethod occurrences="1"> <code>$child</code> </UndefinedInterfaceMethod> @@ -4055,30 +3769,30 @@ </ImplicitToStringCast> <InvalidArgument occurrences="1"/> <InvalidReturnType occurrences="2"> - <code>removeUserStorageMount</code> <code>remoteStorageMounts</code> + <code>removeUserStorageMount</code> </InvalidReturnType> <LessSpecificImplementedReturnType occurrences="1"> <code>array</code> </LessSpecificImplementedReturnType> <UndefinedInterfaceMethod occurrences="9"> + <code>$this->cacheInfoCache</code> + <code>$this->cacheInfoCache</code> + <code>$this->cacheInfoCache</code> <code>$this->mountsForUsers</code> <code>$this->mountsForUsers</code> <code>$this->mountsForUsers</code> <code>$this->mountsForUsers</code> <code>$this->mountsForUsers</code> <code>$this->mountsForUsers</code> - <code>$this->cacheInfoCache</code> - <code>$this->cacheInfoCache</code> - <code>$this->cacheInfoCache</code> </UndefinedInterfaceMethod> </file> <file src="lib/private/Files/FileInfo.php"> <UndefinedInterfaceMethod occurrences="4"> - <code>$this->data</code> <code>$data</code> <code>$data</code> <code>$data</code> + <code>$this->data</code> </UndefinedInterfaceMethod> </file> <file src="lib/private/Files/Filesystem.php"> @@ -4132,8 +3846,8 @@ </file> <file src="lib/private/Files/Node/File.php"> <InvalidReturnStatement occurrences="2"> - <code>new NonExistingFile($this->root, $this->view, $path)</code> <code>$this->view->hash($type, $this->path, $raw)</code> + <code>new NonExistingFile($this->root, $this->view, $path)</code> </InvalidReturnStatement> <InvalidReturnType occurrences="2"> <code>string</code> @@ -4152,12 +3866,12 @@ <code>string</code> </InvalidNullableReturnType> <InvalidReturnStatement occurrences="2"> - <code>new NonExistingFolder($this->root, $this->view, $path)</code> <code>$this->root->get($this->getFullPath($path))</code> + <code>new NonExistingFolder($this->root, $this->view, $path)</code> </InvalidReturnStatement> <InvalidReturnType occurrences="2"> - <code>string</code> <code>\OC\Files\Node\Node</code> + <code>string</code> </InvalidReturnType> <MoreSpecificImplementedParamType occurrences="1"> <code>$node</code> @@ -4166,8 +3880,8 @@ <code>null</code> </NullableReturnStatement> <UndefinedInterfaceMethod occurrences="2"> - <code>getUnJailedPath</code> <code>getSourceStorage</code> + <code>getUnJailedPath</code> </UndefinedInterfaceMethod> <UndefinedThisPropertyAssignment occurrences="1"> <code>$this->exists</code> @@ -4175,18 +3889,18 @@ </file> <file src="lib/private/Files/Node/HookConnector.php"> <InvalidArgument occurrences="13"> - <code>'\OCP\Files::preWrite'</code> - <code>'\OCP\Files::postWrite'</code> - <code>'\OCP\Files::preCreate'</code> + <code>'\OCP\Files::postCopy'</code> <code>'\OCP\Files::postCreate'</code> - <code>'\OCP\Files::preDelete'</code> <code>'\OCP\Files::postDelete'</code> - <code>'\OCP\Files::preTouch'</code> - <code>'\OCP\Files::postTouch'</code> - <code>'\OCP\Files::preRename'</code> <code>'\OCP\Files::postRename'</code> + <code>'\OCP\Files::postTouch'</code> + <code>'\OCP\Files::postWrite'</code> <code>'\OCP\Files::preCopy'</code> - <code>'\OCP\Files::postCopy'</code> + <code>'\OCP\Files::preCreate'</code> + <code>'\OCP\Files::preDelete'</code> + <code>'\OCP\Files::preRename'</code> + <code>'\OCP\Files::preTouch'</code> + <code>'\OCP\Files::preWrite'</code> <code>'\OCP\Files::read'</code> </InvalidArgument> <TooManyArguments occurrences="13"> @@ -4236,15 +3950,15 @@ <code>int</code> </InvalidNullableReturnType> <InvalidReturnStatement occurrences="3"> - <code>$this->root->get($newPath)</code> <code>$targetNode</code> <code>$targetNode</code> + <code>$this->root->get($newPath)</code> </InvalidReturnStatement> <InvalidReturnType occurrences="4"> <code>Node</code> - <code>getChecksum</code> <code>\OC\Files\Node\Node</code> <code>\OC\Files\Node\Node</code> + <code>getChecksum</code> </InvalidReturnType> <NullableReturnStatement occurrences="1"> <code>$this->getFileInfo()->getId()</code> @@ -4258,16 +3972,16 @@ </file> <file src="lib/private/Files/Node/Root.php"> <ImplementedReturnTypeMismatch occurrences="2"> - <code>string</code> <code>Node</code> + <code>string</code> </ImplementedReturnTypeMismatch> <InvalidNullableReturnType occurrences="7"> - <code>\OC\User\User</code> <code>\OC\Files\Mount\MountPoint</code> - <code>int</code> + <code>\OC\User\User</code> <code>array</code> <code>int</code> <code>int</code> + <code>int</code> <code>string</code> </InvalidNullableReturnType> <InvalidReturnStatement occurrences="1"> @@ -4277,8 +3991,8 @@ <code>string</code> </InvalidReturnType> <NullableReturnStatement occurrences="7"> - <code>$this->user</code> <code>$this->mountManager->find($mountPoint)</code> + <code>$this->user</code> <code>null</code> <code>null</code> <code>null</code> @@ -4350,11 +4064,6 @@ <code>stream_for($handle)</code> </UndefinedFunction> </file> - <file src="lib/private/Files/ObjectStore/SwiftFactory.php"> - <InvalidArrayOffset occurrences="1"> - <code>$this->params['url']</code> - </InvalidArrayOffset> - </file> <file src="lib/private/Files/Storage/Common.php"> <ImplementedReturnTypeMismatch occurrences="1"> <code>string|false</code> @@ -4374,10 +4083,10 @@ <NoInterfaceProperties occurrences="8"> <code>$storage->cache</code> <code>$storage->cache</code> - <code>$storage->scanner</code> - <code>$storage->scanner</code> <code>$storage->propagator</code> <code>$storage->propagator</code> + <code>$storage->scanner</code> + <code>$storage->scanner</code> <code>$storage->updater</code> <code>$storage->updater</code> </NoInterfaceProperties> @@ -4418,12 +4127,12 @@ </file> <file src="lib/private/Files/Storage/FailedStorage.php"> <InvalidReturnStatement occurrences="2"> - <code>true</code> <code>new FailedCache()</code> + <code>true</code> </InvalidReturnStatement> <InvalidReturnType occurrences="2"> - <code>verifyPath</code> <code>getCache</code> + <code>verifyPath</code> </InvalidReturnType> <InvalidScalarArgument occurrences="39"> <code>$this->e->getCode()</code> @@ -4468,17 +4177,11 @@ </InvalidScalarArgument> </file> <file src="lib/private/Files/Storage/Flysystem.php"> - <InvalidReturnStatement occurrences="1"> - <code>$this->flysystem->getTimestamp($this->buildPath($path))</code> - </InvalidReturnStatement> - <InvalidReturnType occurrences="1"> - <code>filemtime</code> - </InvalidReturnType> <ParamNameMismatch occurrences="4"> <code>$source</code> - <code>$target</code> <code>$source</code> <code>$target</code> + <code>$target</code> </ParamNameMismatch> </file> <file src="lib/private/Files/Storage/Local.php"> @@ -4487,20 +4190,19 @@ </ImplicitToStringCast> <InvalidReturnStatement occurrences="3"> <code>$helper->getFileSize($fullPath)</code> - <code>file_put_contents($this->getSourcePath($path), $data)</code> <code>$space</code> </InvalidReturnStatement> <InvalidReturnType occurrences="3"> - <code>filesize</code> <code>file_put_contents</code> + <code>filesize</code> <code>free_space</code> </InvalidReturnType> <NullableReturnStatement occurrences="1"> <code>$helper->getFileSize($fullPath)</code> </NullableReturnStatement> <TypeDoesNotContainNull occurrences="2"> - <code>is_null($space)</code> <code>$space === false || is_null($space)</code> + <code>is_null($space)</code> </TypeDoesNotContainNull> <TypeDoesNotContainType occurrences="1"> <code>$stat === false</code> @@ -4514,68 +4216,45 @@ </file> <file src="lib/private/Files/Storage/Wrapper/Availability.php"> <InvalidNullableReturnType occurrences="33"> - <code>mkdir</code> - <code>rmdir</code> - <code>opendir</code> - <code>is_dir</code> - <code>is_file</code> - <code>stat</code> - <code>filesize</code> - <code>isCreatable</code> - <code>isReadable</code> - <code>isUpdatable</code> - <code>isDeletable</code> - <code>isSharable</code> - <code>getPermissions</code> + <code>copy</code> + <code>copyFromStorage</code> <code>file_exists</code> - <code>filemtime</code> <code>file_get_contents</code> <code>file_put_contents</code> - <code>unlink</code> - <code>rename</code> - <code>copy</code> + <code>filemtime</code> + <code>filesize</code> <code>fopen</code> - <code>getMimeType</code> - <code>hash</code> <code>free_space</code> - <code>search</code> - <code>touch</code> + <code>getDirectDownload</code> + <code>getETag</code> <code>getLocalFile</code> - <code>hasUpdated</code> + <code>getMimeType</code> <code>getOwner</code> - <code>getETag</code> - <code>getDirectDownload</code> - <code>copyFromStorage</code> + <code>getPermissions</code> + <code>hasUpdated</code> + <code>hash</code> + <code>isCreatable</code> + <code>isDeletable</code> + <code>isReadable</code> + <code>isSharable</code> + <code>isUpdatable</code> + <code>is_dir</code> + <code>is_file</code> + <code>mkdir</code> <code>moveFromStorage</code> + <code>opendir</code> + <code>rename</code> + <code>rmdir</code> + <code>search</code> + <code>stat</code> + <code>touch</code> + <code>unlink</code> </InvalidNullableReturnType> <InvalidReturnType occurrences="1"> <code>\Traversable</code> </InvalidReturnType> </file> <file src="lib/private/Files/Storage/Wrapper/Encoding.php"> - <FalsableReturnStatement occurrences="12"> - <code>$this->storage->opendir($this->findPathToUse($path))</code> - <code>$this->storage->stat($this->findPathToUse($path))</code> - <code>$this->storage->filesize($this->findPathToUse($path))</code> - <code>$this->storage->filemtime($this->findPathToUse($path))</code> - <code>$this->storage->file_get_contents($this->findPathToUse($path))</code> - <code>$result</code> - <code>$this->storage->getMimeType($this->findPathToUse($path))</code> - <code>$this->storage->hash($type, $this->findPathToUse($path), $raw)</code> - <code>$this->storage->free_space($this->findPathToUse($path))</code> - <code>$this->storage->search($query)</code> - <code>$this->storage->getLocalFile($this->findPathToUse($path))</code> - <code>$this->storage->getETag($this->findPathToUse($path))</code> - </FalsableReturnStatement> - <ImplementedReturnTypeMismatch occurrences="1"> - <code>bool</code> - </ImplementedReturnTypeMismatch> - <InvalidReturnStatement occurrences="1"> - <code>$this->storage->filetype($this->findPathToUse($path))</code> - </InvalidReturnStatement> - <InvalidReturnType occurrences="1"> - <code>bool</code> - </InvalidReturnType> <UndefinedInterfaceMethod occurrences="13"> <code>$this->namesCache</code> <code>$this->namesCache</code> @@ -4593,23 +4272,16 @@ </UndefinedInterfaceMethod> </file> <file src="lib/private/Files/Storage/Wrapper/Encryption.php"> - <FalsableReturnStatement occurrences="5"> - <code>$this->storage->filesize($path)</code> + <FalsableReturnStatement occurrences="1"> <code>false</code> - <code>$this->storage->file_get_contents($path)</code> - <code>$this->storage->getLocalFile($path)</code> - <code>$stat</code> </FalsableReturnStatement> - <ImplementedReturnTypeMismatch occurrences="1"> - <code>resource|bool</code> - </ImplementedReturnTypeMismatch> <InvalidArgument occurrences="2"> <code>$source</code> <code>$target</code> </InvalidArgument> <InvalidReturnStatement occurrences="2"> - <code>$written</code> <code>$newUnencryptedSize</code> + <code>$written</code> </InvalidReturnStatement> <InvalidReturnType occurrences="2"> <code>bool</code> @@ -4620,33 +4292,16 @@ <code>$newUnencryptedSize</code> </InvalidScalarArgument> <UndefinedInterfaceMethod occurrences="7"> + <code>$entry</code> <code>$info</code> <code>$info</code> <code>$info</code> - <code>$entry</code> - <code>$sourceStorage->getCache()->get($sourceInternalPath)</code> <code>$info</code> <code>$info</code> + <code>$sourceStorage->getCache()->get($sourceInternalPath)</code> </UndefinedInterfaceMethod> </file> <file src="lib/private/Files/Storage/Wrapper/Jail.php"> - <FalsableReturnStatement occurrences="12"> - <code>$this->getWrapperStorage()->opendir($this->getUnjailedPath($path))</code> - <code>$this->getWrapperStorage()->stat($this->getUnjailedPath($path))</code> - <code>$this->getWrapperStorage()->filesize($this->getUnjailedPath($path))</code> - <code>$this->getWrapperStorage()->filemtime($this->getUnjailedPath($path))</code> - <code>$this->getWrapperStorage()->file_get_contents($this->getUnjailedPath($path))</code> - <code>$this->getWrapperStorage()->fopen($this->getUnjailedPath($path), $mode)</code> - <code>$this->getWrapperStorage()->getMimeType($this->getUnjailedPath($path))</code> - <code>$this->getWrapperStorage()->hash($type, $this->getUnjailedPath($path), $raw)</code> - <code>$this->getWrapperStorage()->free_space($this->getUnjailedPath($path))</code> - <code>$this->getWrapperStorage()->search($query)</code> - <code>$this->getWrapperStorage()->getLocalFile($this->getUnjailedPath($path))</code> - <code>$this->getWrapperStorage()->getETag($this->getUnjailedPath($path))</code> - </FalsableReturnStatement> - <ImplementedReturnTypeMismatch occurrences="1"> - <code>bool</code> - </ImplementedReturnTypeMismatch> <InvalidReturnStatement occurrences="1"> <code>$this->getWrapperStorage()->filetype($this->getUnjailedPath($path))</code> </InvalidReturnStatement> @@ -4654,16 +4309,7 @@ <code>bool</code> </InvalidReturnType> </file> - <file src="lib/private/Files/Storage/Wrapper/PermissionsMask.php"> - <FalsableReturnStatement occurrences="1"> - <code>$this->checkMask($permissions) ? parent::fopen($path, $mode) : false</code> - </FalsableReturnStatement> - </file> <file src="lib/private/Files/Storage/Wrapper/Quota.php"> - <FalsableReturnStatement occurrences="2"> - <code>$this->storage->free_space($path)</code> - <code>$source</code> - </FalsableReturnStatement> <InvalidReturnStatement occurrences="1"> <code>$extension === 'part'</code> </InvalidReturnStatement> @@ -4682,39 +4328,14 @@ </UndefinedInterfaceMethod> </file> <file src="lib/private/Files/Storage/Wrapper/Wrapper.php"> - <FalsableReturnStatement occurrences="13"> - <code>$this->getWrapperStorage()->opendir($path)</code> - <code>$this->getWrapperStorage()->stat($path)</code> - <code>$this->getWrapperStorage()->filesize($path)</code> - <code>$this->getWrapperStorage()->filemtime($path)</code> - <code>$this->getWrapperStorage()->file_get_contents($path)</code> - <code>$this->getWrapperStorage()->fopen($path, $mode)</code> - <code>$this->getWrapperStorage()->getMimeType($path)</code> - <code>$this->getWrapperStorage()->hash($type, $path, $raw)</code> - <code>$this->getWrapperStorage()->free_space($path)</code> - <code>$this->getWrapperStorage()->search($query)</code> - <code>$this->getWrapperStorage()->getLocalFile($path)</code> - <code>$this->getWrapperStorage()->getETag($path)</code> - <code>$this->getWrapperStorage()->getDirectDownload($path)</code> - </FalsableReturnStatement> - <ImplementedReturnTypeMismatch occurrences="1"> - <code>bool</code> - </ImplementedReturnTypeMismatch> - <InvalidReturnStatement occurrences="2"> - <code>$this->getWrapperStorage()->filetype($path)</code> + <InvalidReturnStatement occurrences="1"> <code>$this->getWrapperStorage()->test()</code> </InvalidReturnStatement> - <InvalidReturnType occurrences="2"> - <code>bool</code> + <InvalidReturnType occurrences="1"> <code>true</code> </InvalidReturnType> </file> <file src="lib/private/Files/Stream/SeekableHttpStream.php"> - <FalsableReturnStatement occurrences="3"> - <code>false</code> - <code>false</code> - <code>false</code> - </FalsableReturnStatement> <InvalidPropertyAssignmentValue occurrences="2"> <code>$this->current</code> <code>$this->current</code> @@ -4749,8 +4370,8 @@ <code>$mount</code> </InvalidArgument> <InvalidNullableReturnType occurrences="2"> - <code>string</code> <code>\OCP\Files\Mount\IMountPoint</code> + <code>string</code> </InvalidNullableReturnType> <InvalidReturnStatement occurrences="1"> <code>$results</code> @@ -4759,37 +4380,37 @@ <code>\OC\Files\Mount\MountPoint</code> </InvalidReturnType> <InvalidScalarArgument occurrences="3"> + <code>$fileId</code> <code>$mtime</code> <code>$user</code> - <code>$fileId</code> </InvalidScalarArgument> <NullableReturnStatement occurrences="6"> - <code>null</code> + <code>$mount</code> <code>Filesystem::getMountManager()->find($this->getAbsolutePath($path))</code> <code>null</code> <code>null</code> <code>null</code> - <code>$mount</code> + <code>null</code> </NullableReturnStatement> <RedundantCondition occurrences="3"> + <code>$result && in_array('delete', $hooks) and $result</code> <code>$storage1</code> <code>is_resource($source)</code> - <code>$result && in_array('delete', $hooks) and $result</code> </RedundantCondition> <UndefinedDocblockClass occurrences="2"> - <code>[$storage, $internalPath]</code> <code>$storage</code> + <code>[$storage, $internalPath]</code> </UndefinedDocblockClass> <UndefinedInterfaceMethod occurrences="20"> - <code>$data</code> - <code>$data</code> - <code>$data</code> - <code>$data</code> <code>$content</code> <code>$content</code> <code>$content</code> <code>$content</code> <code>$content</code> + <code>$data</code> + <code>$data</code> + <code>$data</code> + <code>$data</code> <code>$rootEntry</code> <code>$rootEntry</code> <code>$rootEntry</code> @@ -4821,12 +4442,12 @@ </file> <file src="lib/private/Group/Group.php"> <InvalidArgument occurrences="6"> - <code>IGroup::class . '::preAddUser'</code> <code>IGroup::class . '::postAddUser'</code> - <code>IGroup::class . '::preRemoveUser'</code> + <code>IGroup::class . '::postDelete'</code> <code>IGroup::class . '::postRemoveUser'</code> + <code>IGroup::class . '::preAddUser'</code> <code>IGroup::class . '::preDelete'</code> - <code>IGroup::class . '::postDelete'</code> + <code>IGroup::class . '::preRemoveUser'</code> </InvalidArgument> <InvalidOperand occurrences="1"> <code>$hide</code> @@ -4844,9 +4465,9 @@ </TooManyArguments> <UndefinedMethod occurrences="4"> <code>addToGroup</code> - <code>removeFromGroup</code> <code>countUsersInGroup</code> <code>deleteGroup</code> + <code>removeFromGroup</code> </UndefinedMethod> </file> <file src="lib/private/Group/Manager.php"> @@ -4856,15 +4477,9 @@ <InvalidOperand occurrences="1"> <code>$groupId</code> </InvalidOperand> - <InvalidReturnStatement occurrences="1"> - <code>$groups</code> - </InvalidReturnStatement> - <InvalidReturnType occurrences="1"> - <code>\OC\Group\Group[]</code> - </InvalidReturnType> <UndefinedInterfaceMethod occurrences="3"> - <code>getGroupDetails</code> <code>createGroup</code> + <code>getGroupDetails</code> <code>isAdmin</code> </UndefinedInterfaceMethod> </file> @@ -4940,9 +4555,9 @@ </file> <file src="lib/private/Lock/DBLockingProvider.php"> <ImplicitToStringCast occurrences="3"> - <code>$query->func()->subtract('lock', $query->createNamedParameter(1))</code> - <code>$builder->func()->subtract('lock', $builder->expr()->literal(1))</code> <code>$builder->createNamedParameter($chunk, IQueryBuilder::PARAM_STR_ARRAY)</code> + <code>$builder->func()->subtract('lock', $builder->expr()->literal(1))</code> + <code>$query->func()->subtract('lock', $query->createNamedParameter(1))</code> </ImplicitToStringCast> </file> <file src="lib/private/Lockdown/Filesystem/NullCache.php"> @@ -4959,16 +4574,16 @@ </file> <file src="lib/private/Lockdown/Filesystem/NullStorage.php"> <InvalidNullableReturnType occurrences="2"> - <code>getPermissions</code> <code>getOwner</code> + <code>getPermissions</code> </InvalidNullableReturnType> <InvalidReturnStatement occurrences="2"> <code>new IteratorDirectory([])</code> <code>new NullCache()</code> </InvalidReturnStatement> <InvalidReturnType occurrences="2"> - <code>opendir</code> <code>getCache</code> + <code>opendir</code> </InvalidReturnType> <NullableReturnStatement occurrences="2"> <code>null</code> @@ -4987,14 +4602,7 @@ </InvalidPropertyAssignmentValue> </file> <file src="lib/private/Log.php"> - <RedundantCondition occurrences="1"> - <code>$request && hash_equals($logCondition['shared_secret'], $logSecretRequest)</code> - </RedundantCondition> - </file> - <file src="lib/private/Log/File.php"> - <RedundantCondition occurrences="1"> - <code>$limit === null ||$entriesCount < $limit</code> - </RedundantCondition> + <RedundantCondition occurrences="1"/> </file> <file src="lib/private/Log/LogDetails.php"> <RedundantCondition occurrences="1"> @@ -5012,24 +4620,16 @@ <code>$failedRecipients</code> </NullableReturnStatement> <UndefinedInterfaceMethod occurrences="3"> + <code>getSubject</code> <code>getSwiftMessage</code> <code>getTo</code> - <code>getSubject</code> </UndefinedInterfaceMethod> </file> <file src="lib/private/Memcache/APCu.php"> - <InvalidReturnStatement occurrences="5"> - <code>apcu_store($this->getPrefix() . $key, $value, $ttl)</code> - <code>apcu_exists($this->getPrefix() . $key)</code> - <code>apcu_delete($this->getPrefix() . $key)</code> - <code>apcu_delete($iter)</code> + <InvalidReturnStatement occurrences="1"> <code>apcu_add($this->getPrefix() . $key, $value, $ttl)</code> </InvalidReturnStatement> - <InvalidReturnType occurrences="5"> - <code>set</code> - <code>hasKey</code> - <code>remove</code> - <code>clear</code> + <InvalidReturnType occurrences="1"> <code>bool</code> </InvalidReturnType> </file> @@ -5041,18 +4641,10 @@ <code>mixed</code> </LessSpecificImplementedReturnType> </file> - <file src="lib/private/Memcache/Factory.php"> - <RedundantCondition occurrences="1"> - <code>$lockingCacheClass && class_exists($distributedCacheClass) && $lockingCacheClass::isAvailable()</code> - </RedundantCondition> - </file> <file src="lib/private/Memcache/Memcached.php"> <RedundantCondition occurrences="1"> <code>method_exists(self::$cache, 'deleteMulti')</code> </RedundantCondition> - <TypeDoesNotContainType occurrences="1"> - <code>\Memcached::HAVE_IGBINARY</code> - </TypeDoesNotContainType> </file> <file src="lib/private/Memcache/Redis.php"> <InvalidMethodCall occurrences="2"> @@ -5065,12 +4657,6 @@ <code>$jobList</code> </MoreSpecificImplementedParamType> </file> - <file src="lib/private/Notification/Manager.php"> - <RedundantCondition occurrences="2"> - <code>!($notification instanceof INotification) || !$notification->isValidParsed()</code> - <code>!($notification instanceof INotification) || !$notification->isValidParsed()</code> - </RedundantCondition> - </file> <file src="lib/private/Preview/BackgroundCleanupJob.php"> <InvalidReturnStatement occurrences="1"> <code>[]</code> @@ -5083,8 +4669,8 @@ </file> <file src="lib/private/Preview/Generator.php"> <InvalidArgument occurrences="2"> - <code>IPreview::EVENT</code> <code>$maxPreviewImage</code> + <code>IPreview::EVENT</code> </InvalidArgument> <InvalidNullableReturnType occurrences="1"> <code>ISimpleFile</code> @@ -5103,13 +4689,13 @@ <code>dispatch</code> </TooManyArguments> <UndefinedInterfaceMethod occurrences="7"> - <code>valid</code> <code>height</code> - <code>width</code> - <code>width</code> <code>height</code> <code>preciseResizeCopy</code> <code>resizeCopy</code> + <code>valid</code> + <code>width</code> + <code>width</code> </UndefinedInterfaceMethod> </file> <file src="lib/private/Preview/GeneratorHelper.php"> @@ -5149,11 +4735,6 @@ <code>?IImage</code> </InvalidReturnType> </file> - <file src="lib/private/Preview/ProviderV2.php"> - <FalsableReturnStatement occurrences="1"> - <code>$file->getStorage()->getLocalFile($file->getInternalPath())</code> - </FalsableReturnStatement> - </file> <file src="lib/private/Preview/SVG.php"> <ImplicitToStringCast occurrences="1"> <code>$svg</code> @@ -5167,8 +4748,8 @@ </file> <file src="lib/private/RedisFactory.php"> <InvalidPropertyAssignmentValue occurrences="2"> - <code>new \RedisCluster(null, $config['seeds'], $timeout, $readTimeout, false, $config['password'])</code> <code>new \RedisCluster(null, $config['seeds'], $timeout, $readTimeout)</code> + <code>new \RedisCluster(null, $config['seeds'], $timeout, $readTimeout, false, $config['password'])</code> </InvalidPropertyAssignmentValue> <InvalidScalarArgument occurrences="1"> <code>\RedisCluster::OPT_SLAVE_FAILOVER</code> @@ -5200,15 +4781,15 @@ </file> <file src="lib/private/Repair/CleanTags.php"> <ImplicitToStringCast occurrences="2"> - <code>$query->createNamedParameter($users, IQueryBuilder::PARAM_STR_ARRAY)</code> <code>$qb->createParameter('ids')</code> + <code>$query->createNamedParameter($users, IQueryBuilder::PARAM_STR_ARRAY)</code> </ImplicitToStringCast> </file> <file src="lib/private/Repair/RemoveLinkShares.php"> <ImplicitToStringCast occurrences="3"> - <code>$subQuery->createFunction('(' . $subSubQuery->getSQL() . ')')</code> <code>$query->createFunction('(' . $subQuery->getSQL() . ')')</code> <code>$query->createFunction('(' . $subQuery->getSQL() . ')')</code> + <code>$subQuery->createFunction('(' . $subSubQuery->getSQL() . ')')</code> </ImplicitToStringCast> <InvalidPropertyAssignmentValue occurrences="1"> <code>$this->userToNotify</code> @@ -5247,8 +4828,8 @@ <file src="lib/private/Search/Result/File.php"> <InvalidPropertyAssignmentValue occurrences="4"> <code>$data->getId()</code> - <code>$data->getPermissions()</code> <code>$data->getMtime()</code> + <code>$data->getPermissions()</code> <code>$this->hasPreview($data)</code> </InvalidPropertyAssignmentValue> </file> @@ -5286,12 +4867,12 @@ </file> <file src="lib/private/Security/Crypto.php"> <InternalMethod occurrences="6"> - <code>setPassword</code> - <code>setIV</code> + <code>decrypt</code> <code>encrypt</code> - <code>setPassword</code> <code>setIV</code> - <code>decrypt</code> + <code>setIV</code> + <code>setPassword</code> + <code>setPassword</code> </InternalMethod> </file> <file src="lib/private/Server.php"> @@ -5300,9 +4881,6 @@ <code>\OCP\Calendar\Room\IManager</code> <code>\OCP\Files\Folder|null</code> </ImplementedReturnTypeMismatch> - <InternalMethod occurrences="1"> - <code>setSQLLogger</code> - </InternalMethod> <InvalidArgument occurrences="1"> <code>'OCP\IUser::preDelete'</code> </InvalidArgument> @@ -5316,21 +4894,6 @@ <TooManyArguments occurrences="1"> <code>dispatch</code> </TooManyArguments> - <UndefinedClass occurrences="13"> - <code>'SystemTagManagerFactory'</code> - <code>'SystemTagManagerFactory'</code> - <code>'RootFolder'</code> - <code>'EncryptionFileHelper'</code> - <code>'EncryptionKeyStorage'</code> - <code>'RedisFactory'</code> - <code>'OcsClient'</code> - <code>'AsyncCommandBus'</code> - <code>'ThemingDefaults'</code> - <code>'IntegrityCodeChecker'</code> - <code>'CryptoWrapper'</code> - <code>'LDAPProvider'</code> - <code>'LockdownManager'</code> - </UndefinedClass> <UndefinedDocblockClass occurrences="1"> <code>\OC\OCSClient</code> </UndefinedDocblockClass> @@ -5392,9 +4955,9 @@ <code>!self::isResharingAllowed()</code> </InvalidOperand> <InvalidScalarArgument occurrences="3"> - <code>\OC_User::getUser()</code> <code>$shareWith</code> <code>\OC_User::getUser()</code> + <code>\OC_User::getUser()</code> </InvalidScalarArgument> <UndefinedInterfaceMethod occurrences="2"> <code>getParents</code> @@ -5403,10 +4966,10 @@ </file> <file src="lib/private/Share20/DefaultShareProvider.php"> <ImplicitToStringCast occurrences="7"> - <code>$qb->createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code> <code>$qb->createNamedParameter($chunk, IQueryBuilder::PARAM_INT_ARRAY)</code> <code>$qb->createNamedParameter($chunk, IQueryBuilder::PARAM_INT_ARRAY)</code> <code>$qb->createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code> + <code>$qb->createNamedParameter($ids, IQueryBuilder::PARAM_INT_ARRAY)</code> </ImplicitToStringCast> <InvalidReturnStatement occurrences="1"> <code>$shares</code> @@ -5429,26 +4992,26 @@ <file src="lib/private/Share20/Manager.php"> <NullArgument occurrences="1"/> <InvalidArgument occurrences="7"> - <code>'OCP\Share::preShare'</code> - <code>'OCP\Share::postShare'</code> + <code>$data</code> <code>'OCP\Share::postAcceptShare'</code> - <code>'OCP\Share::preUnshare'</code> + <code>'OCP\Share::postShare'</code> <code>'OCP\Share::postUnshare'</code> <code>'OCP\Share::postUnshareFromSelf'</code> - <code>$data</code> + <code>'OCP\Share::preShare'</code> + <code>'OCP\Share::preUnshare'</code> </InvalidArgument> <InvalidScalarArgument occurrences="2"> - <code>$this->shareApiLinkDefaultExpireDays()</code> <code>$id</code> + <code>$this->shareApiLinkDefaultExpireDays()</code> </InvalidScalarArgument> <TooManyArguments occurrences="7"> <code>dispatch</code> <code>dispatch</code> - <code>update</code> <code>dispatch</code> <code>dispatch</code> <code>dispatch</code> <code>dispatch</code> + <code>update</code> </TooManyArguments> <UndefinedClass occurrences="1"> <code>\OCA\Circles\Api\v1\Circles</code> @@ -5463,16 +5026,16 @@ <code>ShareByMailProvider</code> </InvalidNullableReturnType> <InvalidReturnStatement occurrences="5"> - <code>$this->shareByCircleProvider</code> - <code>$this->roomShareProvider</code> <code>$provider</code> <code>$provider</code> <code>$shares</code> + <code>$this->roomShareProvider</code> + <code>$this->shareByCircleProvider</code> </InvalidReturnStatement> <InvalidReturnType occurrences="3"> + <code>getAllProviders</code> <code>getProvider</code> <code>getProviderForType</code> - <code>getAllProviders</code> </InvalidReturnType> <NullableReturnStatement occurrences="6"> <code>null</code> @@ -5482,16 +5045,15 @@ <code>null</code> <code>null</code> </NullableReturnStatement> - <UndefinedClass occurrences="2"> + <UndefinedClass occurrences="1"> <code>\OCA\Circles\ShareByCircleProvider</code> - <code>'\OCA\Talk\Share\RoomShareProvider'</code> </UndefinedClass> <UndefinedDocblockClass occurrences="5"> + <code>RoomShareProvider</code> <code>\OCA\Circles\ShareByCircleProvider</code> <code>\OCA\Talk\Share\RoomShareProvider</code> - <code>RoomShareProvider</code> - <code>private $shareByCircleProvider = null;</code> <code>private $roomShareProvider = null;</code> + <code>private $shareByCircleProvider = null;</code> </UndefinedDocblockClass> <UndefinedInterfaceMethod occurrences="4"> <code>getLazyRootFolder</code> @@ -5516,8 +5078,8 @@ </file> <file src="lib/private/Support/Subscription/Registry.php"> <UndefinedInterfaceMethod occurrences="2"> - <code>getSupportedApps</code> <code>countUsers</code> + <code>getSupportedApps</code> </UndefinedInterfaceMethod> </file> <file src="lib/private/SystemTag/SystemTagManager.php"> @@ -5533,8 +5095,8 @@ </ImplicitToStringCast> <InvalidArgument occurrences="3"> <code>ManagerEvent::EVENT_CREATE</code> - <code>ManagerEvent::EVENT_UPDATE</code> <code>ManagerEvent::EVENT_DELETE</code> + <code>ManagerEvent::EVENT_UPDATE</code> </InvalidArgument> <InvalidReturnType occurrences="2"> <code>bool</code> @@ -5548,10 +5110,10 @@ </file> <file src="lib/private/SystemTag/SystemTagObjectMapper.php"> <ImplicitToStringCast occurrences="4"> - <code>$query->createParameter('objectids')</code> <code>$query->createNamedParameter($tagIds, IQueryBuilder::PARAM_INT_ARRAY)</code> - <code>$query->createParameter('tagids')</code> <code>$query->createParameter('objectids')</code> + <code>$query->createParameter('objectids')</code> + <code>$query->createParameter('tagids')</code> </ImplicitToStringCast> <InvalidArgument occurrences="2"> <code>MapperEvent::EVENT_ASSIGN</code> @@ -5596,16 +5158,13 @@ </file> <file src="lib/private/Template/JSResourceLocator.php"> <InvalidOperand occurrences="6"> - <code>$this->appendIfExist($this->serverroot, 'core/'.$script.'.js')</code> - <code>$this->appendIfExist($this->serverroot, $theme_dir.'core/'.$script.'.js')</code> <code>$this->appendIfExist($this->serverroot, $script.'.js')</code> <code>$this->appendIfExist($this->serverroot, $theme_dir.$script.'.js')</code> - <code>$this->appendIfExist($this->serverroot, 'apps/'.$script.'.js')</code> <code>$this->appendIfExist($this->serverroot, $theme_dir.'apps/'.$script.'.js')</code> + <code>$this->appendIfExist($this->serverroot, $theme_dir.'core/'.$script.'.js')</code> + <code>$this->appendIfExist($this->serverroot, 'apps/'.$script.'.js')</code> + <code>$this->appendIfExist($this->serverroot, 'core/'.$script.'.js')</code> </InvalidOperand> - <TypeDoesNotContainType occurrences="1"> - <code>$found</code> - </TypeDoesNotContainType> </file> <file src="lib/private/Template/SCSSCacher.php"> <InvalidScalarArgument occurrences="1"> @@ -5618,9 +5177,9 @@ <code>string</code> </InvalidParamDefault> <InvalidScalarArgument occurrences="3"> - <code>\OC_User::getUser()</code> <code>$appName</code> <code>$appName</code> + <code>\OC_User::getUser()</code> </InvalidScalarArgument> <TooManyArguments occurrences="1"> <code>Util::addScript('dist/unified-search', null, true)</code> @@ -5638,17 +5197,17 @@ <InvalidScalarArgument occurrences="13"> <code>0</code> <code>0</code> - <code>1</code> <code>0</code> - <code>1</code> - <code>1</code> <code>0</code> - <code>1</code> <code>0</code> <code>0</code> <code>0</code> <code>0</code> <code>0</code> + <code>1</code> + <code>1</code> + <code>1</code> + <code>1</code> </InvalidScalarArgument> <UndefinedMethod occurrences="1"> <code>\OC_DB::simulateUpdateDbFromStructure(\OC_App::getAppPath($appId) . '/appinfo/database.xml')</code> @@ -5656,8 +5215,8 @@ </file> <file src="lib/private/Updater/VersionCheck.php"> <InvalidScalarArgument occurrences="2"> - <code>time()</code> <code>microtime(true)</code> + <code>time()</code> </InvalidScalarArgument> </file> <file src="lib/private/User/Backend.php"> @@ -5699,8 +5258,8 @@ </NullableReturnStatement> <UndefinedInterfaceMethod occurrences="4"> <code>checkPassword</code> - <code>createUser</code> <code>countUsers</code> + <code>createUser</code> <code>getUsersForUserValueCaseInsensitive</code> </UndefinedInterfaceMethod> </file> @@ -5728,11 +5287,11 @@ </file> <file src="lib/private/User/User.php"> <InvalidArgument occurrences="5"> - <code>IUser::class . '::preDelete'</code> + <code>IUser::class . '::changeUser'</code> <code>IUser::class . '::postDelete'</code> - <code>IUser::class . '::preSetPassword'</code> <code>IUser::class . '::postSetPassword'</code> - <code>IUser::class . '::changeUser'</code> + <code>IUser::class . '::preDelete'</code> + <code>IUser::class . '::preSetPassword'</code> </InvalidArgument> <InvalidNullableReturnType occurrences="1"> <code>getBackend</code> @@ -5747,8 +5306,8 @@ <code>IImage|null</code> </InvalidReturnType> <InvalidScalarArgument occurrences="2"> - <code>$this->lastLogin</code> <code>$quota</code> + <code>$this->lastLogin</code> </InvalidScalarArgument> <NullableReturnStatement occurrences="1"> <code>$this->backend</code> @@ -5761,11 +5320,11 @@ <code>dispatch</code> </TooManyArguments> <UndefinedInterfaceMethod occurrences="5"> - <code>setDisplayName</code> + <code>canChangeAvatar</code> <code>deleteUserAvatar</code> - <code>setPassword</code> <code>getHome</code> - <code>canChangeAvatar</code> + <code>setDisplayName</code> + <code>setPassword</code> </UndefinedInterfaceMethod> </file> <file src="lib/private/UserStatus/Manager.php"> @@ -5797,9 +5356,6 @@ <NullableReturnStatement occurrences="1"> <code>null</code> </NullableReturnStatement> - <RedundantCondition occurrences="1"> - <code>$appId === null || trim($appId) === ''</code> - </RedundantCondition> <TooManyArguments occurrences="1"> <code>dispatch</code> </TooManyArguments> @@ -5815,16 +5371,6 @@ <code>OC_DB_StatementWrapper</code> </InvalidReturnType> </file> - <file src="lib/private/legacy/OC_DB_StatementWrapper.php"> - <FalsableReturnStatement occurrences="1"> - <code>$this->statement->fetchColumn($column)</code> - </FalsableReturnStatement> - </file> - <file src="lib/private/legacy/OC_EventSource.php"> - <RedundantCondition occurrences="1"> - <code>$this->fallback</code> - </RedundantCondition> - </file> <file src="lib/private/legacy/OC_FileChunking.php"> <UndefinedDocblockClass occurrences="1"> <code>\OC\InsufficientStorageException</code> @@ -5832,9 +5378,9 @@ </file> <file src="lib/private/legacy/OC_Files.php"> <InvalidArgument occurrences="3"> + <code>$fh</code> <code>$fileInfos</code> <code>[$fileInfo]</code> - <code>$fh</code> </InvalidArgument> <InvalidScalarArgument occurrences="1"> <code>mt_rand()</code> @@ -5859,23 +5405,21 @@ <code>int</code> </InvalidReturnType> <InvalidScalarArgument occurrences="4"> - <code>$path</code> <code>$includeExtStorage ? 'ext' : false</code> + <code>$path</code> <code>$quota</code> <code>'ext'</code> </InvalidScalarArgument> - <RedundantCondition occurrences="1"> - <code>count($obd_values) > 0 and $obd_values[0]</code> - </RedundantCondition> + <RedundantCondition occurrences="1"/> <UndefinedInterfaceMethod occurrences="1"> <code>getSourceStorage</code> </UndefinedInterfaceMethod> </file> <file src="lib/private/legacy/OC_Image.php"> <FalsableReturnStatement occurrences="3"> + <code>$this->resource</code> <code>$this->valid() ? imagesx($this->resource) : -1</code> <code>$this->valid() ? imagesy($this->resource) : -1</code> - <code>$this->resource</code> </FalsableReturnStatement> <ImplementedReturnTypeMismatch occurrences="1"> <code>null|string</code> @@ -5888,8 +5432,6 @@ <code>bool</code> </InvalidReturnType> <InvalidScalarArgument occurrences="17"> - <code>$this->bitDepth</code> - <code>90</code> <code>$imagePath</code> <code>$imagePath</code> <code>$imagePath</code> @@ -5903,15 +5445,15 @@ <code>$imagePath</code> <code>$imagePath</code> <code>$imagePath</code> + <code>$this->bitDepth</code> <code>$x</code> <code>$y</code> + <code>90</code> </InvalidScalarArgument> <MismatchingDocblockReturnType occurrences="1"> <code>bool</code> </MismatchingDocblockReturnType> - <RedundantCondition occurrences="1"> - <code>$isWritable && file_exists($filePath)</code> - </RedundantCondition> + <RedundantCondition occurrences="1"/> </file> <file src="lib/private/legacy/OC_JSON.php"> <InvalidScalarArgument occurrences="1"> @@ -5925,15 +5467,9 @@ </file> <file src="lib/private/legacy/OC_Util.php"> <InternalMethod occurrences="2"> - <code>\OC\Files\Filesystem::logWarningWhenAddingStorageWrapper(false)</code> <code>\OC\Files\Filesystem::logWarningWhenAddingStorageWrapper($prevLogging)</code> + <code>\OC\Files\Filesystem::logWarningWhenAddingStorageWrapper(false)</code> </InternalMethod> - <InvalidOperand occurrences="4"> - <code>$version</code> - <code>$version</code> - <code>$version</code> - <code>$version</code> - </InvalidOperand> <InvalidReturnStatement occurrences="1"> <code>OC_Helper::computerFileSize($userQuota)</code> </InvalidReturnStatement> @@ -5945,23 +5481,18 @@ <code>OC_User::getUser()</code> </InvalidScalarArgument> <RedundantCondition occurrences="2"> - <code>is_string($expected)</code> <code>'off'</code> + <code>is_string($expected)</code> </RedundantCondition> <TypeDoesNotContainType occurrences="3"> <code>is_bool($expected)</code> - <code>is_int($expected)</code> <code>is_bool($setting[1])</code> + <code>is_int($expected)</code> </TypeDoesNotContainType> <UndefinedInterfaceMethod occurrences="1"> <code>clearCache</code> </UndefinedInterfaceMethod> </file> - <file src="lib/private/legacy/template/functions.php"> - <UndefinedClass occurrences="1"> - <code>'DateTimeFormatter'</code> - </UndefinedClass> - </file> <file src="lib/private/Files/Stream/Encryption.php"> <UndefinedInterfaceMethod occurrences="1"> <code>$cacheEntry</code> @@ -6006,9 +5537,9 @@ </file> <file src="lib/public/AppFramework/Http/ZipResponse.php"> <InvalidArrayAccess occurrences="5"> - <code>$resource['size']</code> - <code>$resource['resource']</code> <code>$resource['internalName']</code> + <code>$resource['resource']</code> + <code>$resource['size']</code> <code>$resource['size']</code> <code>$resource['time']</code> </InvalidArrayAccess> @@ -6039,19 +5570,6 @@ <code>\OC_App::getStorage($app)</code> </FalsableReturnStatement> </file> - <file src="lib/public/Files/Storage.php"> - <InvalidReturnType occurrences="1"> - <code>string|false</code> - </InvalidReturnType> - </file> - <file src="lib/public/Files/Storage/IStorage.php"> - <InvalidParamDefault occurrences="1"> - <code>array</code> - </InvalidParamDefault> - <InvalidReturnType occurrences="1"> - <code>string|false</code> - </InvalidReturnType> - </file> <file src="lib/public/FullTextSearch/Model/ISearchRequest.php"> <InvalidClass occurrences="1"> <code>IsearchRequest</code> |