Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nextcloud/spreed.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Calviño Sánchez <danxuliu@gmail.com>2022-03-17 15:56:39 +0300
committerDaniel Calviño Sánchez <danxuliu@gmail.com>2022-03-17 15:56:39 +0300
commitb35c44bfa0c84e9cb10f92ce08d2f735fa22aea3 (patch)
tree4fce95f7264c6ca037d475d27fe3bb0a3ae50ae7
parenta533dd8c0762aa769a8316b3ac2228acfb1dc5ce (diff)
fixup! Fix permissions not updated in HPB when general permissions changefix-permissions-not-updated-when-general-permissions-change
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
-rw-r--r--lib/Signaling/Listener.php8
1 files changed, 8 insertions, 0 deletions
diff --git a/lib/Signaling/Listener.php b/lib/Signaling/Listener.php
index 9ef467c25..26af22371 100644
--- a/lib/Signaling/Listener.php
+++ b/lib/Signaling/Listener.php
@@ -172,6 +172,14 @@ class Listener {
// Setting the room permissions resets the permissions of all
// participants, even those with custom attendee permissions.
+ // FIXME This approach does not scale, as the update message for all
+ // the sessions in a conversation can exceed the allowed size of the
+ // request in conversations with a large number of participants.
+ // However, note that a single message with the general permissions
+ // to be set on all participants can not be sent either, as the
+ // general permissions could be overriden by custom attendee
+ // permissions in specific participants.
+
/** @var ParticipantService $participantService */
$participantService = \OC::$server->get(ParticipantService::class);
$participants = $participantService->getSessionsAndParticipantsForRoom($event->getRoom());