diff options
| author | Daniel Calviño Sánchez <danxuliu@gmail.com> | 2018-07-18 15:06:57 +0300 |
|---|---|---|
| committer | Daniel Calviño Sánchez <danxuliu@gmail.com> | 2019-09-26 11:45:01 +0300 |
| commit | edc54ea5d57e6019a14b9b70b3065c62d6d8953e (patch) | |
| tree | 929bc4cf215058d5238862d39a07799895f5b125 /tests | |
| parent | b0daa126657df88e6a26fd437fbf565eba54ebdb (diff) | |
Add support for public shares to file rooms
Until now file rooms were available only to users with direct access to
the file. Now file rooms are available to any user or guest too if the
link is publicly shared (with a link share, for example).
Public shares are identified by a share token instead of a file id, so a
new endpoint, which is a counterpart of FilesController but for share
tokens, was added. The file room, however, is still associated to the
file id like before.
When checking if a participant can join a room if the current user is a
user without direct access to the file or a guest it is not even
possible to know if the file id belongs to a publicly shared file. Due
to this when the room is got for a share token the share token is stored
in the session and then used in following requests when checking whether
the participant can join a room or not.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/acceptance/features/app-files.feature | 2 | ||||
| -rw-r--r-- | tests/integration/features/conversation/files.feature | 3 |
2 files changed, 3 insertions, 2 deletions
diff --git a/tests/acceptance/features/app-files.feature b/tests/acceptance/features/app-files.feature index 7cd385236..702d1b235 100644 --- a/tests/acceptance/features/app-files.feature +++ b/tests/acceptance/features/app-files.feature @@ -38,7 +38,7 @@ Feature: app-files # share is ready before continuing. And I write down the shared link And I open the Chat tab in the details view of the Files app - Then I see that the "Start a conversation Share this file with others to discuss Share" empty content message is shown in the chat tab + Then I see that the chat is shown in the Chat tab Scenario: chat tab header is not shown in a folder even if shared Given I am logged in as the admin diff --git a/tests/integration/features/conversation/files.feature b/tests/integration/features/conversation/files.feature index a5aef3177..025c969bb 100644 --- a/tests/integration/features/conversation/files.feature +++ b/tests/integration/features/conversation/files.feature @@ -77,7 +77,8 @@ Feature: conversation/files Scenario: get room for file shared by link Given user "participant1" shares "welcome.txt" by link with OCS 100 - When user "participant1" gets the room for path "welcome.txt" with 404 + When user "participant1" gets the room for path "welcome.txt" with 200 + Then user "participant1" is not participant of room "file welcome.txt room" Scenario: get room for file shared with user and by link Given user "participant1" shares "welcome.txt" by link with OCS 100 |