diff options
author | Maxim Dounin <mdounin@mdounin.ru> | 2022-02-03 22:46:01 +0300 |
---|---|---|
committer | Maxim Dounin <mdounin@mdounin.ru> | 2022-02-03 22:46:01 +0300 |
commit | 0a90893da03517a17562feb69b170af0365b2068 (patch) | |
tree | c4c08967742632d6b9056bcd94ff6461b993a35c /src | |
parent | a52433a04c58821fd95591e474d35995292f1090 (diff) |
HTTP/2: fixed closed_nodes overflow (ticket #1708).
With large http2_max_concurrent_streams or http2_max_concurrent_pushes, more
than 255 ngx_http_v2_node_t structures might be allocated, eventually leading
to h2c->closed_nodes overflow when closing corresponding streams. This will
in turn result in additional allocations in ngx_http_v2_get_node_by_id().
While mostly harmless, it can result in excessive memory usage by a HTTP/2
connection, notably in configurations with many keepalive_requests allowed.
Fix is to use ngx_uint_t for h2c->closed_nodes instead of unsigned:8.
Diffstat (limited to 'src')
-rw-r--r-- | src/http/v2/ngx_http_v2.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/http/v2/ngx_http_v2.h b/src/http/v2/ngx_http_v2.h index 70ee287ae..4e252931c 100644 --- a/src/http/v2/ngx_http_v2.h +++ b/src/http/v2/ngx_http_v2.h @@ -153,12 +153,12 @@ struct ngx_http_v2_connection_s { ngx_queue_t dependencies; ngx_queue_t closed; + ngx_uint_t closed_nodes; ngx_uint_t last_sid; ngx_uint_t last_push; time_t lingering_time; - unsigned closed_nodes:8; unsigned settings_ack:1; unsigned table_update:1; unsigned blocked:1; |