diff options
| author | Brian White <mscdex@mscdex.net> | 2020-02-16 11:50:01 +0300 |
|---|---|---|
| committer | Brian White <mscdex@mscdex.net> | 2020-03-06 07:41:56 +0300 |
| commit | 5cc0754090b4dc504652ea57803312c9b9f1cef0 (patch) | |
| tree | 1a496f02f0bc94c69d47992372dfd538ba7ea959 | |
| parent | c3c64a1034a52e58c9684a0135a2e4ce536e41ef (diff) | |
benchmark: remove problematic tls params
These very small values can cause crashes/exceptions to occur on some
systems because most time is spent in V8 GC or in parts of node core
that are not being tested (e.g. streams).
PR-URL: https://github.com/nodejs/node/pull/31816
Reviewed-By: James M Snell <jasnell@gmail.com>
| -rw-r--r-- | benchmark/tls/secure-pair.js | 2 | ||||
| -rw-r--r-- | benchmark/tls/throughput.js | 2 | ||||
| -rw-r--r-- | test/benchmark/test-benchmark-tls.js | 4 |
3 files changed, 4 insertions, 4 deletions
diff --git a/benchmark/tls/secure-pair.js b/benchmark/tls/secure-pair.js index c52f4cbf918..bb7933d837f 100644 --- a/benchmark/tls/secure-pair.js +++ b/benchmark/tls/secure-pair.js @@ -3,7 +3,7 @@ const common = require('../common.js'); const bench = common.createBenchmark(main, { dur: [5], securing: ['SecurePair', 'TLSSocket', 'clear'], - size: [2, 100, 1024, 1024 * 1024] + size: [100, 1024, 1024 * 1024] }); const fixtures = require('../../test/common/fixtures'); diff --git a/benchmark/tls/throughput.js b/benchmark/tls/throughput.js index 727d20e4600..3ea84aa84ef 100644 --- a/benchmark/tls/throughput.js +++ b/benchmark/tls/throughput.js @@ -3,7 +3,7 @@ const common = require('../common.js'); const bench = common.createBenchmark(main, { dur: [5], type: ['buf', 'asc', 'utf'], - size: [2, 1024, 1024 * 1024, 4 * 1024 * 1024, 16 * 1024 * 1024] + size: [100, 1024, 1024 * 1024, 4 * 1024 * 1024, 16 * 1024 * 1024] }); const fixtures = require('../../test/common/fixtures'); diff --git a/test/benchmark/test-benchmark-tls.js b/test/benchmark/test-benchmark-tls.js index 40c14af8302..264fa08d396 100644 --- a/test/benchmark/test-benchmark-tls.js +++ b/test/benchmark/test-benchmark-tls.js @@ -19,9 +19,9 @@ runBenchmark('tls', 'concurrency=1', 'dur=0.1', 'n=1', - 'size=2', + 'size=1024', 'securing=SecurePair', - 'type=asc' + 'type=buf' ], { NODEJS_BENCHMARK_ZERO_ALLOWED: 1, |