diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2020-10-23 06:55:21 +0300 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2020-10-26 14:41:51 +0300 |
| commit | 9ff25b19ac6c4b239aeeca5d9534523ff91eddf7 (patch) | |
| tree | e9714548ddb24987aa449d5f6f7ae2073e807dd8 | |
| parent | ba465c5ff60a970a79a14d910f6ef6d7ef5143f4 (diff) | |
src: remove ignore GCC -Wcast-function-type for v8
This reverts Commit 3ff2aeceba88928f1aa33fe3ff1cc9bf84da739b ("src:
ignore GCC -Wcast-function-type for v8.h") and Commit
2462a2c5d7b5ae7e28a0fdefdf4fd5e8eb0ff5ed ("src: fix ignore GCC
-Wcast-function-type for older compilers") as this has
now been included in the V8 version being used.
PR-URL: https://github.com/nodejs/node/pull/35768
Refs: https://github.com/v8/v8/commit/f08cbfdc4051266e4200b6e26775d35307b1259b
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
| -rw-r--r-- | src/base_object-inl.h | 7 | ||||
| -rw-r--r-- | src/node.h | 7 | ||||
| -rw-r--r-- | src/util.h | 7 |
3 files changed, 0 insertions, 21 deletions
diff --git a/src/base_object-inl.h b/src/base_object-inl.h index 0b620ab864f..b9f99a03ddf 100644 --- a/src/base_object-inl.h +++ b/src/base_object-inl.h @@ -28,14 +28,7 @@ #include "env-inl.h" #include "util.h" -#if (__GNUC__ >= 8) && !defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wcast-function-type" -#endif #include "v8.h" -#if (__GNUC__ >= 8) && !defined(__clang__) -#pragma GCC diagnostic pop -#endif namespace node { diff --git a/src/node.h b/src/node.h index 6f93fc89e1f..0dc2de975b8 100644 --- a/src/node.h +++ b/src/node.h @@ -60,14 +60,7 @@ # define SIGKILL 9 #endif -#if (__GNUC__ >= 8) && !defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wcast-function-type" -#endif #include "v8.h" // NOLINT(build/include_order) -#if (__GNUC__ >= 8) && !defined(__clang__) -#pragma GCC diagnostic pop -#endif #include "v8-platform.h" // NOLINT(build/include_order) #include "node_version.h" // NODE_MODULE_VERSION diff --git a/src/util.h b/src/util.h index d3c5fdd74ed..92f51baf374 100644 --- a/src/util.h +++ b/src/util.h @@ -24,14 +24,7 @@ #if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS -#if (__GNUC__ >= 8) && !defined(__clang__) -#pragma GCC diagnostic push -#pragma GCC diagnostic ignored "-Wcast-function-type" -#endif #include "v8.h" -#if (__GNUC__ >= 8) && !defined(__clang__) -#pragma GCC diagnostic pop -#endif #include <climits> #include <cstddef> |