diff options
| author | Richard Lau <riclau@uk.ibm.com> | 2019-10-17 21:02:36 +0300 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-10-22 21:52:53 +0300 |
| commit | b5b7e585f07c962a8329e021e9a9c56ce8a71420 (patch) | |
| tree | 13b25fb5bda16f73cb93264e262d22ec7f0f465e /Makefile | |
| parent | 2dc70657a33d19e67fb8db4de4169a11371c5763 (diff) | |
build: make linter failures fail `test-doc` target
Linter failures in the `test-doc` make target were not failing the
build if the subsequent `doctools` test passed as its exit code
wasn't being preserved.
Make the `lint` target a dependency of `test-doc` so that it is
outside of the `node_use_openssl` guard -- its own dependencies
have their own guards where necessary and the targets that don't
require an available node (e.g. the C++ linters) will be allowed
to run.
PR-URL: https://github.com/nodejs/node/pull/30012
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -592,11 +592,10 @@ test-hash-seed: all $(NODE) test/pummel/test-hash-seed.js .PHONY: test-doc -test-doc: doc-only ## Builds, lints, and verifies the docs. +test-doc: doc-only lint ## Builds, lints, and verifies the docs. @if [ "$(shell $(node_use_openssl))" != "true" ]; then \ echo "Skipping test-doc (no crypto)"; \ else \ - $(MAKE) lint; \ $(PYTHON) tools/test.py $(PARALLEL_ARGS) doctool; \ fi |