diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-07-03 13:38:05 +0300 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-07-14 23:40:12 +0300 |
commit | 518ffc125680f0916635d2ed97c076dbff3bd05b (patch) | |
tree | f30156086d5c8f5083cf753f3b9bd8bab45e8528 /README.md | |
parent | efc39464b0d813f15188d2d9cf14b74bcca61750 (diff) |
zlib: do not coalesce multiple `.flush()` calls
This is an approach to address the issue linked below. Previously,
when `.write()` and `.flush()` calls to a zlib stream were interleaved
synchronously (i.e. without waiting for these operations to finish),
multiple flush calls would have been coalesced into a single flushing
operation.
This patch changes behaviour so that each `.flush()` all corresponds
to one flushing operation on the underlying zlib resource, and the
order of operations is as if the `.flush()` call were a `.write()`
call.
One test had to be removed because it specifically tested the previous
behaviour.
As a drive-by fix, this also makes sure that all flush callbacks are
called. Previously, that was not the case.
Fixes: https://github.com/nodejs/node/issues/28478
PR-URL: https://github.com/nodejs/node/pull/28520
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'README.md')
0 files changed, 0 insertions, 0 deletions