diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2019-06-07 12:36:39 +0300 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2019-06-15 01:40:50 +0300 |
| commit | 30f285da314dc5c9fa7457784d948bf5ddfab361 (patch) | |
| tree | 4f258648d139d058e75656ef658e9b40a3af5b54 /configure.py | |
| parent | 16edec8cfab1d88e86de75057b669ccaea5ced87 (diff) | |
build: fix icu-i18n pkg-config version check
The pkg_config() helper can either return a tuple of None values
(no pkg-config installed) and that was what the check was testing
for, but it can also return a tuple of empty strings when the
package isn't installed.
PR-URL: https://github.com/nodejs/node/pull/28118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'configure.py')
| -rwxr-xr-x | configure.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/configure.py b/configure.py index 71943cae2c5..9d9f0aec0b8 100755 --- a/configure.py +++ b/configure.py @@ -1348,7 +1348,7 @@ def configure_intl(o): # ICU from pkg-config. o['variables']['v8_enable_i18n_support'] = 1 pkgicu = pkg_config('icu-i18n') - if pkgicu[0] is None: + if not pkgicu[0]: error('''Could not load pkg-config data for "icu-i18n". See above errors or the README.md.''') (libs, cflags, libpath, icuversion) = pkgicu |