diff options
| author | Matteo Collina <hello@matteocollina.com> | 2020-05-12 12:18:34 +0300 |
|---|---|---|
| committer | Matteo Collina <hello@matteocollina.com> | 2020-05-15 13:14:35 +0300 |
| commit | 2d5d77306f6dff9110c1f77fefab25f973415770 (patch) | |
| tree | 446d3e1342bc7736054cd788aa4b286114331aa0 /doc/api/vm.md | |
| parent | 24bf1adacc61a96111ae3ad06afba6f9b7f435a7 (diff) | |
Revert "vm: add importModuleDynamically option to compileFunction"
This reverts commit 74c393dd93cc0e461e3796fbcc09545fcacdecaf.
Fixes: https://github.com/nodejs/node/issues/33166
PR-URL: https://github.com/nodejs/node/pull/33364
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'doc/api/vm.md')
| -rw-r--r-- | doc/api/vm.md | 15 |
1 files changed, 4 insertions, 11 deletions
diff --git a/doc/api/vm.md b/doc/api/vm.md index 982ec8412d5..a28fc27a889 100644 --- a/doc/api/vm.md +++ b/doc/api/vm.md @@ -88,7 +88,7 @@ changes: This option is part of the experimental modules API, and should not be considered stable. * `specifier` {string} specifier passed to `import()` - * `script` {vm.Script} + * `module` {vm.Module} * Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is recommended in order to take advantage of error tracking, and to avoid issues with namespaces that contain `then` function exports. @@ -807,6 +807,9 @@ changes: - v13.14.0 pr-url: https://github.com/nodejs/node/pull/32985 description: The `importModuleDynamically` option is now supported. + - version: REPLACEME + pr-url: https://github.com/nodejs/node/pull/33364 + description: Removal of `importModuleDynamically` due to compatibility issues --> * `code` {string} The body of the function to compile. @@ -829,16 +832,6 @@ changes: * `contextExtensions` {Object[]} An array containing a collection of context extensions (objects wrapping the current scope) to be applied while compiling. **Default:** `[]`. - * `importModuleDynamically` {Function} Called during evaluation of this module - when `import()` is called. If this option is not specified, calls to - `import()` will reject with [`ERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING`][]. - This option is part of the experimental modules API, and should not be - considered stable. - * `specifier` {string} specifier passed to `import()` - * `function` {Function} - * Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is - recommended in order to take advantage of error tracking, and to avoid - issues with namespaces that contain `then` function exports. * Returns: {Function} Compiles the given code into the provided context (if no context is |