diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-09-29 02:29:07 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-11-19 15:47:29 +0300 |
| commit | 7e6104f1bb63a07885b08f277c3b708caa6b8a23 (patch) | |
| tree | 32d76e6f055d3bfacd849633db3a8af3868a328c /node.gyp | |
| parent | efce655c0f1671d0e86b5c89092ac93db983ef94 (diff) | |
src: introduce custom smart pointers for `BaseObject`s
Referring to `BaseObject` instances using standard C++ smart pointers
can interfere with BaseObject’s own cleanup mechanisms
(explicit delete, delete-on-GC and delete-on-cleanup).
Introducing custom smart pointers allows referring to `BaseObject`s
safely while keeping those mechanisms intact.
Refs: https://github.com/nodejs/quic/pull/141
Refs: https://github.com/nodejs/quic/pull/149
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/30374
Refs: https://github.com/nodejs/quic/pull/165
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'node.gyp')
| -rw-r--r-- | node.gyp | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -1100,6 +1100,7 @@ 'test/cctest/node_test_fixture.h', 'test/cctest/test_aliased_buffer.cc', 'test/cctest/test_base64.cc', + 'test/cctest/test_base_object_ptr.cc', 'test/cctest/test_node_postmortem_metadata.cc', 'test/cctest/test_environment.cc', 'test/cctest/test_linked_binding.cc', |