diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-08-25 02:41:02 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-09-02 18:37:54 +0300 |
| commit | f911e09ab435f5ab8a8e50a6d59aa9a01923058d (patch) | |
| tree | 209bc8006873c1733f4229f63f4a831d70993348 /src/node_buffer.h | |
| parent | 37cd10a1165537d25cd73454ffa81a4e964a56f7 (diff) | |
src: deprecate option variables in public API
These variables should never have been exposed as part of the
public API, and certainly not as variables. Using CLI options
parser is the right thing to do here, at least until we expose
some part of the options parser API publicly (which should be
possible to do now).
PR-URL: https://github.com/nodejs/node/pull/22515
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'src/node_buffer.h')
| -rw-r--r-- | src/node_buffer.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/node_buffer.h b/src/node_buffer.h index e8d306e7dd6..c1e3b859483 100644 --- a/src/node_buffer.h +++ b/src/node_buffer.h @@ -27,8 +27,9 @@ namespace node { -// TODO(addaleax): Deprecate and remove this ASAP. -extern bool zero_fill_all_buffers; +// TODO(addaleax): Remove this. +NODE_DEPRECATED("use command-line flags", + extern bool zero_fill_all_buffers); namespace Buffer { |