diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2022-04-11 19:38:57 +0300 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2022-04-19 21:21:24 +0300 |
| commit | 43d2e247c7c198fcbbded3e13fa3996687848660 (patch) | |
| tree | 8c7fb864301760019572f3824ef5fc3e02b082ba /src/node_external_reference.cc | |
| parent | 77373aa5d69a64f4bd9842163043dce260c30c49 (diff) | |
bootstrap: move embedded snapshot to SnapshotBuilder
So that the embedded snapshot can be reused by the worker.
PR-URL: https://github.com/nodejs/node/pull/42702
Refs: https://github.com/nodejs/node/issues/35711
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_external_reference.cc')
| -rw-r--r-- | src/node_external_reference.cc | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/src/node_external_reference.cc b/src/node_external_reference.cc index 94198719b6a..9a89977094b 100644 --- a/src/node_external_reference.cc +++ b/src/node_external_reference.cc @@ -7,9 +7,11 @@ namespace node { const std::vector<intptr_t>& ExternalReferenceRegistry::external_references() { - CHECK(!is_finalized_); - external_references_.push_back(reinterpret_cast<intptr_t>(nullptr)); - is_finalized_ = true; + if (!is_finalized_) { + external_references_.push_back(reinterpret_cast<intptr_t>(nullptr)); + is_finalized_ = true; + } + return external_references_; } |