diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-05-20 14:39:21 +0300 |
---|---|---|
committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-06-03 18:27:49 +0300 |
commit | a0d86befb5251736af84a5d261ba49948baf7c73 (patch) | |
tree | 891920a1931ff2aaf0a8e4322c6aa59c9abf982a /src/node_worker.h | |
parent | a1a690e07c92d209cfecb2e7725ce649287edf26 (diff) |
src: reorganize inspector and diagnostics initialization
- Split the initialization of the inspector and other diagnostics
into `Environment::InitializeInspector()` and
`Environment::InitializeDiagnostics()` - these need to be
reinitialized separately after snapshot deserialization.
- Do not store worker url alongside the inspector parent handle,
instead just get it from the handle.
- Rename `Worker::profiler_idle_notifier_started_` to
`Worker::start_profiler_idle_notifier_` because it stores
the state inherited from the parent env to use for initializing
itself.
PR-URL: https://github.com/nodejs/node/pull/27539
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'src/node_worker.h')
-rw-r--r-- | src/node_worker.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/node_worker.h b/src/node_worker.h index 8239826a0e8..0e659a9f522 100644 --- a/src/node_worker.h +++ b/src/node_worker.h @@ -54,7 +54,6 @@ class Worker : public AsyncWrap { private: void OnThreadStopped(); void CreateEnvMessagePort(Environment* env); - const std::string url_; std::shared_ptr<PerIsolateOptions> per_isolate_opts_; std::vector<std::string> exec_argv_; @@ -62,7 +61,7 @@ class Worker : public AsyncWrap { MultiIsolatePlatform* platform_; v8::Isolate* isolate_ = nullptr; - bool profiler_idle_notifier_started_; + bool start_profiler_idle_notifier_; uv_thread_t tid_; #if NODE_USE_V8_PLATFORM && HAVE_INSPECTOR |