diff options
| author | Ryan Dahl <ry@tinyclouds.org> | 2011-07-19 00:45:11 +0400 |
|---|---|---|
| committer | Ryan Dahl <ry@tinyclouds.org> | 2011-07-19 00:47:56 +0400 |
| commit | 85404c5c558ebbba3aaf27c56d1edccc2061d664 (patch) | |
| tree | 1115666dc81798d0b6c7d7f80f6d7b7974601fb0 /src/pipe_wrap.cc | |
| parent | e5cceffe6a59e6702b373051817f590acdcdf036 (diff) | |
Move HandleWrap rules to one place
Diffstat (limited to 'src/pipe_wrap.cc')
| -rw-r--r-- | src/pipe_wrap.cc | 21 |
1 files changed, 0 insertions, 21 deletions
diff --git a/src/pipe_wrap.cc b/src/pipe_wrap.cc index 4d8f35239e3..adbeb0f8c18 100644 --- a/src/pipe_wrap.cc +++ b/src/pipe_wrap.cc @@ -4,27 +4,6 @@ #include <handle_wrap.h> #include <stream_wrap.h> -// Rules: -// -// - Do not throw from handle methods. Set errno. -// -// - MakeCallback may only be made directly off the event loop. -// That is there can be no JavaScript stack frames underneith it. -// (Is there anyway to assert that?) -// -// - No use of v8::WeakReferenceCallback. The close callback signifies that -// we're done with a handle - external resources can be freed. -// -// - Reusable? -// -// - The uv_close_cb is used to free the c++ object. The close callback -// is not made into javascript land. -// -// - uv_ref, uv_unref counts are managed at this layer to avoid needless -// js/c++ boundary crossing. At the javascript layer that should all be -// taken care of. - - #define UNWRAP \ assert(!args.Holder().IsEmpty()); \ assert(args.Holder()->InternalFieldCount() > 0); \ |