diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-12-18 17:16:02 +0300 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-12-24 16:31:28 +0300 |
| commit | bbca4a8a3d28272bd63f799e503937dfa6f75097 (patch) | |
| tree | 59e8cc9a83784cfe51e9085c12bc5864a6f0c3ae /src | |
| parent | db109e85d678faf581433250bb1442f5eb24de61 (diff) | |
src,test: use v8::Global instead of v8::Persistent
This is in preparation for a lint rule forbidding usage of
`v8::Persistent`.
PR-URL: https://github.com/nodejs/node/pull/31018
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Diffstat (limited to 'src')
| -rw-r--r-- | src/api/async_resource.cc | 1 | ||||
| -rw-r--r-- | src/node.h | 2 |
2 files changed, 1 insertions, 2 deletions
diff --git a/src/api/async_resource.cc b/src/api/async_resource.cc index eef80c85f44..0a2437fe6ed 100644 --- a/src/api/async_resource.cc +++ b/src/api/async_resource.cc @@ -24,7 +24,6 @@ AsyncResource::AsyncResource(Isolate* isolate, AsyncResource::~AsyncResource() { EmitAsyncDestroy(env_, async_context_); - resource_.Reset(); } MaybeLocal<Value> AsyncResource::MakeCallback(Local<Function> callback, diff --git a/src/node.h b/src/node.h index 50f85ae3389..d43693c0338 100644 --- a/src/node.h +++ b/src/node.h @@ -893,7 +893,7 @@ class NODE_EXTERN AsyncResource { private: Environment* env_; - v8::Persistent<v8::Object> resource_; + v8::Global<v8::Object> resource_; async_context async_context_; }; |