diff options
| author | Yihong Wang <yh.wang@ibm.com> | 2018-03-08 00:34:10 +0300 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-03-11 06:04:14 +0300 |
| commit | b325b5b435bcde9a2580e8ed05044b5cb352a5fd (patch) | |
| tree | ca31eb7dade0576a3b6136bab4f2fe811a9c4ccd /test/abort | |
| parent | e0bd2f31e584d8b188148084f97e80bc1573e555 (diff) | |
test: fix test-abort-backtrace in shared lib build
When using shared lib build, the binary path in the stack frames points
to shared lib. Change the checking criteria in the test case to match
that.
Refs: https://github.com/nodejs/node/issues/18535
Signed-off-by: Yihong Wang <yh.wang@ibm.com>
PR-URL: https://github.com/nodejs/node/pull/19213
Refs: https://github.com/nodejs/node/issues/18535
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'test/abort')
| -rw-r--r-- | test/abort/test-abort-backtrace.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/test/abort/test-abort-backtrace.js b/test/abort/test-abort-backtrace.js index e69ac3ddfde..7f87ef0e7f4 100644 --- a/test/abort/test-abort-backtrace.js +++ b/test/abort/test-abort-backtrace.js @@ -19,7 +19,8 @@ if (process.argv[2] === 'child') { } if (!common.isWindows) { - if (!frames.some((frame) => frame.includes(`[${process.execPath}]`))) { + const { getBinaryPath } = require('../common/shared-lib-util'); + if (!frames.some((frame) => frame.includes(`[${getBinaryPath()}]`))) { assert.fail(`Some frames should include the binary name:\n${stderr}`); } } |