diff options
author | Rich Trott <rtrott@gmail.com> | 2019-12-22 06:08:36 +0300 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-12-25 03:14:05 +0300 |
commit | 9c566e6289fe11b4bc78717941dae09bea2b4e6e (patch) | |
tree | 51ccb92f73fe2df34c8870c7c57ff207fab4cb63 /test | |
parent | e23bf8f771aa0bd60e25ff079985fc29b5846403 (diff) |
doc,vm,test: remove _sandbox_ from vm documentation
The vm documentation uses the word _sandbox_ but has a significant
disclaimer about how that should not be interpreted to connote security
guarantees. Remove the term "sandbox" from documentation. As a result,
some code and tests also need to change.
PR-URL: https://github.com/nodejs/node/pull/31057
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'test')
-rw-r--r-- | test/parallel/test-vm-context.js | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/test/parallel/test-vm-context.js b/test/parallel/test-vm-context.js index 53326942d89..edb66908f10 100644 --- a/test/parallel/test-vm-context.js +++ b/test/parallel/test-vm-context.js @@ -64,25 +64,25 @@ try { // This is outside of catch block to confirm catch block ran. assert.strictEqual(gh1140Exception.toString(), 'Error'); -const nonContextualSandboxError = { +const nonContextualObjectError = { code: 'ERR_INVALID_ARG_TYPE', type: TypeError, message: /must be of type object/ }; -const contextifiedSandboxError = { +const contextifiedObjectError = { code: 'ERR_INVALID_ARG_TYPE', type: TypeError, - message: /The "contextifiedSandbox" argument must be an vm\.Context/ + message: /The "contextifiedObject" argument must be an vm\.Context/ }; [ - [undefined, nonContextualSandboxError], - [null, nonContextualSandboxError], - [0, nonContextualSandboxError], - [0.0, nonContextualSandboxError], - ['', nonContextualSandboxError], - [{}, contextifiedSandboxError], - [[], contextifiedSandboxError] + [undefined, nonContextualObjectError], + [null, nonContextualObjectError], + [0, nonContextualObjectError], + [0.0, nonContextualObjectError], + ['', nonContextualObjectError], + [{}, contextifiedObjectError], + [[], contextifiedObjectError] ].forEach((e) => { common.expectsError(() => { script.runInContext(e[0]); }, e[1]); common.expectsError(() => { vm.runInContext('', e[0]); }, e[1]); |