Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-06-11tools: fix `create-or-update-pull-request-action` hash on GHAAntoine du Hamel
PR-URL: https://github.com/nodejs/node/pull/43378 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
2022-06-11tools: fix find-inactive actionsLivia Medeiros
PR-URL: https://github.com/nodejs/node/pull/43377 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-06-05tools: use hashes instead of tags for external actions (#43284)Antoine du Hamel
Using tags is a security risk, as they can be updated to point to anything else. Refs: https://github.com/nodejs/corepack/pull/117#discussion_r886913592 PR-URL: https://github.com/nodejs/node/pull/43284 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-06-02tools: update `codecov/codecov-action` versionAntoine du Hamel
Refs: https://github.com/codecov/codecov-action/releases PR-URL: https://github.com/nodejs/node/pull/43297 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
2022-05-22tools: refactor build-addons.js to ESMFeng Yu
PR-URL: https://github.com/nodejs/node/pull/43099 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-05-21tools: refactor update-authors.js to ESMFeng Yu
PR-URL: https://github.com/nodejs/node/pull/43098 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-05-17bootstrap: include code cache in the embedded snapshotJoyee Cheung
Since V8 code cache encodes indices to the read-only space it is safer to make sure that the code cache is generated in the same heap used to generate the embdded snapshot. This patch merges the code cache builder into the snapshot builder and makes the code cache part of node::SnapshotData that is deserialized into the native module loader during bootstrap. PR-URL: https://github.com/nodejs/node/pull/43023 Fixes: https://github.com/nodejs/node/issues/31074 Refs: https://github.com/nodejs/node/issues/35711 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2022-05-15build: set ASAN workaroundRichard Lau
PR-URL: https://github.com/nodejs/node/pull/43085 Refs: https://github.com/google/sanitizers/issues/1322 Refs: https://github.com/nodejs/node/issues/43082 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-05-14build: disable windows-2022 temporarilyJiawen Geng
PR-URL: https://github.com/nodejs/node/pull/43093 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-05-08tools: refactor lint-sh.js to esm moduleFeng Yu
PR-URL: https://github.com/nodejs/node/pull/42942 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-04-20build: fix format-cppDarshan Sen
According to the logs in https://github.com/nodejs/node/pull/42681#issuecomment-1100856089, `make format-cpp` exits with an NZEC. This change intentionally ignores the error code because it is irrelevant. We already check if the formatter produced a diff in the next line. Refs: https://github.com/nodejs/node/pull/42681#issuecomment-1100856089 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42764 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-04-20build: improve the format-cpp error messageDarshan Sen
This change specifies the target branch name instead of leaving that to the committer to fill in. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42765 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-04-13build: run clang-format on CIDarshan Sen
We already include the tool inside tools/clang-format, so we should start using it on CI. This attempts to run the linter only on the commits present in an opened PR. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/42681 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2022-04-04build: consolidate JS and md linting GitHub ActionsRich Trott
Linting markdown runs the JavaScript linting job, so consolidate them to conserve time and resources. Run JavaScript separately, but then run markdown linting so it can use the cached results of the JavaScript linting. PR-URL: https://github.com/nodejs/node/pull/42572 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-04-03build: set stale action back to running nightlyMichael Dawson
I manually ran over the last number of weeks so that we did not mark all of the stale isssues all at once. We are not caught up so we can go to running daily. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/42549 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: James M Snell <jasnell@gmail.com>
2022-03-30tools: update GHA actions versionAntoine du Hamel
PR-URL: https://github.com/nodejs/node/pull/42498 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-03-28build: bump actions/checkoutEliaz Bobadilla
https://github.com/actions/checkout\#checkout-v3 PR-URL: https://github.com/nodejs/node/pull/42460 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-03-09build: rename tools workflow and add undici to itMichaël Zasso
The workflow already updates Corepack, which is a `deps`, not a `tool`. Add subsystem and label variables to the matrix to better control the automated pull requests and add undici to the updated deps. PR-URL: https://github.com/nodejs/node/pull/42246 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
2022-03-08meta: add dependencies label to label-pr-configMestery
PR-URL: https://github.com/nodejs/node/pull/42129 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2022-03-03build: drop shortened URL from lint-commit-messageRichard Lau
The shortened link to the commit message guidelines no longer works after they were moved from `docs/guides` to `docs/contributing`. Now that `core-validate-commit` outputs an error message pointing to the full URL of the commit message guidelines on failure we no longer need to include the URL (shortened or otherwise) in the workflow title. PR-URL: https://github.com/nodejs/node/pull/42168 Refs: https://github.com/nodejs/core-validate-commit/pull/95 Refs: https://github.com/nodejs/node/issues/41697 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-02-28build: fix usage of input in feature actionMichael Dawson
Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/42150 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
2022-02-28build: increase max ops for stale feature actionMichael Dawson
Set the limit to match the number used in the close stalled action. Required as not all eligeable stale features are being processed. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/42130 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-02-26build: add corepack to the auto-updated dependenciesMaël Nison
PR-URL: https://github.com/nodejs/node/pull/42090 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
2022-02-25build: last test of the stale feature actionMichael Dawson
- set the days so that we process ~ 40 issues so that we can see what kind of feedback we get on saying we are going to close stale feature requests - set the label to stale instead of stalled so that there is no race with the action that closes stalled issues - fix the links to the feature management doc Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/42085 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
2022-02-23meta: correct link to feature request documentSimen Bekkhus
PR-URL: https://github.com/nodejs/node/pull/42092 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2022-02-23build: update feature close action for testingMichael Dawson
This should process the 4 oldest feature requests. Once we've confirmed these are ok we can adjust the days before an issue is marked as stale. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/42082 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-02-18build: cancel running CI jobs when a PR is updatedMichaël Zasso
Refs: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-using-a-fallback-value PR-URL: https://github.com/nodejs/node/pull/42017 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-02-18build: increase operations and test tagMichael Dawson
- increase the operations as 1 was too small to do anything - add an additional tag that must be present before the action will run. I will manually add that tag to some feature requests to be able to test Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/42038 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-02-17build: allow manual run of feature request actionMichael Dawson
add "workflow_dispatch:" so that action can be run manuallyl for debugging. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/42037 Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
2022-02-17build: add action to close stale feature requestsMichael Dawson
Implement the prodecure outlined in https://github.com/nodejs/node/blob/master/doc/contributing/feature-request-management.md Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/41981 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
2022-02-17meta: use plain emojis instead of escape sequencesMestery
Refs: https://github.com/nodejs/node/issues/41987 PR-URL: https://github.com/nodejs/node/pull/41989 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-02-16build: prevent concurrent CI and CQ workflow runsMichaël Zasso
Use concurrency groups to prevent new runs from being started while a previous job is already running. This can happen when a lot of unrelated jobs are pending because of runner exhaustion. PR-URL: https://github.com/nodejs/node/pull/42016 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-02-15build: move tool updates workflow runtime a day laterRich Trott
Refs: https://github.com/nodejs/node/pull/41973#issuecomment-1039780665 PR-URL: https://github.com/nodejs/node/pull/41982 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Mestery <mestery@protonmail.com>
2022-02-14build,tools: change the quotes in YAMLMestery
Remove useless quotes and use single quotes when needed. PR-URL: https://github.com/nodejs/node/pull/41756 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
2022-02-08build: revert fast-track changesFilip Skokan
PR-URL: https://github.com/nodejs/node/pull/41892 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-02-07build: improve consistency between workflowsMestery
PR-URL: https://github.com/nodejs/node/pull/41791 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-02-04doc: feature management proposalMichael Dawson
Refs: https://github.com/nodejs/node/discussions/40823 Refs: https://github.com/nodejs/node/issues/41113 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/41420 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2022-01-18doc: make contributing info more discoverableMichael Dawson
There are been several discussions in recent PRs about the docs related to contributing not being very discoverable. Move these docs from doc/guides/ to doc/contributing. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/41408 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>
2022-01-13build: fix workflow access to git historyRich Trott
Refs: https://github.com/nodejs/node/pull/41466 PR-URL: https://github.com/nodejs/node/pull/41472 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tierney Cyren <hello@bnb.im>
2022-01-05meta: add required fields in issue templatesRich Trott
Make sure there is at least one required field in each issue template. Leave the title blank to enforce that as a required field as well. PR-URL: https://github.com/nodejs/node/pull/41378 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-12-31meta: replace API docs issue template with formRich Trott
All other issue templates have been moved to forms, which seems to do a good job of reducing spam issues. PR-URL: https://github.com/nodejs/node/pull/41348 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com>
2021-12-28meta: replace feature request template with formRich Trott
The bug report form doesn't seem to result in many invalid/spam reports, but the template still results in lots of issues opened by apparent bots that don't modify the default template imput. Change the feature request template to a form to hopefully better serve people proposing features and reduce bot-generated junk issues. PR-URL: https://github.com/nodejs/node/pull/41317 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
2021-12-23meta: update node-api team nameRichard Lau
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`. PR-URL: https://github.com/nodejs/node/pull/41268 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-12-19build: improve readability of texts in workflowsMestery
PR-URL: https://github.com/nodejs/node/pull/40988 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2021-12-18tools: fix CQ and auto-start-ci jobsAntoine du Hamel
PR-URL: https://github.com/nodejs/node/pull/41230 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2021-12-18tools: fix GitHub Actions status when CQ is emptyAntoine du Hamel
Refs: https://github.com/nodejs/node/pull/40985#issuecomment-995252065 PR-URL: https://github.com/nodejs/node/pull/41193 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2021-12-16meta: remove community-committee from CODEOWNERSRich Trott
Files previously managed by TSC + CommComm are now managed by TSC. PR-URL: https://github.com/nodejs/node/pull/41169 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Michael Dawson <midawson@redhat.com>
2021-12-16build,tools: automate enforcement of emeritus criteriaRich Trott
PR-URL: https://github.com/nodejs/node/pull/41155 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Stewart X Addison <sxa@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Gus Caplan <me@gus.host>
2021-12-15build: fix comment-labeled workflowMestery
Refs: https://github.com/nodejs/node/pull/40985#issuecomment-994056146 PR-URL: https://github.com/nodejs/node/pull/41176 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2021-12-14build: use gh cli in workflows fileMestery
PR-URL: https://github.com/nodejs/node/pull/40985 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>