Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/nodejs/node.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
path: root/doc
AgeCommit message (Collapse)Author
2022-06-14doc: add initial doc on how to update cjs-module-lexerMichael Dawson
Add some initial doc based on discussion with Guy Bedford. Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/43255 Reviewed-By: Guy Bedford <guybedford@gmail.com>
2022-06-14doc: clarify use of deps/icu-smallMichael Dawson
Add some additional info about use of icu subset in deps/icu-small Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: https://github.com/nodejs/node/pull/43287 Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
2022-06-13doc: remove llnode from diag tierlistTony Gorez
PR-URL: https://github.com/nodejs/node/pull/43289 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2022-06-13doc: remove ETW from diag tierlistTony Gorez
PR-URL: https://github.com/nodejs/node/pull/43295 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2022-06-13doc: use serial comma in report docsTobias Nießen
Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43394 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Harshitha K P <harshitha014@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2022-06-12doc: add fspromises mkdir exampleTierney Cyren
Signed-off-by: Tierney Cyren <hello@bnb.im> PR-URL: https://github.com/nodejs/node/pull/40843 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2022-06-11crypto: remove Node.js-specific webcrypto extensionsFilip Skokan
PR-URL: https://github.com/nodejs/node/pull/43310 Reviewed-By: James M Snell <jasnell@gmail.com>
2022-06-10doc: fix typo in globals.mdDaeyeon Jeong
Use apostrophe for possessive. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/43365 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-06-09doc: use serial comma in webstreams docsTobias Nießen
Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43353 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2022-06-09doc: fix specifier example in `esm.md`hiroki osame
PR-URL: https://github.com/nodejs/node/pull/43351 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-06-08doc: change glossary link in pull request guide to node's glossary docFeng Yu
PR-URL: https://github.com/nodejs/node/pull/43318 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-06-07doc: fix typo in util.parseArgs usage exampleMichael Ficarra
PR-URL: https://github.com/nodejs/node/pull/43332 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>
2022-06-07doc: improve description of TZTobias Nießen
- Simplify the beginning of the description. - Add a missing serial comma. - Add a missing parenthesis. PR-URL: https://github.com/nodejs/node/pull/43334 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-06-07doc: use serial comma in net docsTobias Nießen
Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43335 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-06-06doc: make clear the result of comparison between Symbol.forKohei Ueno
PR-URL: https://github.com/nodejs/node/pull/43309 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-06-05doc: add missing require to stream api docFeng Yu
PR-URL: https://github.com/nodejs/node/pull/43237 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-06-05doc: use serial comma in pull request docFeng Yu
PR-URL: https://github.com/nodejs/node/pull/43319 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
2022-06-05doc: use serial comma in ESM docsTobias Nießen
Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43322 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2022-06-04report: add more heap infos in process reporttheanarkh
PR-URL: https://github.com/nodejs/node/pull/43116 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2022-06-04crypto: add CFRG curves to Web Crypto APIFilip Skokan
PR-URL: https://github.com/nodejs/node/pull/42507 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-06-03doc: promote cdt to tier 3Tony Gorez
PR-URL: https://github.com/nodejs/node/pull/43290 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
2022-06-03fs: export constants from `fs/promises`Feng Yu
PR-URL: https://github.com/nodejs/node/pull/43177 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-06-03doc: fix chromium document link in pull-requests.mdrikapo
PR-URL: https://github.com/nodejs/node/pull/43265 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Qingyu Deng <i@ayase-lab.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-06-02doc: update CHANGELOG_V18.mdFilip Skokan
PR-URL: https://github.com/nodejs/node/pull/43298 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-06-022022-06-01, Version 18.3.0 (Current)Bryan English
Notable changes: * deps: update undici to 5.4.0 (Node.js GitHub Bot) https://github.com/nodejs/node/pull/43262 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) https://github.com/nodejs/node/pull/42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) https://github.com/nodejs/node/pull/41397 * deps: upgrade npm to 8.11.0 (npm team) https://github.com/nodejs/node/pull/43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) https://github.com/nodejs/node/pull/43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) https://github.com/nodejs/node/pull/42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) https://github.com/nodejs/node/pull/42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) https://github.com/nodejs/node/pull/41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) https://github.com/nodejs/node/pull/43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](https://github.com/nodejs/node/pull/42740) * This means 32-bit Windows binaries are back with this release. PR-URL: https://github.com/nodejs/node/pull/43266
2022-06-022022-06-01, Version 17.9.1 (Current)Ruy Adorno
Notable changes: * Upgrade npm to 8.11.0 * Update to OpenSSL 3.0.3 PR-URL: https://github.com/nodejs/node/pull/43256
2022-06-022022-06-01, Version 16.15.1 'Gallium' (LTS)Juan José Arboleda
Notable changes: - deps: upgrade npm to 8.11.0 (<npm-cli+bot@github.com>) https://github.com/nodejs/node/pull/43210 - doc: - add release key for RafaelGSS (Rafael Gonzaga) https://github.com/nodejs/node/pull/43131 - add release key for Juan Arboleda (Juan José) https://github.com/nodejs/node/pull/42961 PR-URL: https://github.com/nodejs/node/pull/43272
2022-06-01doc: add src/crypto to CC list for nodejs/cryptoTobias Nießen
PR-URL: https://github.com/nodejs/node/pull/43286 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-05-31doc: use serial comma in console docsTobias Nießen
Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43257 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-05-31src,doc,test: add --openssl-shared-config optionDaniel Bevenius
This commit adds a new command line option named '--openssl-shared-config' intended to allow reverting to the old OpenSSL configuration behavior where Node.js would use the configuration section name (called appname in OpenSSL) 'openssl_conf' which could potentially be used my other applications.. PR-URL: https://github.com/nodejs/node/pull/43124 Refs: https://github.com/nodejs/node/issues/40366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com>
2022-05-30doc: use serial comma in errors docsTobias Nießen
Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43242 Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-05-29doc: add note regarding `%Array.prototype.concat%` in `primordials.md`Antoine du Hamel
PR-URL: https://github.com/nodejs/node/pull/43166 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-05-28doc: use serial comma in worker_threads docsTobias Nießen
Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43220 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2022-05-27doc: fix napi version for node_api_symbol_forDanielle Adams
PR-URL: https://github.com/nodejs/node/pull/42878 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
2022-05-27node-api: emit uncaught-exception on unhandled tsfn callbackslegendecas
PR-URL: https://github.com/nodejs/node/pull/36510 Fixes: https://github.com/nodejs/node/issues/36402 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2022-05-25doc: document `signal` option for `EventTarget#addEventListener`Antoine du Hamel
Refs: https://github.com/nodejs/node/pull/36258 PR-URL: https://github.com/nodejs/node/pull/43170 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-05-24util: add parseArgs moduleBenjamin E. Coe
Adds util.parseArgs helper for higher level command-line argument parsing. PR-URL: https://github.com/nodejs/node/pull/42675 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruy Adorno <ruyadorno@github.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joe Sepi <sepi@joesepi.com> Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
2022-05-24http2: improve tests and docsDaeyeon Jeong
This commit documents the event parameters and `http2stream.respond`, and adds some tests to ensure the actual behaviors are aligned with the docs. Testing the 'Http2Server.sessionError' event is added by updating `test/parallel/test-http2-options-max-headers-exceeds-nghttp2.js`. The event seemingly has not been tested so far. `ServerHttp2Session` is exported to validate the `session` event and the `sessionError` event. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/42858 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2022-05-24doc: make minor adjustmentsLivia Medeiros
PR-URL: https://github.com/nodejs/node/pull/43175 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
2022-05-24doc: use serial comma in dgram docsTobias Nießen
Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43191 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-05-23net: add ability to reset a tcp socketpupilTong
Fixes: https://github.com/nodejs/node/issues/27428 PR-URL: https://github.com/nodejs/node/pull/43112 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
2022-05-23http: add uniqueHeaders option to request and createServerShogun
PR-URL: https://github.com/nodejs/node/pull/41397 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2022-05-22doc: use serial comma in process docsTobias Nießen
Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43179 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-05-22tools: refactor build-addons.js to ESMFeng Yu
PR-URL: https://github.com/nodejs/node/pull/43099 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-05-22doc: improved parallel specificationmawaregetsuka
PR-URL: https://github.com/nodejs/node/pull/42679 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-05-22doc: improve callback params for `fs.mkdir`Daeyeon Jeong
fixes: https://github.com/nodejs/node/issues/43015 Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/43016 Fixes: https://github.com/nodejs/node/issues/43015 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
2022-05-22doc: remove outdated footnote (Python 2 --> 3 for V8 tests)DeeDeeG
Various Python 3 compatibility fixes were made in upstream V8, and they have even dropped Python 2 compatibility in various scripts. depot_tools, which bootstraps the V8 build, is also moving to Python 3. As of Node v18.0.0-ish, this footnote is no-longer accurate. (Running `make test-v8` no-longer requires Python 2, and it won't work anymore if you don't have a copy of Python 3.) PR-URL: https://github.com/nodejs/node/pull/43105 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com> Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
2022-05-20doc: use serial comma in assert docsTobias Nießen
Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43154 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2022-05-20doc: fix errors in Performance hooks docOneNail
PR-URL: https://github.com/nodejs/node/pull/43152 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
2022-05-19doc: use serial comma in dns docsTobias Nießen
Refs: https://github.com/nodejs/node/pull/11321 Refs: https://github.com/nodejs/node/pull/17384 PR-URL: https://github.com/nodejs/node/pull/43145 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>