diff options
| author | Gar <gar+gh@danger.computer> | 2022-03-24 23:23:02 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-24 23:23:02 +0300 |
| commit | 716a07fde7905bb69e4c6f1991bb7289589a6669 (patch) | |
| tree | a415c2acb0c4a08cc4338dcf17a0cdc6fda18680 /.github | |
| parent | 6dd1139c9f302ac71f47a75e70bbe9cdf2e64960 (diff) | |
fix: 100% coverage in tests (#4607)
* fix: 100% coverage in tests
* Removed dead code in `lib/utils/usage.js`.
* Removed dead code in `lib/base-command.js`.
* Removed "load-all" test, we currently have 100% coverage and new PRs
without tests will be rejected if they don't add coverage for new
files.
* Removed `check-coverage` script as a separate command.
* Removed separate coverage test in ci.yml.
* Removed `coverage` flag from tap config, the default is already to
enforce 100% coverage.
Removed a tiny bit of dead code resulting from this
* fix: clean up usage output
Removed usage lib, rolled logic into base-command.js
Cleaned up usage output to be less redundant
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/ci.yml | 20 |
1 files changed, 2 insertions, 18 deletions
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b6b912593..5ebc711ae 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -145,22 +145,6 @@ jobs: node ./bin/npm-cli.js install --ignore-scripts --no-audit node ./bin/npm-cli.js rebuild - # Run the tests, but not if we're just gonna do coveralls later anyway + # Run the tests - name: Run Tap tests - if: matrix.platform.os != 'ubuntu-latest' || matrix.node-version != '16.x' - run: node ./bin/npm-cli.js run --ignore-scripts test -- -t600 -Rbase -c - env: - DEPLOY_VERSION: testing - - # Run coverage check - - name: Run coverage report - if: matrix.platform.os == 'ubuntu-latest' && matrix.node-version == '16.x' - # turn off --check-coverage until 100%, so CI failure is relevant - run: node ./bin/npm-cli.js run check-coverage -- -t600 --no-check-coverage -Rbase -c - env: - DEPLOY_VERSION: testing - COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_OPTIONAL_TOKEN }} - - # - name: Run sudo tests on Linux - # if: matrix.os == 'ubuntu-latest' - # run: sudo PATH=$PATH $(which node) . test -- --coverage --timeout 600 + run: node ./bin/npm-cli.js run test --ignore-scripts -- -t600 -Rbase -c |