diff options
| author | Luke Karrys <luke@lukekarrys.com> | 2022-04-26 23:27:01 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-26 23:27:01 +0300 |
| commit | e163a0b4ba6da539c43f5af09d58aa45d964a720 (patch) | |
| tree | 972a04d13cc5ab4973b283fcc9e02dae327573e6 /.github | |
| parent | e9163b48d8e46a80d2a4cc98c492b94dfa152cb8 (diff) | |
chore(benchmark): add comment permission check and filter paths (#4766)
The updates the issue comment check in the benchmark script, so it only
will trigger if posted by a user with admin rights to the repo. It also
changes the comment to trigger it to `@npm-robot benchmark this`
For pull requests, it now limits benchmarks only when the files changed
include something inside `lib/`.
Requires https://github.com/npm/benchmarks/pull/30 to be merged in the
benchmark repo to allow `issue_comment` as a valid trigger.
Diffstat (limited to '.github')
| -rw-r--r-- | .github/workflows/benchmark.yml | 23 |
1 files changed, 21 insertions, 2 deletions
diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 1d8e3455c..2e363cb30 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -4,6 +4,8 @@ on: pull_request: branches: - '*' + paths: + - lib/** issue_comment: types: - created @@ -18,7 +20,8 @@ jobs: github.event_name == 'pull_request' || ( github.event_name == 'issue_comment' && github.event.issue.pull_request && - startsWith(github.event.comment.body, 'test this please ✅') + github.event.issue.state == 'open' && + startsWith(github.event.comment.body, '@npm-robot benchmark this') ) env: # gh cli uses these env vars for owner/repo/token @@ -39,6 +42,12 @@ jobs: PR="${{ github.event.pull_request.number }}" else PR="${{ github.event.issue.number }}" + SENDER="${{ github.event.issue.sender.login }}" + ROLE=$(gh api repos/${OWNER}/${REPO}/collaborators/${SENDER}/permission -q '.permission') + if [[ "$ROLE" != "admin"]]; then + echo "${SENDER} is ${ROLE}, not an admin, exiting" + exit 0 + fi fi EVENT="${EVENT_NAME} ${OWNER}/${REPO}#${PR}" @@ -58,11 +67,21 @@ jobs: if: | github.event_name == 'issue_comment' && github.event.issue.pull_request && - startsWith(github.event.comment.body, 'test this please ✅') + github.event.issue.state == 'open' && + startsWith(github.event.comment.body, '@npm-robot benchmark this') env: # gh cli uses this env var as the token GITHUB_TOKEN: ${{ secrets.NPM_BENCHMARKS_TOKEN }} run: | + OWNER="${{ github.event.repository.owner.login }}" + REPO="${{ github.event.repository.name }}" + SENDER="${{ github.event.issue.sender.login }}" + ROLE=$(gh api repos/${OWNER}/${REPO}/collaborators/${SENDER}/permission -q '.permission') + if [[ "$ROLE" != "admin"]]; then + echo "${SENDER} is ${ROLE}, not an admin, exiting" + exit 0 + fi + COMMENT_NODE_ID="${{ github.event.comment.node_id }}" QUERY='mutation ($inputData:AddReactionInput!) { addReaction (input:$inputData) { |