logical-tree: Make it mutate to improve performance

The clone we were doing to save ourselves from mutation proved to be
excessively slow. While lodash is being updated to not have the
same scaling issues, it was determined that we weren't gaining
anything from not mutating here, so there was no reason to pay
even a lesser price.

PR-URL: https://github.com/npm/npm/pull/9803
Fixes: #8826

1 files changed, 3 insertions, 2 deletions

diff --git a/lib/ls.js b/lib/ls.js
index 64f36bd22..1854938eb 100644
--- a/lib/ls.js
+++ b/lib/ls.js
@@ -16,7 +16,7 @@ var color = require('ansicolors')
 var npa = require('npm-package-arg')
 var iferr = require('iferr')
 var npm = require('./npm.js')
-var logicalTree = require('./install/logical-tree.js')
+var mutateIntoLogicalTree = require('./install/mutate-into-logical-tree.js')
 var recalculateMetadata = require('./install/deps.js').recalculateMetadata
 var getPackageId = require('./install/get-package-id.js')
 
@@ -61,7 +61,8 @@ var lsFromTree = ls.fromTree = function (dir, physicalTree, args, silent, cb) {
     })
   }
 
-  var data = logicalTree.asReadInstalled(physicalTree)
+  var data = mutateIntoLogicalTree.asReadInstalled(physicalTree)
+
   pruneNestedExtraneous(data)
   filterByEnv(data)
   var bfs = filterFound(bfsify(data), args)