fix(exit-handler): always warn if not called

If the exit handler wasn't called it is always a problem, even if there
is no exit code.

PR-URL: https://github.com/npm/cli/pull/3561
Credit: @wraithgar
Close: #3561
Reviewed-by: @lukekarrys

1 files changed, 5 insertions, 6 deletions

diff --git a/test/lib/utils/exit-handler.js b/test/lib/utils/exit-handler.js
index 981ac9a32..c88a1aef6 100644
--- a/test/lib/utils/exit-handler.js
+++ b/test/lib/utils/exit-handler.js
@@ -336,15 +336,14 @@ t.test('defaults to log error msg if stack is missing', (t) => {
   t.end()
 })
 
-t.test('exits cleanly when emitting exit event', (t) => {
-  t.plan(1)
+t.test('exits uncleanly when only emitting exit event', (t) => {
+  t.plan(2)
 
   npm.log.level = 'silent'
   process.emit('exit')
-  t.match(
-    npm.log.record.find(r => r.level === 'info'),
-    { prefix: 'ok', message: '' }
-  )
+  const logData = fs.readFileSync(logFile, 'utf8')
+  t.match(logData, 'Exit handler never called!')
+  t.match(process.exitCode, 1, 'exitCode coerced to 1')
   t.end()
 })